Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix api 2020-01-01-preview dataDiskSizeGB parameter name #10280

Merged
merged 2 commits into from
Jul 30, 2020

Conversation

a-santamaria
Copy link
Member

@a-santamaria a-santamaria commented Jul 28, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@a-santamaria a-santamaria requested a review from samedder as a code owner July 28, 2020 17:30
@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 28, 2020

[Staging] Swagger Validation Report

BreakingChange: 8 Errors, 0 Warnings [Detail] [Expand]
Rule Message
1008 - ModifiedOperationId The operation id has been changed from 'ClusterVersions_ListByOS' to 'ManagedClusterVersions_ListByOS'. This will impact generated code.
New: Microsoft.ServiceFabric/preview/2020-01-01-preview/managedcluster.json#L379:7
Old: Microsoft.ServiceFabric/preview/2020-01-01-preview/managedcluster.json#L379:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'diskSizeInGB' renamed or removed?
New: Microsoft.ServiceFabric/preview/2020-01-01-preview/nodetype.json#L583:7
Old: Microsoft.ServiceFabric/preview/2020-01-01-preview/nodetype.json#L583:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'diskSizeInGB' renamed or removed?
New: Microsoft.ServiceFabric/preview/2020-01-01-preview/nodetype.json#L583:7
Old: Microsoft.ServiceFabric/preview/2020-01-01-preview/nodetype.json#L583:7
1034 - AddedRequiredProperty The new version has new required property 'dataDiskSizeGB' that was not found in the old version.
New: Microsoft.ServiceFabric/preview/2020-01-01-preview/nodetype.json#L583:7
Old: Microsoft.ServiceFabric/preview/2020-01-01-preview/nodetype.json#L583:7
1034 - AddedRequiredProperty The new version has new required property 'dataDiskSizeGB' that was not found in the old version.
New: Microsoft.ServiceFabric/preview/2020-01-01-preview/nodetype.json#L550:9
Old: Microsoft.ServiceFabric/preview/2020-01-01-preview/nodetype.json#L550:9
1034 - AddedRequiredProperty The new version has new required property 'dataDiskSizeGB' that was not found in the old version.
New: Microsoft.ServiceFabric/preview/2020-01-01-preview/nodetype.json#L583:7
Old: Microsoft.ServiceFabric/preview/2020-01-01-preview/nodetype.json#L583:7
1034 - AddedRequiredProperty The new version has new required property 'dataDiskSizeGB' that was not found in the old version.
New: Microsoft.ServiceFabric/preview/2020-01-01-preview/nodetype.json#L577:5
Old: Microsoft.ServiceFabric/preview/2020-01-01-preview/nodetype.json#L577:5
1041 - AddedPropertyInResponse The new version has a new property 'dataDiskSizeGB' in response that was not found in the old version.
New: Microsoft.ServiceFabric/preview/2020-01-01-preview/nodetype.json#L583:7
Old: Microsoft.ServiceFabric/preview/2020-01-01-preview/nodetype.json#L583:7
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
Posted by Swagger Pipeline | How to fix these errors?

@openapi-assignment-bot openapi-assignment-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 28, 2020
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 28, 2020

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 28, 2020

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 28, 2020

azure-sdk-for-js - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 28, 2020

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 6c86b77 with merge commit 4873ee8. SDK Automation 13.0.17.20200619.4
  • ️✔️sdk/servicefabric/mgmt-v2016_09_01 [View full logs]  [Release SDK Changes]
  • ⚠️sdk/servicefabric/mgmt-v2017_07_01_preview [View full logs]  [Release SDK Changes]
      [mvn] [ERROR] COMPILATION ERROR : 
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/servicefabric/mgmt-v2017_07_01_preview/src/main/java/com/microsoft/azure/management/servicefabric/v2017_07_01_preview/implementation/ClusterImpl.java:[40,22] no suitable method found for createAsync(java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClusterInner)
      [mvn]     method com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClustersInner.createAsync(java.lang.String,java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClusterInner,com.microsoft.rest.ServiceCallback) is not applicable
      [mvn]       (actual and formal argument lists differ in length)
      [mvn]     method com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClustersInner.createAsync(java.lang.String,java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClusterInner) is not applicable
      [mvn]       (actual and formal argument lists differ in length)
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/servicefabric/mgmt-v2017_07_01_preview/src/main/java/com/microsoft/azure/management/servicefabric/v2017_07_01_preview/implementation/ClusterImpl.java:[54,22] no suitable method found for updateAsync(java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.ClusterUpdateParameters)
      [mvn]     method com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClustersInner.updateAsync(java.lang.String,java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.ClusterUpdateParameters,com.microsoft.rest.ServiceCallback) is not applicable
      [mvn]       (actual and formal argument lists differ in length)
      [mvn]     method com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClustersInner.updateAsync(java.lang.String,java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.ClusterUpdateParameters) is not applicable
      [mvn]       (actual and formal argument lists differ in length)
      [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-servicefabric: Compilation failure: Compilation failure: 
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/servicefabric/mgmt-v2017_07_01_preview/src/main/java/com/microsoft/azure/management/servicefabric/v2017_07_01_preview/implementation/ClusterImpl.java:[40,22] no suitable method found for createAsync(java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClusterInner)
      [mvn] [ERROR]     method com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClustersInner.createAsync(java.lang.String,java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClusterInner,com.microsoft.rest.ServiceCallback) is not applicable
      [mvn] [ERROR]       (actual and formal argument lists differ in length)
      [mvn] [ERROR]     method com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClustersInner.createAsync(java.lang.String,java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClusterInner) is not applicable
      [mvn] [ERROR]       (actual and formal argument lists differ in length)
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/servicefabric/mgmt-v2017_07_01_preview/src/main/java/com/microsoft/azure/management/servicefabric/v2017_07_01_preview/implementation/ClusterImpl.java:[54,22] no suitable method found for updateAsync(java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.ClusterUpdateParameters)
      [mvn] [ERROR]     method com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClustersInner.updateAsync(java.lang.String,java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.ClusterUpdateParameters,com.microsoft.rest.ServiceCallback) is not applicable
      [mvn] [ERROR]       (actual and formal argument lists differ in length)
      [mvn] [ERROR]     method com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClustersInner.updateAsync(java.lang.String,java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.ClusterUpdateParameters) is not applicable
      [mvn] [ERROR]       (actual and formal argument lists differ in length)
      [mvn] [ERROR] -> [Help 1]
      [mvn] [ERROR] 
      [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
      [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
      [mvn] [ERROR] 
      [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
      [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
    • ️✔️sdk/servicefabric/mgmt-v2018_02_01 [View full logs]  [Release SDK Changes]

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jul 28, 2020

    azure-sdk-for-net - Release

    ️✔️ succeeded [Logs] [Expand Details]

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jul 28, 2020

    azure-sdk-for-python - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from 6c86b77 with merge commit 4873ee8. SDK Automation 13.0.17.20200619.4
    • ️✔️azure-mgmt-servicefabric [View full logs]  [Release SDK Changes]
      [build_conf] INFO:packaging_tools:Building template azure-mgmt-servicefabric
      [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
      [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
      [build_conf] INFO:packaging_tools:Template done azure-mgmt-servicefabric
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
      [ChangeLog] Size of delta 29.536% size of original (original: 73016 chars, delta: 21566 chars)
      [ChangeLog] **Features**
      [ChangeLog] 
      [ChangeLog]   - Model StatelessServiceProperties has a new parameter instance_close_delay_duration
      [ChangeLog]   - Model StatelessServiceProperties has a new parameter service_dns_name
      [ChangeLog]   - Model ApplicationResourceUpdate has a new parameter managed_identities
      [ChangeLog]   - Model StatelessServiceUpdateProperties has a new parameter instance_close_delay_duration
      [ChangeLog]   - Model ClusterUpdateParameters has a new parameter application_type_versions_cleanup_policy
      [ChangeLog]   - Model DiagnosticsStorageAccountConfig has a new parameter protected_account_key_name2
      [ChangeLog]   - Model ApplicationResource has a new parameter managed_identities
      [ChangeLog]   - Model ApplicationResource has a new parameter identity
      [ChangeLog]   - Model ServiceResource has a new parameter service_dns_name
      [ChangeLog]   - Model StatefulServiceProperties has a new parameter service_dns_name
      [ChangeLog]   - Model ApplicationUpgradePolicy has a new parameter upgrade_mode
      [ChangeLog]   - Model ServiceResourceProperties has a new parameter service_dns_name
      [ChangeLog]   - Model Cluster has a new parameter application_type_versions_cleanup_policy
      [ChangeLog]   - Added operation group ManagedClusterVersionsOperations
      [ChangeLog]   - Added operation group NodeTypesOperations
      [ChangeLog]   - Added operation group ManagedClustersOperations

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jul 28, 2020

    azure-sdk-for-python-track2 - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jul 28, 2020

    Trenton Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @azuresdkci
    Copy link
    Contributor

    Can one of the admins verify this patch?

    @a-santamaria
    Copy link
    Member Author

    @fengzhou-msft this was a mistake on the dataDiskSizeGB parameter name. can we bypass the breaking change errors?

    @ravbhatnagar
    Copy link
    Contributor

    This change will break the preview customers. Is your service ok with breaking the existing customers? how many customers are using it that will be impacted? Please look at all these datapoints before taking the call.
    Signing off from ARM side.

    @ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 28, 2020
    @a-santamaria
    Copy link
    Member Author

    thanks @ravbhatnagar, this api version is not yet available on the ARM manifest we only have it for our test region behind a feature flag

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @a-santamaria
    Copy link
    Member Author

    @fengzhou-msft can we bypass the breaking changes and merge the pr please?

    @fengzhou-msft fengzhou-msft added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jul 30, 2020
    @fengzhou-msft fengzhou-msft merged commit 4873ee8 into Azure:master Jul 30, 2020
    00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
    * fix dataDiskSizeGB parameter name
    
    * rename ManagedClusterVersions to differentiate with non-managed model
    
    Co-authored-by: Alfredo Santamaria Gomez <[email protected]>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants