Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Microsoft.HybridNetwork from RPSaaSMaster to master. #10232

Merged
merged 3 commits into from
Jul 23, 2020
Merged

Merge Microsoft.HybridNetwork from RPSaaSMaster to master. #10232

merged 3 commits into from
Jul 23, 2020

Conversation

swatika
Copy link
Contributor

@swatika swatika commented Jul 22, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 22, 2020

[Staging] Swagger Validation Report

️✔️BreakingChange [Detail]
 There are no breaking changes. 
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
Posted by Swagger Pipeline | How to fix these errors?

@openapi-assignment-bot openapi-assignment-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 22, 2020
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 22, 2020

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 4278482 with merge commit 5d1d7e6. SDK Automation 13.0.17.20200619.4
    Failed to find any diff after autorest so no changed packages was found.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 22, 2020

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 22, 2020

azure-sdk-for-js - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 4278482 with merge commit 5d1d7e6. SDK Automation 13.0.17.20200619.4
    Failed to find any diff after autorest so no changed packages was found.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 22, 2020

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 4278482 with merge commit 5d1d7e6. SDK Automation 13.0.17.20200619.4
    Failed to find any changed packages. Please check the changed file list.
    /z/work/azure-sdk-for-python/sdk/azure-mgmt/hybridnetwork/__init__.py
    /z/work/azure-sdk-for-python/sdk/azure-mgmt/hybridnetwork/_configuration.py
    /z/work/azure-sdk-for-python/sdk/azure-mgmt/hybridnetwork/_hybrid_network_management_client.py
    /z/work/azure-sdk-for-python/sdk/azure-mgmt/hybridnetwork/models/__init__.py
    /z/work/azure-sdk-for-python/sdk/azure-mgmt/hybridnetwork/models/_hybrid_network_management_client_enums.py
    /z/work/azure-sdk-for-python/sdk/azure-mgmt/hybridnetwork/models/_models.py
    /z/work/azure-sdk-for-python/sdk/azure-mgmt/hybridnetwork/models/_models_py3.py
    /z/work/azure-sdk-for-python/sdk/azure-mgmt/hybridnetwork/models/_paged_models.py
    /z/work/azure-sdk-for-python/sdk/azure-mgmt/hybridnetwork/operations/__init__.py
    /z/work/azure-sdk-for-python/sdk/azure-mgmt/hybridnetwork/operations/_devices_operations.py
    /z/work/azure-sdk-for-python/sdk/azure-mgmt/hybridnetwork/operations/_operations.py
    /z/work/azure-sdk-for-python/sdk/azure-mgmt/hybridnetwork/operations/_vendor_sku_preview_operations.py
    /z/work/azure-sdk-for-python/sdk/azure-mgmt/hybridnetwork/operations/_vendor_skus_operations.py
    /z/work/azure-sdk-for-python/sdk/azure-mgmt/hybridnetwork/operations/_vendor_virtual_network_functions_operations.py
    /z/work/azure-sdk-for-python/sdk/azure-mgmt/hybridnetwork/operations/_vendors_operations.py
    /z/work/azure-sdk-for-python/sdk/azure-mgmt/hybridnetwork/operations/_virtual_network_function_vendor_skus_operations.py
    /z/work/azure-sdk-for-python/sdk/azure-mgmt/hybridnetwork/operations/_virtual_network_function_vendors_operations.py
    /z/work/azure-sdk-for-python/sdk/azure-mgmt/hybridnetwork/operations/_virtual_network_functions_operations.py
    /z/work/azure-sdk-for-python/sdk/azure-mgmt/hybridnetwork/version.py

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 22, 2020

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 22, 2020

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 22, 2020

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 22, 2020

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@pilor pilor added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 22, 2020
Copy link
Contributor

@pilor pilor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straight port of what was previously reviewed in RPSaaSMaster so no new API review needed. Ensure you fix up the error contract problems though.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yungezz yungezz merged commit 5d1d7e6 into Azure:master Jul 23, 2020
00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants