[Datashare]Add sorting and filter options to the API's #10211

vnvaditya · 2020-07-21T04:51:38Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

openapi-pipeline-app · 2020-07-21T04:51:43Z

[Staging] Swagger Validation Report

️️✔️BreakingChange [Detail]

 There are no breaking changes.

️️✔️LintDiff [Detail]

 Validation passes for LintDiff.

️️✔️Avocado [Detail]

 Validation passes for Avocado.

_{Posted by Swagger Pipeline | How to fix these errors?}

azure-pipelines · 2020-07-21T04:51:55Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-07-21T04:53:19Z

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-07-21T04:53:19Z

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-07-21T04:53:20Z

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from d551907 with merge commit 9d3e3fa. SDK Automation 13.0.17.20200619.4
️✔️datashare/mgmt/2019-11-01 [View full logs] [Release SDK Changes]
- datashare.mgmt.2019-11-01.zip
️✔️preview/datashare/mgmt/2018-11-01-preview [View full logs] [Release SDK Changes]
- preview.datashare.mgmt.2018-11-01-preview.zip

openapi-sdkautomation · 2020-07-21T04:53:22Z

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from d551907 with merge commit 9d3e3fa. SDK Automation 13.0.17.20200619.4
```
Failed to find any diff after autorest so no changed packages was found.
```

openapi-sdkautomation · 2020-07-21T04:53:28Z

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-07-21T04:53:34Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from d551907 with merge commit 9d3e3fa. SDK Automation 13.0.17.20200619.4

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.DataShare [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.DataShare.1.0.1.nupkg
- Microsoft.Azure.Management.DataShare.1.0.1.snupkg

openapi-sdkautomation · 2020-07-21T04:55:03Z

azure-sdk-for-js - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-07-21T04:56:48Z

Azure CLI Extension Generation - Release

Installation instruction for service datashare [Preview Changes]
az extension add --source=https://sdkautomation.blob.core.windows.net/sdkautomation-pipeline/Azure/azure-rest-api-specs/10211/azure-cli-extensions/Azure/azure-cli-extensions/datashare/datashare-0.1.0-py3-none-any.whl

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from d551907 with merge commit 9d3e3fa. Azure CLI Automation 13.0.17.20200619.4

[AutoRest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
[AutoRest] 
[AutoRest] NO TEST SCENARIO PROVIDED - DEFAULT WILL BE USED
[AutoRest] ADD FOLLOWING SECTION TO readme.cli.md FILE TO MODIFY IT
[AutoRest] --------------------------------------------------------
[AutoRest]   test-scenario:
[AutoRest]     - name: /Accounts/put/Accounts_Create
[AutoRest]     - name: /Accounts/get/Accounts_Get
[AutoRest]     - name: /Accounts/get/Accounts_ListByResourceGroup
[AutoRest]     - name: /Accounts/get/Accounts_ListBySubscription
[AutoRest]     - name: /Accounts/patch/Accounts_Update
[AutoRest]     - name: /ConsumerInvitations/get/ConsumerInvitations_Get
[AutoRest]     - name: /ConsumerInvitations/get/ConsumerInvitations_ListInvitations
[AutoRest]     - name: /ConsumerInvitations/post/ConsumerInvitations_RejectInvitation
[AutoRest]     - name: /ConsumerSourceDataSets/get/ConsumerSourceDataSets_ListByShareSubscription
[AutoRest]     - name: /DataSetMappings/put/DataSetMappings_Create
[AutoRest]     - name: /DataSetMappings/put/DataSetMappings_SqlDB_Create
[AutoRest]     - name: /DataSetMappings/put/DataSetMappings_SqlDWDataSetToAdlsGen2File_Create
[AutoRest]     - name: /DataSetMappings/put/DataSetMappings_SqlDW_Create
[AutoRest]     - name: /DataSetMappings/get/DataSetMappings_Get
[AutoRest]     - name: /DataSetMappings/get/DataSetMappings_ListByShareSubscription
[AutoRest]     - name: /DataSets/put/DataSets_Create
[AutoRest]     - name: /DataSets/put/DataSets_KustoCluster_Create
[AutoRest]     - name: /DataSets/put/DataSets_KustoDatabase_Create
[AutoRest]     - name: /DataSets/put/DataSets_SqlDBTable_Create
[AutoRest]     - name: /DataSets/put/DataSets_SqlDWTable_Create
[AutoRest]     - name: /DataSets/get/DataSets_Get
[AutoRest]     - name: /DataSets/get/DataSets_ListByShare
[AutoRest]     - name: /Invitations/put/Invitations_Create
[AutoRest]     - name: /Invitations/get/Invitations_Get
[AutoRest]     - name: /Invitations/get/Invitations_ListByShare
[AutoRest]     - name: /ProviderShareSubscriptions/get/ProviderShareSubscriptions_GetByShare
[AutoRest]     - name: /ProviderShareSubscriptions/get/ProviderShareSubscriptions_ListByShare
[AutoRest]     - name: /ProviderShareSubscriptions/post/ProviderShareSubscriptions_Reinstate
[AutoRest]     - name: /ProviderShareSubscriptions/post/ProviderShareSubscriptions_Revoke
[AutoRest]     - name: /ShareSubscriptions/put/ShareSubscriptions_Create
[AutoRest]     - name: /ShareSubscriptions/get/ShareSubscriptions_Get
[AutoRest]     - name: /ShareSubscriptions/get/ShareSubscriptions_ListByAccount
[AutoRest]     - name: /ShareSubscriptions/post/ShareSubscriptions_CancelSynchronization
[AutoRest]     - name: /ShareSubscriptions/post/ShareSubscriptions_ListSourceShareSynchronizationSettings
[AutoRest]     - name: /ShareSubscriptions/post/ShareSubscriptions_ListSynchronizationDetails
[AutoRest]     - name: /ShareSubscriptions/post/ShareSubscriptions_ListSynchronizations
[AutoRest]     - name: /ShareSubscriptions/post/ShareSubscriptions_Synchronize
[AutoRest]     - name: /Shares/put/Shares_Create
[AutoRest]     - name: /Shares/get/Shares_Get
[AutoRest]     - name: /Shares/get/Shares_ListByAccount
[AutoRest]     - name: /Shares/post/Shares_ListSynchronizationDetails
[AutoRest]     - name: /Shares/post/Shares_ListSynchronizations
[AutoRest]     - name: /SynchronizationSettings/put/SynchronizationSettings_Create
[AutoRest]     - name: /SynchronizationSettings/get/SynchronizationSettings_Get
[AutoRest]     - name: /SynchronizationSettings/get/SynchronizationSettings_ListByShare
[AutoRest]     - name: /Triggers/put/Triggers_Create
[AutoRest]     - name: /Triggers/get/Triggers_Get
[AutoRest]     - name: /Triggers/get/Triggers_ListByShareSubscription
[AutoRest]     - name: /Accounts/delete/Accounts_Delete
[AutoRest]     - name: /DataSetMappings/delete/DataSetMappings_Delete
[AutoRest]     - name: /DataSets/delete/DataSets_Delete
[AutoRest]     - name: /Invitations/delete/Invitations_Delete
[AutoRest]     - name: /ShareSubscriptions/delete/ShareSubscriptions_Delete
[AutoRest]     - name: /Shares/delete/Shares_Delete
[AutoRest]     - name: /SynchronizationSettings/delete/SynchronizationSettings_Delete
[AutoRest]     - name: /Triggers/delete/Triggers_Delete
[AutoRest] --------------------------------------------------------

️✔️datashare [View full logs] [Release Azure CLI Changes]
- datashare-0.1.0-py3-none-any.whl
- datashare-0.1.0.zip

vnvaditya · 2020-07-21T05:10:04Z

We just added filter and orderby as query parameters.
Also, we sorted all the API's alphabetically. so going forward, things will be smooth.

azuresdkci · 2020-07-21T05:18:20Z

Can one of the admins verify this patch?

pilor · 2020-07-22T18:21:34Z

Just query parameters added to a preview api-version. No ARM API review required

Co-authored-by: Aditya Vutukuri <[email protected]>

add sorting and filter options

d551907

openapi-assignment-bot bot assigned ruowan Jul 21, 2020

openapi-sdkautomation bot mentioned this pull request Jul 21, 2020

[AutoPR datashare] Add sorting and filter options to the API's AzureSDKAutomation/azure-cli-extensions#151

Closed

vnvaditya changed the title ~~Add sorting and filter options to the API's~~ [Datashare]Add sorting and filter options to the API's Jul 21, 2020

pilor added ARMReviewInProgress ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMReviewInProgress labels Jul 22, 2020

ruowan approved these changes Jul 24, 2020

View reviewed changes

ruowan merged commit 9d3e3fa into Azure:master Jul 24, 2020

00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020

add sorting and filter options (Azure#10211)

32f1776

Co-authored-by: Aditya Vutukuri <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Datashare]Add sorting and filter options to the API's #10211

[Datashare]Add sorting and filter options to the API's #10211

vnvaditya commented Jul 21, 2020 •

edited

Loading

openapi-pipeline-app bot commented Jul 21, 2020 •

edited

Loading

azure-pipelines bot commented Jul 21, 2020

openapi-sdkautomation bot commented Jul 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 21, 2020 •

edited

Loading

vnvaditya commented Jul 21, 2020

azuresdkci commented Jul 21, 2020

pilor commented Jul 22, 2020

[Datashare]Add sorting and filter options to the API's #10211

[Datashare]Add sorting and filter options to the API's #10211

Conversation

vnvaditya commented Jul 21, 2020 • edited Loading

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-pipeline-app bot commented Jul 21, 2020 • edited Loading

[Staging] Swagger Validation Report

azure-pipelines bot commented Jul 21, 2020

openapi-sdkautomation bot commented Jul 21, 2020 • edited Loading

Trenton Generation - Release

openapi-sdkautomation bot commented Jul 21, 2020 • edited Loading

azure-sdk-for-java - Release

openapi-sdkautomation bot commented Jul 21, 2020 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Jul 21, 2020 • edited Loading

azure-sdk-for-python - Release

openapi-sdkautomation bot commented Jul 21, 2020 • edited Loading

azure-sdk-for-python-track2 - Release

openapi-sdkautomation bot commented Jul 21, 2020 • edited Loading

azure-sdk-for-net - Release

openapi-sdkautomation bot commented Jul 21, 2020 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Jul 21, 2020 • edited Loading

Azure CLI Extension Generation - Release

vnvaditya commented Jul 21, 2020

azuresdkci commented Jul 21, 2020

pilor commented Jul 22, 2020

vnvaditya commented Jul 21, 2020 •

edited

Loading

openapi-pipeline-app bot commented Jul 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 21, 2020 •

edited

Loading