Adding SystemData property to Microsoft.AzureData #10202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Staging] Swagger Validation Report
️✔️ |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python - Release
|
azure-sdk-for-net - Release
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
|
Can one of the admins verify this patch? |
Fixed systemData.
|
Azure Pipelines successfully started running 1 pipeline(s). |
Fixed identitytype case.
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Comment on lines
2293
to
2298
| "description": "The data controller properties.", | ||
| "type": "object", | ||
| "properties": { | ||
| "dataController": { | ||
| "$ref": "#/definitions/DataController" | ||
| "onPremiseProperty": { | ||
| "$ref": "#/definitions/OnPremiseProperty" | ||
| }, |
There was a problem hiding this comment.
Is this change relevant with this change on adding of systemData? If not, I suggest to revert this and maybe open another PR specified with replacing this attribute
There was a problem hiding this comment.
Hi @ArcturusZhang , this is not relevant to adding systemData. I removed this from this PR and will send out a different one for it, as you suggested.
There was a problem hiding this comment.
And a heads-up that that change would cause breaking changes warnings
|
Azure Pipelines successfully started running 1 pipeline(s). |
ArcturusZhang
approved these changes
Jul 22, 2020
00Kai0
pushed a commit
to 00Kai0/azure-rest-api-specs
that referenced
this pull request
Oct 12, 2020
* WIP: Updating Microsoft.AzureData * Minor changes * Adding new SystemData property to examples * Fixed formatting * Update azuredata.json Fixed systemData. * Update azuredata.json Fixed identitytype case. * Fixed formatting * Removing changes from this PR (suggested by ARM). Will send a different PR to rename properties.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.