[Hub Generated] Review request for Microsoft.AzureStackHCI to add version preview/2020-03-01-preview #10115

mbialecka · 2020-07-13T21:23:39Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Contribution checklist:

I have reviewed the documentation for AME onboarding.
Validation tools have been run on swagger spec(s) updated and errors have all been fixed with this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.

adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Please follow the link to find more details on PR review process.

openapi-pipeline-app · 2020-07-13T21:23:44Z

[Staging] Swagger Validation Report

️️✔️BreakingChange [Detail]

 There are no breaking changes.

️️✔️LintDiff [Detail]

 Validation passes for LintDiff.

️❌Avocado: 1 Errors, 0 Warnings [Detail] [Expand]

Rule	Message
`❌` INCONSISTENT_API_VERSION	The API version of the swagger is inconsistent with its file path. readme: specification/azurestackhci/resource-manager/readme.md json: common-types/resource-management/v2/types.json

_{Posted by Swagger Pipeline | How to fix these errors?}

azure-pipelines · 2020-07-13T21:23:56Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-07-13T21:25:26Z

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from e640f74 with merge commit b8a63f5. SDK Automation 13.0.17.20200619.4

Failed to find any changed packages. Please check the changed file list.
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azurestackhci/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azurestackhci/_azure_stack_hci_client.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azurestackhci/_configuration.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azurestackhci/models/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azurestackhci/models/_azure_stack_hci_client_enums.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azurestackhci/models/_models.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azurestackhci/models/_models_py3.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azurestackhci/models/_paged_models.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azurestackhci/operations/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azurestackhci/operations/_clusters_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azurestackhci/operations/_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azurestackhci/version.py

openapi-sdkautomation · 2020-07-13T21:25:28Z

azure-sdk-for-js - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from e640f74 with merge commit b8a63f5. SDK Automation 13.0.17.20200619.4
```
Failed to find any diff after autorest so no changed packages was found.
```

openapi-sdkautomation · 2020-07-13T21:25:30Z

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-07-13T21:25:30Z

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from e640f74 with merge commit b8a63f5. SDK Automation 13.0.17.20200619.4
```
Failed to find any diff after autorest so no changed packages was found.
```

openapi-sdkautomation · 2020-07-13T21:25:32Z

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from e640f74 with merge commit b8a63f5. SDK Automation 13.0.17.20200619.4
️✔️preview/azurestackhci/mgmt/2020-03-01-preview [View full logs] [Release SDK Changes]
- preview.azurestackhci.mgmt.2020-03-01-preview.zip

openapi-sdkautomation · 2020-07-13T21:25:33Z

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-07-13T21:25:34Z

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

mbialecka · 2020-07-13T21:27:57Z

The previous spec version was approved in the private repo:
https://github.com/Azure/azure-rest-api-specs-pr/pull/1102
https://github.com/Azure/azure-rest-api-specs-pr/pull/1206

Changes introduced in this PR:

New values for status enum
Updated examples

azuresdkci · 2020-07-13T21:45:58Z

Can one of the admins verify this patch?

mbialecka · 2020-07-14T17:26:43Z

@xccc-msft Is there anything I need to do to move the process to completion?

chiragg4u · 2020-07-14T20:40:45Z

Please go through the contribution checklist added as part of the review and mark them completed to confirm that you’ve gone through the required documentation.

azure-pipelines · 2020-07-14T22:12:00Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-07-14T22:13:41Z

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

azure-pipelines · 2020-07-14T22:48:51Z

Azure Pipelines successfully started running 1 pipeline(s).

mbialecka · 2020-07-14T23:07:13Z

@xccc-msft Please help with resolving linter errors. I've requested suppression for "R3020 - PathResourceProviderNamePascalCase". I don't know what I am missing with "R4007 - DefaultErrorResponseSchema".

xseeseesee · 2020-07-15T02:47:52Z

@akning-ms @NullMDR Can you please advise how to resolve the errors? Thanks.

azure-pipelines · 2020-07-16T21:07:49Z

Azure Pipelines successfully started running 1 pipeline(s).

mbialecka · 2020-07-16T23:31:50Z

@xccc-msft I fixed the linter errors but now avocado fails. Please advise how to proceed. I need to complete this as soon as possible.

xseeseesee · 2020-07-17T03:04:14Z

@mbialecka Any reason you removed the WaitForARMFeedback? It's required to wait for ARM review as you are adding new service/APIs.

akning-ms · 2020-07-17T03:09:26Z

@mbialecka, the avocado error can be ignore as it is common file. but just noticed the Python & JS & Java SDK generation fail which may what you need. you can see here: #10115 (comment)
@NullMDR to help to take a look

mbialecka · 2020-07-17T03:43:21Z

@xccc-msft I confirmed with ARM that a new review is not needed as it was completed in the private repo (I linked to the previous PRs in the private repo). Since avocado error can be ignored, can you merge in the PR?

…sion preview/2020-03-01-preview (Azure#10115) * New Readme Config File * New Go Language Readme Config File * New Typescript Language Readme Config File * New Python Language Readme Config File * New C# Language Readme Config File * New Ruby Language Readme Config File * New Swagger Spec File * New Swagger Example Spec File * Add AzureStackHCI spec * Prettify * Fix error schema * Fix error schema * Suppress R3020 * Fix R4006

openapi-assignment-bot bot assigned xseeseesee Jul 13, 2020

openapi-assignment-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 14, 2020

chiragg4u removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 14, 2020

openapi-assignment-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 14, 2020

mbialecka removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 14, 2020

openapi-assignment-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 14, 2020

mbialecka removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 14, 2020

mbialecka added 5 commits July 16, 2020 09:45

New Readme Config File

df2f8f5

New Go Language Readme Config File

0c42e99

New Typescript Language Readme Config File

270a3f4

New Python Language Readme Config File

0fed830

New C# Language Readme Config File

a39057b

mbialecka added 9 commits July 16, 2020 09:45

New Ruby Language Readme Config File

8ca777d

New Swagger Spec File

2aaf307

New Swagger Example Spec File

c79c66c

Add AzureStackHCI spec

7a27f61

Prettify

e9d9145

Fix error schema

e017336

Fix error schema

d7a9869

Suppress R3020

c4e4a68

Fix R4006

e640f74

mbialecka force-pushed the dev-azurestackhci-Microsoft.AzureStackHCI-2020-03-01-preview branch from 19e5253 to e640f74 Compare July 16, 2020 21:07

xseeseesee approved these changes Jul 17, 2020

View reviewed changes

xseeseesee merged commit b8a63f5 into Azure:master Jul 17, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.AzureStackHCI to add version preview/2020-03-01-preview #10115

[Hub Generated] Review request for Microsoft.AzureStackHCI to add version preview/2020-03-01-preview #10115

mbialecka commented Jul 13, 2020 •

edited

Loading

openapi-pipeline-app bot commented Jul 13, 2020 •

edited

Loading

azure-pipelines bot commented Jul 13, 2020

openapi-sdkautomation bot commented Jul 13, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 13, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 13, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 13, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 13, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 13, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 13, 2020 •

edited

Loading

mbialecka commented Jul 13, 2020

azuresdkci commented Jul 13, 2020

mbialecka commented Jul 14, 2020

chiragg4u commented Jul 14, 2020

azure-pipelines bot commented Jul 14, 2020

openapi-sdkautomation bot commented Jul 14, 2020 •

edited

Loading

azure-pipelines bot commented Jul 14, 2020

mbialecka commented Jul 14, 2020

xseeseesee commented Jul 15, 2020

azure-pipelines bot commented Jul 16, 2020

mbialecka commented Jul 16, 2020 •

edited

Loading

xseeseesee commented Jul 17, 2020

akning-ms commented Jul 17, 2020

mbialecka commented Jul 17, 2020

[Hub Generated] Review request for Microsoft.AzureStackHCI to add version preview/2020-03-01-preview #10115

[Hub Generated] Review request for Microsoft.AzureStackHCI to add version preview/2020-03-01-preview #10115

Conversation

mbialecka commented Jul 13, 2020 • edited Loading

Contribution checklist:

ARM API Review Checklist

openapi-pipeline-app bot commented Jul 13, 2020 • edited Loading

[Staging] Swagger Validation Report

azure-pipelines bot commented Jul 13, 2020

openapi-sdkautomation bot commented Jul 13, 2020 • edited Loading

azure-sdk-for-python - Release

openapi-sdkautomation bot commented Jul 13, 2020 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Jul 13, 2020 • edited Loading

azure-sdk-for-net - Release

openapi-sdkautomation bot commented Jul 13, 2020 • edited Loading

azure-sdk-for-java - Release

openapi-sdkautomation bot commented Jul 13, 2020 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Jul 13, 2020 • edited Loading

Azure CLI Extension Generation - Release

openapi-sdkautomation bot commented Jul 13, 2020 • edited Loading

Trenton Generation - Release

mbialecka commented Jul 13, 2020

azuresdkci commented Jul 13, 2020

mbialecka commented Jul 14, 2020

chiragg4u commented Jul 14, 2020

azure-pipelines bot commented Jul 14, 2020

openapi-sdkautomation bot commented Jul 14, 2020 • edited Loading

azure-sdk-for-python-track2 - Release

azure-pipelines bot commented Jul 14, 2020

mbialecka commented Jul 14, 2020

xseeseesee commented Jul 15, 2020

azure-pipelines bot commented Jul 16, 2020

mbialecka commented Jul 16, 2020 • edited Loading

xseeseesee commented Jul 17, 2020

akning-ms commented Jul 17, 2020

mbialecka commented Jul 17, 2020

mbialecka commented Jul 13, 2020 •

edited

Loading

openapi-pipeline-app bot commented Jul 13, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 13, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 13, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 13, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 13, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 13, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 13, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 13, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 14, 2020 •

edited

Loading

mbialecka commented Jul 16, 2020 •

edited

Loading