Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update breaking change process in PULL_REQUEST_TEMPLATE.md #10106

Merged
merged 2 commits into from
Jul 14, 2020
Merged

update breaking change process in PULL_REQUEST_TEMPLATE.md #10106

merged 2 commits into from
Jul 14, 2020

Conversation

zhenglaizhang
Copy link
Contributor

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
    • adding/removing APIs.
    • adding/removing properties.
    • adding/removing API-version.
    • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@zhenglaizhang zhenglaizhang requested a review from josefree July 13, 2020 04:23
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 13, 2020

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 13, 2020

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 13, 2020

azure-sdk-for-python - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 13, 2020

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@zhenglaizhang
Copy link
Contributor Author

/openapi pipeline

@openapi-sdkautomation
Copy link

/openapi pipeline

Unrecognized OpenAPI bot command (pipeline).
Try sdkautomation instead.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 13, 2020

[Staging] Swagger Validation Report

️✔️BreakingChange [Detail]
 There are no breaking changes. 
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 10106 in repo Azure/azure-rest-api-specs

1 similar comment
@azure-pipelines
Copy link

No commit pushedDate could be found for PR 10106 in repo Azure/azure-rest-api-specs

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 10106 in repo Azure/azure-rest-api-specs

@zhenglaizhang
Copy link
Contributor Author

/openapi pipeline

@openapi-sdkautomation
Copy link

/openapi pipeline

Unrecognized OpenAPI bot command (pipeline).
Try sdkautomation instead.

@PhoenixHe-NV
Copy link
Contributor

/azp run automation - sdk

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 10106 in repo Azure/azure-rest-api-specs

@zhenglaizhang
Copy link
Contributor Author

/azp run automation - sdk

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 14, 2020

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 14, 2020

azure-sdk-for-go - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 14, 2020

azure-sdk-for-js - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 14, 2020

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@PhoenixHe-NV PhoenixHe-NV merged commit 5e4f361 into Azure:master Jul 14, 2020
fullmetalcloud pushed a commit to fullmetalcloud/azure-rest-api-specs that referenced this pull request Jul 15, 2020
* update breaking change process in PULL_REQUEST_TEMPLATE.md

* update breaking change url
@zhenglaizhang zhenglaizhang deleted the improve-pr-template branch July 22, 2020 05:17
00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
* update breaking change process in PULL_REQUEST_TEMPLATE.md

* update breaking change url
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants