Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.TimeSeriesInsights to add version preview/2018-11-01-preview #10078

Merged

Conversation

richwyd
Copy link
Contributor

@richwyd richwyd commented Jul 9, 2020

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 9, 2020

[Staging] Swagger Validation Report

BreakingChange: 30 Errors, 0 Warnings [Detail] [Expand] Only 10 items are listed, please refer to log for more details.
Rule Message
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.TimeSeriesInsights/preview/2018-11-01-preview/timeseriesinsights.json#L1945:9
Old: Microsoft.TimeSeriesInsights/preview/2018-11-01-preview/timeseriesinsights.json#L1951:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.TimeSeriesInsights/preview/2018-11-01-preview/timeseriesinsights.json#L1670:9
Old: Microsoft.TimeSeriesInsights/preview/2018-11-01-preview/timeseriesinsights.json#L1672:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.TimeSeriesInsights/preview/2018-11-01-preview/timeseriesinsights.json#L1991:9
Old: Microsoft.TimeSeriesInsights/preview/2018-11-01-preview/timeseriesinsights.json#L1998:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.TimeSeriesInsights/preview/2018-11-01-preview/timeseriesinsights.json#L1513:9
Old: Microsoft.TimeSeriesInsights/preview/2018-11-01-preview/timeseriesinsights.json#L1513:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.TimeSeriesInsights/preview/2018-11-01-preview/timeseriesinsights.json#L1528:11
Old: Microsoft.TimeSeriesInsights/preview/2018-11-01-preview/timeseriesinsights.json#L1529:11
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.TimeSeriesInsights/preview/2018-11-01-preview/timeseriesinsights.json#L1513:9
Old: Microsoft.TimeSeriesInsights/preview/2018-11-01-preview/timeseriesinsights.json#L1513:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.TimeSeriesInsights/preview/2018-11-01-preview/timeseriesinsights.json#L1528:11
Old: Microsoft.TimeSeriesInsights/preview/2018-11-01-preview/timeseriesinsights.json#L1529:11
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.TimeSeriesInsights/preview/2018-11-01-preview/timeseriesinsights.json#L1513:9
Old: Microsoft.TimeSeriesInsights/preview/2018-11-01-preview/timeseriesinsights.json#L1513:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.TimeSeriesInsights/preview/2018-11-01-preview/timeseriesinsights.json#L1528:11
Old: Microsoft.TimeSeriesInsights/preview/2018-11-01-preview/timeseriesinsights.json#L1529:11
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.TimeSeriesInsights/preview/2018-11-01-preview/timeseriesinsights.json#L2209:9
Old: Microsoft.TimeSeriesInsights/preview/2018-11-01-preview/timeseriesinsights.json#L2217:9
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 9, 2020

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 9, 2020

azure-sdk-for-js - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 9, 2020

azure-sdk-for-python - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 9, 2020

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 9, 2020

azure-sdk-for-go - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 9, 2020

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 9, 2020

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 9, 2020

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@richwyd richwyd requested a review from yeskarthik July 9, 2020 17:59
@richwyd
Copy link
Contributor Author

richwyd commented Jul 9, 2020

This is a second new submission of a PR where we are trying out the new process via the portal. Our earlier submission used a more complicated process from our fork, which led to unnecessary commit history pollution.

The Breaking Changes have already been discussed with the API team, and agreed to. I can provide more details (email thread) if necessary.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@lmazuel lmazuel merged commit b3446f6 into Azure:master Jul 10, 2020
@richwyd richwyd deleted the dev-timeseriesinsights-richwyd-guid-to-string branch July 10, 2020 20:08
00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants