Add subscriptionId field to AzureResource model #10042

ityankel · 2020-07-06T14:31:54Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
- adding/removing APIs.
- adding/removing properties.
- adding/removing API-version.
- adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

openapi-pipeline-app · 2020-07-06T14:31:58Z

[Staging] Swagger Validation Report

️️✔️BreakingChange [Detail]

 There are no breaking changes.

️️✔️LintDiff [Detail]

 Validation passes for LintDiff.

️️✔️Avocado [Detail]

 Validation passes for Avocado.

_{Posted by Swagger Pipeline | How to fix these errors?}

azure-pipelines · 2020-07-06T14:32:12Z

Azure Pipelines successfully started running 1 pipeline(s).

azuresdkci · 2020-07-06T14:33:36Z

Can one of the admins verify this patch?

openapi-sdkautomation · 2020-07-06T14:33:44Z

azure-sdk-for-js - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 02ba83e with merge commit 58eea31. SDK Automation 13.0.17.20200619.4
```
Failed to find any diff after autorest so no changed packages was found.
```

openapi-sdkautomation · 2020-07-06T14:33:44Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 02ba83e with merge commit 58eea31. SDK Automation 13.0.17.20200619.4

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.SecurityInsights [View full logs] [Release SDK Changes]
No Artifact Generated.

openapi-sdkautomation · 2020-07-06T14:33:45Z

Azure CLI Extension Generation - Release

Installation instruction for service securityinsight [Preview Changes]
az extension add --source=https://sdkautomation.blob.core.windows.net/sdkautomation-pipeline/Azure/azure-rest-api-specs/10042/azure-cli-extensions/Azure/azure-cli-extensions/securityinsight/sentinel-0.1.0-py3-none-any.whl

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 02ba83e with merge commit 58eea31. Azure CLI Automation 13.0.17.20200619.4

[AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'AwsCloudTrailDataConnectorDataTypes-logs' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
[AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'OfficeDataConnectorDataTypes-exchange' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
[AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'OfficeDataConnectorDataTypes-sharePoint' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
[AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'TIDataConnectorDataTypes-indicators' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ActionsList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'AlertRuleTemplatesList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'AlertRulesList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'BookmarkList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'CloudError' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'DataConnectorList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'IncidentCommentList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'IncidentList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'OfficeConsentList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Operation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'OperationsList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceWithEtag' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorAdditionalInfo' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/PropertyRedeclarationWarning): Schema 'MCASDataConnectorDataTypes' has a property 'alerts' that is already declared the parent schema 'AlertsDataTypeOfDataConnector' but isn't significantly different. The property has been removed from MCASDataConnectorDataTypes
[AutoRest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
[AutoRest] 
[AutoRest] NO TEST SCENARIO PROVIDED - DEFAULT WILL BE USED
[AutoRest] ADD FOLLOWING SECTION TO readme.cli.md FILE TO MODIFY IT
[AutoRest] --------------------------------------------------------
[AutoRest]   test-scenario:
[AutoRest]     - name: /Actions/get/Get all actions of alert rule.
[AutoRest]     - name: /AlertRuleTemplates/get/Get alert rule template by Id.
[AutoRest]     - name: /AlertRuleTemplates/get/Get all alert rule templates.
[AutoRest]     - name: /AlertRules/put/Creates or updates a Fusion alert rule.
[AutoRest]     - name: /AlertRules/put/Creates or updates a MicrosoftSecurityIncidentCreation rule.
[AutoRest]     - name: /AlertRules/put/Creates or updates a Scheduled alert rule.
[AutoRest]     - name: /AlertRules/put/Creates or updates an action of alert rule.
[AutoRest]     - name: /AlertRules/get/Get a Fusion alert rule.
[AutoRest]     - name: /AlertRules/get/Get a MicrosoftSecurityIncidentCreation rule.
[AutoRest]     - name: /AlertRules/get/Get a Scheduled alert rule.
[AutoRest]     - name: /AlertRules/get/Get all alert rules.
[AutoRest]     - name: /AlertRules/get/Get an action of alert rule.
[AutoRest]     - name: /Bookmarks/put/Creates or updates a bookmark.
[AutoRest]     - name: /Bookmarks/get/Get a bookmark.
[AutoRest]     - name: /Bookmarks/get/Get all bookmarks.
[AutoRest]     - name: /DataConnectors/put/Creates or updates an Office365 data connector.
[AutoRest]     - name: /DataConnectors/get/Get a ASC data connector.
[AutoRest]     - name: /DataConnectors/get/Get a MCAS data connector.
[AutoRest]     - name: /DataConnectors/get/Get a MDATP data connector
[AutoRest]     - name: /DataConnectors/get/Get a TI data connector.
[AutoRest]     - name: /DataConnectors/get/Get all data connectors.
[AutoRest]     - name: /DataConnectors/get/Get an AAD data connector.
[AutoRest]     - name: /DataConnectors/get/Get an AATP data connector.
[AutoRest]     - name: /DataConnectors/get/Get an AwsCloudTrail data connector.
[AutoRest]     - name: /DataConnectors/get/Get an Office365 data connector.
[AutoRest]     - name: /IncidentComments/put/Creates an incident comment.
[AutoRest]     - name: /IncidentComments/get/Get all incident comments.
[AutoRest]     - name: /IncidentComments/get/Get an incident comment.
[AutoRest]     - name: /Incidents/put/Creates or updates an incident.
[AutoRest]     - name: /Incidents/get/Get all incidents.
[AutoRest]     - name: /Incidents/get/Get an incident.
[AutoRest]     - name: /AlertRules/delete/Delete an alert rule.
[AutoRest]     - name: /AlertRules/delete/Delete an action of alert rule.
[AutoRest]     - name: /Bookmarks/delete/Delete a bookmark.
[AutoRest]     - name: /DataConnectors/delete/Delete an Office365 data connector.
[AutoRest]     - name: /Incidents/delete/Delete an incident.
[AutoRest] --------------------------------------------------------

️✔️securityinsight [View full logs] [Release Azure CLI Changes]
- sentinel-0.1.0-py3-none-any.whl
- sentinel-0.1.0.zip

openapi-sdkautomation · 2020-07-06T14:33:47Z

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 02ba83e with merge commit 58eea31. SDK Automation 13.0.17.20200619.4
```
[azure-mgmt-securityinsight][ChangeLog] WARNING: Failed to generate ChangeLog.
```

⚠️azure-mgmt-securityinsight [View full logs] [Release SDK Changes]

[build_conf] INFO:packaging_tools:Building template azure-mgmt-securityinsight
[build_conf] INFO:packaging_tools.conf:Build default conf for azure-mgmt-securityinsight
[build_conf] INFO:packaging_tools:Template done azure-mgmt-securityinsight
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
Not exact 2 reports found:
Not generating changelog.
[ChangeLog] WARNING: Failed to generate ChangeLog.

openapi-sdkautomation · 2020-07-06T14:33:47Z

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-07-06T14:33:48Z

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-07-06T14:37:17Z

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 02ba83e with merge commit 58eea31. SDK Automation 13.0.17.20200619.4
️✔️preview/securityinsight/mgmt/2019-01-01-preview [View full logs] [Release SDK Changes]
- preview.securityinsight.mgmt.2019-01-01-preview.zip
️✔️preview/securityinsight/mgmt/v1.0 [View full logs] [Release SDK Changes]
- preview.securityinsight.mgmt.v1.0.zip

xseeseesee · 2020-07-07T07:57:55Z

@ityankel Can you please check if you can do the fix and pass CIs? Thanks.

cc: @akning-ms

ityankel · 2020-07-07T08:01:47Z

@ityankel Can you please check if you can do the fix and pass CIs? Thanks.

cc: @akning-ms

@xccc-msft, I looked at the failed builds and they don't appear to be relevant to my changes as far as I can tell. The errors there are about missing permissions and about a property called 'alerts' which isn't part of the only definition I changed here

akning-ms · 2020-07-09T14:05:40Z

@nullMDR to help take a look

PhoenixHe-NV · 2020-07-09T14:32:18Z

@qiaozha @changlong-liu Could you please help to verify why do we have such autorest failure?

[AutoRest] FATAL: System.InvalidOperationException: Found incompatible property types Object, for property 'alerts' in schema inheritance chain
[AutoRest] FATAL: python/imodeler1 - FAILED

changlong-liu · 2020-07-10T05:08:14Z

hi @ityankel , could you try to rebase to latest master? something fixed 2 days ago

…pecs into updateAzureResource

azure-pipelines · 2020-07-10T10:05:59Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-07-10T10:10:54Z

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

ityankel · 2020-07-10T10:28:17Z

hi @ityankel , could you try to rebase to latest master? something fixed 2 days ago

Thanks @changlong-liu! I merged with master and now all the automated checks are passing except SDK Python that fails due to "Error in the pull function. The remote end hung up unexpectedly" which sounds like an issue with the check itself

changlong-liu · 2020-07-13T02:52:03Z

/azp run automation - sdk

azure-pipelines · 2020-07-13T02:52:12Z

Azure Pipelines successfully started running 1 pipeline(s).

changlong-liu · 2020-07-13T04:37:04Z

hi @ityankel, it seems to be a temporary error, a re-run fixed it.

* Add subscriptionId field to AzureResource entity * wip

ityankel added 2 commits July 6, 2020 17:23

Add subscriptionId field to AzureResource entity

b806dad

wip

df2c0e4

openapi-assignment-bot bot assigned xseeseesee Jul 6, 2020

ityankel marked this pull request as ready for review July 6, 2020 14:55

xseeseesee requested review from dosegal, t-haorga and liemilyg July 7, 2020 02:53

dosegal approved these changes Jul 7, 2020

View reviewed changes

liemilyg approved these changes Jul 7, 2020

View reviewed changes

Merge branch 'master' of https://github.com/ityankel/azure-rest-api-s…

02ba83e

…pecs into updateAzureResource

xseeseesee approved these changes Jul 13, 2020

View reviewed changes

xseeseesee merged commit 58eea31 into Azure:master Jul 13, 2020

00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020

Add subscriptionId field to AzureResource model (Azure#10042)

25f43b4

* Add subscriptionId field to AzureResource entity * wip

ityankel deleted the feature/ityankel/azureResource branch November 17, 2020 11:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add subscriptionId field to AzureResource model #10042

Add subscriptionId field to AzureResource model #10042

ityankel commented Jul 6, 2020 •

edited

Loading

openapi-pipeline-app bot commented Jul 6, 2020 •

edited

Loading

azure-pipelines bot commented Jul 6, 2020

azuresdkci commented Jul 6, 2020

openapi-sdkautomation bot commented Jul 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 6, 2020 •

edited

Loading

xseeseesee commented Jul 7, 2020

ityankel commented Jul 7, 2020

akning-ms commented Jul 9, 2020

PhoenixHe-NV commented Jul 9, 2020

changlong-liu commented Jul 10, 2020

azure-pipelines bot commented Jul 10, 2020

openapi-sdkautomation bot commented Jul 10, 2020 •

edited

Loading

ityankel commented Jul 10, 2020

changlong-liu commented Jul 13, 2020

azure-pipelines bot commented Jul 13, 2020

changlong-liu commented Jul 13, 2020

Add subscriptionId field to AzureResource model #10042

Add subscriptionId field to AzureResource model #10042

Conversation

ityankel commented Jul 6, 2020 • edited Loading

Contribution checklist:

ARM API Review Checklist

openapi-pipeline-app bot commented Jul 6, 2020 • edited Loading

[Staging] Swagger Validation Report

azure-pipelines bot commented Jul 6, 2020

azuresdkci commented Jul 6, 2020

openapi-sdkautomation bot commented Jul 6, 2020 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Jul 6, 2020 • edited Loading

azure-sdk-for-net - Release

openapi-sdkautomation bot commented Jul 6, 2020 • edited Loading

Azure CLI Extension Generation - Release

openapi-sdkautomation bot commented Jul 6, 2020 • edited Loading

azure-sdk-for-python - Release

openapi-sdkautomation bot commented Jul 6, 2020 • edited Loading

Trenton Generation - Release

openapi-sdkautomation bot commented Jul 6, 2020 • edited Loading

azure-sdk-for-java - Release

openapi-sdkautomation bot commented Jul 6, 2020 • edited Loading

azure-sdk-for-go - Release

xseeseesee commented Jul 7, 2020

ityankel commented Jul 7, 2020

akning-ms commented Jul 9, 2020

PhoenixHe-NV commented Jul 9, 2020

changlong-liu commented Jul 10, 2020

azure-pipelines bot commented Jul 10, 2020

openapi-sdkautomation bot commented Jul 10, 2020 • edited Loading

azure-sdk-for-python-track2 - Release

ityankel commented Jul 10, 2020

changlong-liu commented Jul 13, 2020

azure-pipelines bot commented Jul 13, 2020

changlong-liu commented Jul 13, 2020

ityankel commented Jul 6, 2020 •

edited

Loading

openapi-pipeline-app bot commented Jul 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 10, 2020 •

edited

Loading