Add odatatype for Url Signing Action #10017

gubalasu · 2020-07-02T03:12:26Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
- adding/removing APIs.
- adding/removing properties.
- adding/removing API-version.
- adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

AutorestCI · 2020-07-02T03:12:28Z

You don't have permission to trigger SDK Automation.
Please add yourself to Azure group from opensource portal if you are MSFT employee,
or please ask reviewer to add comment *** /openapibot sdkautomation ***.
Please ask [email protected] (or NullMDR in github) for additional help.

openapi-pipeline-app · 2020-07-02T03:12:30Z

[Staging] Swagger Validation Report

️️✔️BreakingChange [Detail]

 There are no breaking changes.

️️✔️LintDiff [Detail]

 Validation passes for LintDiff.

️️✔️Avocado [Detail]

 Validation passes for Avocado.

_{Posted by Swagger Pipeline | How to fix these errors?}

azuresdkci · 2020-07-02T03:14:42Z

Can one of the admins verify this patch?

ChenTanyi · 2020-07-02T04:41:20Z

/openapibot sdkautomation

azure-pipelines · 2020-07-02T04:41:36Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-07-02T04:41:36Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-07-02T04:41:36Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-07-02T04:41:36Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-07-02T04:43:06Z

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 131ce16 with merge commit f9c879b. SDK Automation 13.0.17.20200619.4
️✔️cdn/mgmt/2015-06-01 [View full logs] [Release SDK Changes]
- cdn.mgmt.2015-06-01.zip
️✔️cdn/mgmt/2016-04-02 [View full logs] [Release SDK Changes]
- cdn.mgmt.2016-04-02.zip
️✔️cdn/mgmt/2016-10-02 [View full logs] [Release SDK Changes]
- cdn.mgmt.2016-10-02.zip
️✔️cdn/mgmt/2017-04-02 [View full logs] [Release SDK Changes]
- cdn.mgmt.2017-04-02.zip
️✔️cdn/mgmt/2017-10-12 [View full logs] [Release SDK Changes]
- cdn.mgmt.2017-10-12.zip
️✔️cdn/mgmt/2019-04-15 [View full logs] [Release SDK Changes]
- cdn.mgmt.2019-04-15.zip
️✔️preview/cdn/mgmt/2020-04-15 [View full logs] [Release SDK Changes]
- preview.cdn.mgmt.2020-04-15.zip

openapi-sdkautomation · 2020-07-02T04:43:07Z

azure-sdk-for-java - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 131ce16 with merge commit f9c879b. SDK Automation 13.0.17.20200619.4
️✔️sdk/cdn/mgmt-v2020_04_15 [View full logs] [Release SDK Changes]

openapi-sdkautomation · 2020-07-02T04:43:07Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 131ce16 with merge commit f9c879b. SDK Automation 13.0.17.20200619.4

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.Cdn [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.Cdn.4.3.0-preview.nupkg
- Microsoft.Azure.Management.Cdn.4.3.0-preview.snupkg

openapi-sdkautomation · 2020-07-02T04:43:08Z

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-07-02T04:43:09Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 131ce16 with merge commit f9c879b. SDK Automation 13.0.17.20200619.4

️✔️@azure/arm-cdn [View full logs] [Release SDK Changes]

azure-arm-cdn-4.2.0.tgz

Only show 100 items here, please refer to log for details.

[npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
[npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
[npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/cdnManagementClient.js → ./dist/arm-cdn.js...
[npmPack] created ./dist/arm-cdn.js in 460ms
[npmPack] npm notice 
[npmPack] npm notice package: @azure/[email protected]
[npmPack] npm notice === Tarball Contents === 
[npmPack] npm notice 265.9kB dist/arm-cdn.js                                   
[npmPack] npm notice 97.8kB  dist/arm-cdn.min.js                               
[npmPack] npm notice 5.3kB   esm/cdnManagementClient.js                        
[npmPack] npm notice 3.0kB   esm/cdnManagementClientContext.js                 
[npmPack] npm notice 12.5kB  esm/operations/customDomains.js                   
[npmPack] npm notice 2.7kB   esm/models/customDomainsMappers.js                
[npmPack] npm notice 2.2kB   esm/operations/edgeNodes.js                       
[npmPack] npm notice 2.7kB   esm/models/edgeNodesMappers.js                    
[npmPack] npm notice 25.5kB  esm/operations/endpoints.js                       
[npmPack] npm notice 2.8kB   esm/models/endpointsMappers.js                    
[npmPack] npm notice 345B    esm/models/index.js                               
[npmPack] npm notice 633B    esm/operations/index.js                           
[npmPack] npm notice 2.4kB   esm/operations/managedRuleSets.js                 
[npmPack] npm notice 2.7kB   esm/models/managedRuleSetsMappers.js              
[npmPack] npm notice 106.5kB esm/models/mappers.js                             
[npmPack] npm notice 2.2kB   esm/operations/operations.js                      
[npmPack] npm notice 475B    esm/models/operationsMappers.js                   
[npmPack] npm notice 6.9kB   esm/operations/origins.js                         
[npmPack] npm notice 2.7kB   esm/models/originsMappers.js                      
[npmPack] npm notice 3.0kB   esm/models/parameters.js                          
[npmPack] npm notice 9.6kB   esm/operations/policies.js                        
[npmPack] npm notice 2.7kB   esm/models/policiesMappers.js                     
[npmPack] npm notice 15.7kB  esm/operations/profiles.js                        
[npmPack] npm notice 2.8kB   esm/models/profilesMappers.js                     
[npmPack] npm notice 2.5kB   esm/operations/resourceUsageOperations.js         
[npmPack] npm notice 477B    esm/models/resourceUsageOperationsMappers.js      
[npmPack] npm notice 971B    rollup.config.js                                  
[npmPack] npm notice 1.6kB   package.json                                      
[npmPack] npm notice 457B    tsconfig.json                                     
[npmPack] npm notice 470.7kB dist/arm-cdn.js.map                               
[npmPack] npm notice 67.7kB  dist/arm-cdn.min.js.map                           
[npmPack] npm notice 2.1kB   esm/cdnManagementClient.d.ts.map                  
[npmPack] npm notice 3.2kB   esm/cdnManagementClient.js.map                    
[npmPack] npm notice 599B    esm/cdnManagementClientContext.d.ts.map           
[npmPack] npm notice 1.6kB   esm/cdnManagementClientContext.js.map             
[npmPack] npm notice 3.8kB   esm/operations/customDomains.d.ts.map             
[npmPack] npm notice 6.1kB   esm/operations/customDomains.js.map               
[npmPack] npm notice 1.2kB   esm/models/customDomainsMappers.d.ts.map          
[npmPack] npm notice 1.2kB   esm/models/customDomainsMappers.js.map            
[npmPack] npm notice 1.0kB   esm/operations/edgeNodes.d.ts.map                 
[npmPack] npm notice 1.4kB   esm/operations/edgeNodes.js.map                   
[npmPack] npm notice 1.2kB   esm/models/edgeNodesMappers.d.ts.map              
[npmPack] npm notice 1.2kB   esm/models/edgeNodesMappers.js.map                
[npmPack] npm notice 5.7kB   esm/operations/endpoints.d.ts.map                 
[npmPack] npm notice 11.2kB  esm/operations/endpoints.js.map                   
[npmPack] npm notice 1.3kB   esm/models/endpointsMappers.d.ts.map              
[npmPack] npm notice 1.3kB   esm/models/endpointsMappers.js.map                
[npmPack] npm notice 33.5kB  esm/models/index.d.ts.map                         
[npmPack] npm notice 311B    esm/operations/index.d.ts.map                     
[npmPack] npm notice 126B    esm/models/index.js.map                           
[npmPack] npm notice 326B    esm/operations/index.js.map                       
[npmPack] npm notice 1.0kB   esm/operations/managedRuleSets.d.ts.map           
[npmPack] npm notice 1.5kB   esm/operations/managedRuleSets.js.map             
[npmPack] npm notice 1.2kB   esm/models/managedRuleSetsMappers.d.ts.map        
[npmPack] npm notice 1.2kB   esm/models/managedRuleSetsMappers.js.map          
[npmPack] npm notice 5.4kB   esm/models/mappers.d.ts.map                       
[npmPack] npm notice 57.7kB  esm/models/mappers.js.map                         
[npmPack] npm notice 1.0kB   esm/operations/operations.d.ts.map                
[npmPack] npm notice 1.4kB   esm/operations/operations.js.map                  
[npmPack] npm notice 225B    esm/models/operationsMappers.d.ts.map             
[npmPack] npm notice 238B    esm/models/operationsMappers.js.map               
[npmPack] npm notice 2.3kB   esm/operations/origins.d.ts.map                   
[npmPack] npm notice 3.4kB   esm/operations/origins.js.map                     
[npmPack] npm notice 1.2kB   esm/models/originsMappers.d.ts.map                
[npmPack] npm notice 1.2kB   esm/models/originsMappers.js.map                  
[npmPack] npm notice 684B    esm/models/parameters.d.ts.map                    
[npmPack] npm notice 2.2kB   esm/models/parameters.js.map                      
[npmPack] npm notice 2.6kB   esm/operations/policies.d.ts.map                  
[npmPack] npm notice 4.8kB   esm/operations/policies.js.map                    
[npmPack] npm notice 1.2kB   esm/models/policiesMappers.d.ts.map               
[npmPack] npm notice 1.2kB   esm/models/policiesMappers.js.map                 
[npmPack] npm notice 4.9kB   esm/operations/profiles.d.ts.map                  
[npmPack] npm notice 8.2kB   esm/operations/profiles.js.map                    
[npmPack] npm notice 1.2kB   esm/models/profilesMappers.d.ts.map               
[npmPack] npm notice 1.3kB   esm/models/profilesMappers.js.map                 
[npmPack] npm notice 1.1kB   esm/operations/resourceUsageOperations.d.ts.map   
[npmPack] npm notice 1.5kB   esm/operations/resourceUsageOperations.js.map     
[npmPack] npm notice 238B    esm/models/resourceUsageOperationsMappers.d.ts.map
[npmPack] npm notice 251B    esm/models/resourceUsageOperationsMappers.js.map  
[npmPack] npm notice 3.1kB   README.md                                         
[npmPack] npm notice 4.6kB   esm/cdnManagementClient.d.ts                      
[npmPack] npm notice 8.7kB   src/cdnManagementClient.ts                        
[npmPack] npm notice 1.1kB   esm/cdnManagementClientContext.d.ts               
[npmPack] npm notice 2.8kB   src/cdnManagementClientContext.ts                 
[npmPack] npm notice 12.4kB  esm/operations/customDomains.d.ts                 
[npmPack] npm notice 21.4kB  src/operations/customDomains.ts                   
[npmPack] npm notice 2.4kB   esm/models/customDomainsMappers.d.ts

openapi-sdkautomation · 2020-07-02T04:43:10Z

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-07-02T04:43:11Z

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 131ce16 with merge commit f9c879b. SDK Automation 13.0.17.20200619.4

️✔️azure-mgmt-cdn [View full logs] [Release SDK Changes]

[build_conf] INFO:packaging_tools:Building template azure-mgmt-cdn
[build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
[build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
[build_conf] INFO:packaging_tools:Template done azure-mgmt-cdn
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[ChangeLog] Size of delta 0.097% size of original (original: 65084 chars, delta: 63 chars)
[ChangeLog]

openapi-sdkautomation · 2020-07-02T04:43:12Z

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

ChenTanyi · 2020-07-02T05:43:09Z

@gubalasu is this property readonly?

gubalasu · 2020-07-03T00:18:24Z

@gubalasu is this property readonly?

This is a property that the customers have to supply when they are making this call. And the value of the property is the one mentioned in the enum. I am not very sure what you meant by readonly. But I hope this answers your question

ChenTanyi · 2020-07-03T02:24:31Z

@gubalasu readonly means the property could only be return by service, and could not change by the client side.

Since there is only one possible value for the enum, (And could not add new enum value due to it is not modelAsString) I think it is no need for the sending by client side.

gubalasu · 2020-07-07T01:10:22Z

@gubalasu readonly means the property could only be return by service, and could not change by the client side.

Since there is only one possible value for the enum, (And could not add new enum value due to it is not modelAsString) I think it is no need for the sending by client side.

We are checking for the odatatype in the Resource Provider. We do this because the action can have multiple different types. One such type is UrlSigning. For other action types we have different odatatype and they are defined seperately. So this field is a required field.

* Add odatatype for Url Signing Action * Fix typo

gubalasu added 2 commits July 1, 2020 20:09

Add odatatype for Url Signing Action

a75f9d9

Fix typo

131ce16

openapi-assignment-bot bot assigned ChenTanyi Jul 2, 2020

openapi-sdkautomation bot mentioned this pull request Jul 2, 2020

[AutoPR sdk/cdn/mgmt-v2020_04_15] Add odatatype for Url Signing Action AzureSDKAutomation/azure-sdk-for-java#3390

Closed

gubalasu closed this Jul 3, 2020

gubalasu reopened this Jul 3, 2020

ChenTanyi approved these changes Jul 7, 2020

View reviewed changes

ChenTanyi merged commit f9c879b into Azure:master Jul 7, 2020

00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020

Add odatatype for Url Signing Action (Azure#10017)

bb5c3fe

* Add odatatype for Url Signing Action * Fix typo

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add odatatype for Url Signing Action #10017

Add odatatype for Url Signing Action #10017

gubalasu commented Jul 2, 2020 •

edited

Loading

AutorestCI commented Jul 2, 2020

openapi-pipeline-app bot commented Jul 2, 2020 •

edited

Loading

azuresdkci commented Jul 2, 2020

ChenTanyi commented Jul 2, 2020

azure-pipelines bot commented Jul 2, 2020

azure-pipelines bot commented Jul 2, 2020

azure-pipelines bot commented Jul 2, 2020

azure-pipelines bot commented Jul 2, 2020

openapi-sdkautomation bot commented Jul 2, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 2, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 2, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 2, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 2, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 2, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 2, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 2, 2020 •

edited

Loading

ChenTanyi commented Jul 2, 2020

gubalasu commented Jul 3, 2020

ChenTanyi commented Jul 3, 2020

gubalasu commented Jul 7, 2020

Add odatatype for Url Signing Action #10017

Add odatatype for Url Signing Action #10017

Conversation

gubalasu commented Jul 2, 2020 • edited Loading

Contribution checklist:

ARM API Review Checklist

AutorestCI commented Jul 2, 2020

openapi-pipeline-app bot commented Jul 2, 2020 • edited Loading

[Staging] Swagger Validation Report

azuresdkci commented Jul 2, 2020

ChenTanyi commented Jul 2, 2020

azure-pipelines bot commented Jul 2, 2020

azure-pipelines bot commented Jul 2, 2020

azure-pipelines bot commented Jul 2, 2020

azure-pipelines bot commented Jul 2, 2020

openapi-sdkautomation bot commented Jul 2, 2020 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Jul 2, 2020 • edited Loading

azure-sdk-for-java - Release

openapi-sdkautomation bot commented Jul 2, 2020 • edited Loading

azure-sdk-for-net - Release

openapi-sdkautomation bot commented Jul 2, 2020 • edited Loading

Trenton Generation - Release

openapi-sdkautomation bot commented Jul 2, 2020 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Jul 2, 2020 • edited Loading

Azure CLI Extension Generation - Release

openapi-sdkautomation bot commented Jul 2, 2020 • edited Loading

azure-sdk-for-python - Release

openapi-sdkautomation bot commented Jul 2, 2020 • edited Loading

azure-sdk-for-python-track2 - Release

ChenTanyi commented Jul 2, 2020

gubalasu commented Jul 3, 2020

ChenTanyi commented Jul 3, 2020

gubalasu commented Jul 7, 2020

gubalasu commented Jul 2, 2020 •

edited

Loading

openapi-pipeline-app bot commented Jul 2, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 2, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 2, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 2, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 2, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 2, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 2, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 2, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 2, 2020 •

edited

Loading