IoT Central API user changes #10014
Merged
IoT Central API user changes #10014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-go - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-java - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
lmasieri
approved these changes
Jul 2, 2020
|
Can one of the admins verify this patch? |
jhendrixMSFT
requested changes
Jul 2, 2020
| "email": { | ||
| "description": "Email address of the user.", | ||
| "type": "string", | ||
| "format": "email" |
There was a problem hiding this comment.
This is not a valid OpenAPI format and is the cause of the linter failure, can you please remove it.
There was a problem hiding this comment.
@jhendrixMSFT this should work in theory
https://swagger.io/docs/specification/data-models/data-types/
However, format is an open value, so you can use any formats, even not those defined by the OpenAPI Specification, such as:
- uuid
- uri
- hostname
- ipv4
- ipv6
and others
Tools can use the format to validate the input or to map the value to a specific type in the chosen programming language. Tools that do not support a specific format may default back to the type alone, as if the format is not specified.
But I agree in practice the linter will not like it, and since it's ignored by autorest anyway, better to remove it
There was a problem hiding this comment.
I missed the part about format being open-ended, thanks for the correction.
| { | ||
| "$ref": "#/parameters/Subdomain" | ||
| } | ||
| { "$ref": "#/parameters/CentralDnsSuffixInPath" }, |
There was a problem hiding this comment.
The formatting of this doc is wrong, please see https://aka.ms/AA6h31t on how to fix.
...on/iotcentral/data-plane/Microsoft.IoTCentral/preview/2019-10-28-preview/iotcentralapps.json
Outdated
Show resolved
Hide resolved
|
Also please fix the spell check failure. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
I fixed the spellcheck issue. |
|
@jhendrixMSFT any other feedback? |
|
@viv-liu yes the |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jhendrixMSFT
approved these changes
Jul 7, 2020
00Kai0
pushed a commit
to 00Kai0/azure-rest-api-specs
that referenced
this pull request
Oct 12, 2020
* user changes * Ran prettier * Spell check fix * Removed format email
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.