Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schema for Storage.LifecyclePolicyCompleted event #10001

Merged
merged 3 commits into from
Jul 15, 2020
Merged

Schema for Storage.LifecyclePolicyCompleted event #10001

merged 3 commits into from
Jul 15, 2020

Conversation

xioyi
Copy link
Contributor

@xioyi xioyi commented Jul 1, 2020 •
edited
Loading

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
    • adding/removing APIs.
    • adding/removing properties.
    • adding/removing API-version.
    • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@xioyi xioyi requested review from ahamad-MS and Kishp01 as code owners July 1, 2020 05:26
@AutorestCI
Copy link

You don't have permission to trigger SDK Automation.
Please add yourself to Azure group from opensource portal if you are MSFT employee,
or please ask reviewer to add comment *** /openapibot sdkautomation ***.
Please ask [email protected] (or NullMDR in github) for additional help.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 1, 2020 •
edited
Loading

[Staging] Swagger Validation Report

️️✔️BreakingChange [Detail] 
 There are no breaking changes.
️️✔️LintDiff [Detail] 
 Validation passes for LintDiff.
️️✔️Avocado [Detail] 
 Validation passes for Avocado.
Posted by Swagger Pipeline | How to fix these errors?

@ghost
Copy link

ghost commented Jul 1, 2020 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

ahamad-MS
ahamad-MS suggested changes Jul 8, 2020
View reviewed changes
Copy link
Contributor

@ahamad-MS ahamad-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using more explicit property name. For example, "successCount"

specification/eventgrid/data-plane/Microsoft.Storage/stable/2018-01-01/Storage.json Outdated Show resolved Hide resolved
specification/eventgrid/data-plane/Microsoft.Storage/stable/2018-01-01/Storage.json Outdated Show resolved Hide resolved
specification/eventgrid/data-plane/Microsoft.Storage/stable/2018-01-01/Storage.json Outdated Show resolved Hide resolved
@xioyi xioyi requested review from ahamad-MS and Kishp01 July 14, 2020 05:17
ahamad-MS
ahamad-MS approved these changes Jul 15, 2020
View reviewed changes
Copy link
Contributor

@ahamad-MS ahamad-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lmazuel lmazuel merged commit a778a66 into Azure:master Jul 15, 2020
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 15, 2020 •
edited
Loading

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 15, 2020 •
edited
Loading

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 15, 2020 •
edited
Loading

azure-sdk-for-js - Release

❌ failed [Logs] [Expand Details]
  • ❌ Generate from 67b6fea with merge commit a778a66. SDK Automation 13.0.17.20200619.4
  • ❌@azure/eventgrid [View full logs]  [Release SDK Changes] 
      [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
[npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
[npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
[npmPack] npm ERR! code ELIFECYCLE
[npmPack] npm ERR! errno 2
[npmPack] npm ERR! @azure/[email protected] build: `tsc && rollup -c rollup.config.js && npm run minify`
[npmPack] npm ERR! Exit status 2
[npmPack] npm ERR! 
[npmPack] npm ERR! Failed at the @azure/[email protected] build script.
[npmPack] npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
[npmPack] 
[npmPack] npm ERR! A complete log of this run can be found in:
[npmPack] npm ERR!     /home/sdk/.npm/_logs/2020-07-15T23_31_59_640Z-debug.log
[npmPack] npm ERR! code ELIFECYCLE
[npmPack] npm ERR! errno 2
[npmPack] npm ERR! @azure/[email protected] prepack: `npm install && npm run build`
[npmPack] npm ERR! Exit status 2
[npmPack] npm ERR! 
[npmPack] npm ERR! Failed at the @azure/[email protected] prepack script.
[npmPack] npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
[npmPack] 
[npmPack] npm ERR! A complete log of this run can be found in:
[npmPack] npm ERR!     /home/sdk/.npm/_logs/2020-07-15T23_31_59_653Z-debug.log
Failed to create the package @azure/eventgrid.
Error: npm pack npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
npm notice created a lockfile as package-lock.json. You should commit this file.
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! @azure/[email protected] build: `tsc && rollup -c rollup.config.js && npm run minify`
npm ERR! Exit status 2
npm ERR! 
npm ERR! Failed at the @azure/[email protected] build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

      npm ERR! A complete log of this run can be found in:
      
npm ERR!     /home/sdk/.npm/_logs/2020-07-15T23_31_59_640Z-debug.log
      
npm ERR! code ELIFECYCLE
      
npm ERR! errno 2
      
npm ERR! @azure/[email protected] prepack: npm install && npm run build
      
npm ERR! Exit status 2
      
npm ERR!
      
npm ERR! Failed at the @azure/[email protected] prepack script.
      
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
      

      npm ERR! A complete log of this run can be found in:
      
npm ERR!     /home/sdk/.npm/_logs/2020-07-15T23_31_59_653Z-debug.log
      
, {}

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jul 15, 2020 •
    edited
    Loading

    azure-sdk-for-net - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jul 15, 2020 •
    edited
    Loading

    azure-sdk-for-java - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jul 15, 2020 •
    edited
    Loading

    azure-sdk-for-python - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from 67b6fea with merge commit a778a66. SDK Automation 13.0.17.20200619.4
    • ️✔️azure-eventgrid [View full logs]  [Release SDK Changes] 
      [build_conf] INFO:packaging_tools:Building template azure-eventgrid
[build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
[build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
[build_conf] INFO:packaging_tools:Template done azure-eventgrid
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[ChangeLog] Traceback (most recent call last):
[ChangeLog]   File "/usr/lib/python3.6/runpy.py", line 193, in _run_module_as_main
[ChangeLog]     "__main__", mod_spec)
[ChangeLog]   File "/usr/lib/python3.6/runpy.py", line 85, in _run_code
[ChangeLog]     exec(code, run_globals)
[ChangeLog]   File "/z/work/azure-sdk-for-python/tools/azure-sdk-tools/packaging_tools/change_log.py", line 200, in 
[ChangeLog]     change_log = build_change_log(old_report, new_report)
[ChangeLog]   File "/z/work/azure-sdk-for-python/tools/azure-sdk-tools/packaging_tools/change_log.py", line 147, in build_change_log
[ChangeLog]     change_log.operation(diff_line)
[ChangeLog]   File "/z/work/azure-sdk-for-python/tools/azure-sdk-tools/packaging_tools/change_log.py", line 38, in operation
[ChangeLog]     _, operation_name, *remaining_path = path
[ChangeLog] ValueError: not enough values to unpack (expected at least 2, got 1)
[ChangeLog] Size of delta 38.752% size of original (original: 81291 chars, delta: 31502 chars)

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jul 15, 2020 •
    edited
    Loading

    Trenton Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jul 15, 2020 •
    edited
    Loading

    azure-sdk-for-python-track2 - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
    @xioyi @00Kai0
    Schema for Storage.LifecyclePolicyCompleted event (Azure#10001)
    64d25ea 
    * Schema for Storage.LifecyclePolicyCompleted event

* Update Storage.json

* Update Storage.json
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @ahamad-MS ahamad-MS ahamad-MS approved these changes

    @lmazuel lmazuel lmazuel approved these changes

    @Kishp01 Kishp01 Awaiting requested review from Kishp01 Kishp01 is a code owner

    Assignees

    @lmazuel lmazuel

    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    6 participants
    @xioyi @AutorestCI @azuresdkci @lmazuel @ahamad-MS @Kishp01