Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Validation for ResourceNameRestriction #23737

Closed
solankisamir opened this issue Apr 26, 2023 · 4 comments
Closed

Incorrect Validation for ResourceNameRestriction #23737

solankisamir opened this issue Apr 26, 2023 · 4 comments

Comments

@solankisamir
Copy link
Member

https://github.com/Azure/azure-rest-api-specs/pull/22978/checks?check_run_id=13024521883

The resource name parameter 'notificationName' should be defined with a 'pattern' restriction.
Location: Microsoft.ApiManagement/preview/2022-09-01-preview/apimworkspaces.json#L1828

The parameter already has restriction as defined here

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Apr 26, 2023
@solankisamir
Copy link
Member Author

Same issue for
https://github.com/Azure/azure-rest-api-specs/pull/22978/checks?check_run_id=13024521967

The resource name parameter 'accessName' should be defined with a 'pattern' restriction.
Location: Microsoft.ApiManagement/preview/2022-09-01-preview/apimtenant.json#L354

@JackTn JackTn added API Management Service Attention Workflow: This issue is responsible by Azure service team. labels Apr 27, 2023
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Apr 27, 2023
@ghost
Copy link

ghost commented Apr 27, 2023

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @adrianhall, @KedarJoshi.

Issue Details

https://github.com/Azure/azure-rest-api-specs/pull/22978/checks?check_run_id=13024521883

The resource name parameter 'notificationName' should be defined with a 'pattern' restriction.
Location: Microsoft.ApiManagement/preview/2022-09-01-preview/apimworkspaces.json#L1828

The parameter already has restriction as defined here

Author: solankisamir
Assignees: -
Labels:

API Management, Service Attention, needs-triage

Milestone: -

@solankisamir
Copy link
Member Author

solankisamir commented May 4, 2023

@JackTn @weidongxu-microsoft this is an issue in the tooling itself.

@JackTn
Copy link
Member

JackTn commented May 5, 2023

@solankisamir My fault. I create a new issue Azure/azure-openapi-validator#501 on https://github.com/Azure/azure-openapi-validator#azure-openapi-validator repo. You can follow that one and i close this one. Thanks !

@JackTn JackTn closed this as completed May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants