Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ResourceNameRestriction] Should enums (without "pattern") be treated as valid or invalid? #501

Open
JackTn opened this issue May 5, 2023 · 3 comments

Comments

@JackTn
Copy link
Member

JackTn commented May 5, 2023

Describe the bug
https://github.com/Azure/azure-rest-api-specs/pull/22978/checks?check_run_id=13024521883

The resource name parameter 'notificationName' should be defined with a 'pattern' restriction.
Location: Microsoft.ApiManagement/preview/2022-09-01-preview/apimworkspaces.json#L1828

The parameter already has restriction as defined here

https://github.com/Azure/azure-rest-api-specs/blob/e6e61df03b325344f43cdfe756c44ed58d94e409/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2022-09-01-preview/apimanagement.json#L467

To Reproduce
Steps to reproduce the behavior:

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Additional context
Details in Azure/azure-rest-api-specs#23737

@JackTn
Copy link
Member Author

JackTn commented May 5, 2023

@solankisamir Follow this ~

@mikeharder
Copy link
Member

mikeharder commented Jun 17, 2024

@mikeharder
Copy link
Member

Adding unit test to determine if this is a bug or by design: #714

@mikeharder mikeharder changed the title Incorrect Validation for ResourceNameRestriction [ResourceNameRestriction] Should enums (without "pattern") be treated as valid or invalid Jun 17, 2024
@mikeharder mikeharder changed the title [ResourceNameRestriction] Should enums (without "pattern") be treated as valid or invalid [ResourceNameRestriction] Should enums (without "pattern") be treated as valid or invalid? Jun 17, 2024
@mikeharder mikeharder assigned mikeharder and unassigned mikeharder Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants