Various Search model properties need to be authored as x-nullable: true

[heaths]

We're finding in the Azure Cognitive Search SDK for .NET that quite a few model properties need to be authored as x-nullable because the service implementation may return them as null.

See https://github.com/Azure/azure-sdk-for-net/blob/80ff0d075221715e3eb8e8645eac2cef203e7c8f/sdk/search/Azure.Search.Documents/src/autorest.md#add-nullable-annotations for a current list. Should we add more, we can open a new issue with the difference. If possible, it would be great if the service team could validate the swagger authoring against the service implementation.

This should be fixed in 2020-06-30 and any current preview being updated.

• SynonymMap
  • encryptionKey
• SearchField
  • indexAnalyzer
  • searchAnalyzer
  • analyzer
• ScoringProfile
  • text
• SearchIndex
  • encryptionKey
  • corsOptions
• BM25Similarity
  • k1
  • b
• SearchIndexerDataSource
  • dataChangeDetectionPolicy
  • dataDeletionDetectionPolicy
• SearchIndexer
  • disabled
  • schedule
  • parameters
• TextTranslationSkill
  • suggestedFrom
• IndexingParameters
  • batchSize
  • maxFailedItems
  • maxFailedItemsPerBatch
• FieldMapping
  • mappingFunction
• IndexerExecutionResult
  • endTime

[ghost]

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @brjohnstmsft, @bleroy, @tjacobhi, @MarkHeff, @miwelsh.

[brjohnstmsft]

Thanks for reporting this @heaths. If I had to guess how we got into this state, it might be because we incorrectly assumed that x-nullable is true by default (or at least, treated that way for .NET reference types in C# codegen).

I'll fix all the core Search instances of this. @bleroy, can you please fix the indexer- and skillset-related instances?

[bleroy]

@brjohnstmsft Sure.

[heaths]

This isn't complete. When referencing in commits, make sure a word separates keywords like "fixed", "resolves", etc. until complete so it doesn't get auto-closed.