[Hub Generated] Review request for Microsoft.Notebooks to add version…

… preview/2019-10-11-preview (#15614) * Paul's changes plus a few from Geoffrey * Just remove error level * change cloud error * changed cloud error again * remove error * remove cloud error details and add optional param * remove resource returns nothing instead * change enums to string * revert clouderror * fix operations * fix * fix * fix * fix formatting * try adding top level * try deprecated Co-authored-by: Geoffrey Troyer <[email protected]> Co-authored-by: Paul Wang <[email protected]>
Azure · Aug 12, 2021 · fb0ba41 · fb0ba41
1 parent a100f52
commit fb0ba41
Show file tree

Hide file tree

Showing 2 changed files with 72 additions and 16 deletions.
diff --git a/...rce-manager/Microsoft.Notebooks/preview/2019-10-11-preview/examples/NBResourceDelete.json b/...rce-manager/Microsoft.Notebooks/preview/2019-10-11-preview/examples/NBResourceDelete.json
@@ -10,17 +10,7 @@
     }
   },
   "responses": {
-    "200": {
-      "body": {
-        "id": "subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/testRP/providers/Microsoft.Notebooks/NotebookProxies/testResource",
-        "name": "testResource",
-        "type": "Microsoft.Notebooks/NotebookProxies",
-        "properties": {
-          "resourceId": "acc07b62291e4a4a800f71ff252e0654",
-          "hostname": "Azure Notebooks"
-        }
-      }
-    },
+    "200": {},
     "204": {}
   }
 }
diff --git a/.../notebooks/resource-manager/Microsoft.Notebooks/preview/2019-10-11-preview/notebooks.json b/.../notebooks/resource-manager/Microsoft.Notebooks/preview/2019-10-11-preview/notebooks.json
@@ -196,10 +196,7 @@
         ],
         "responses": {
           "200": {
-            "description": "OK",
-            "schema": {
-              "$ref": "#/definitions/NotebookProxy"
-            }
+            "description": "Success"
           },
           "204": {
             "description": "No Content"
@@ -503,6 +500,18 @@
         "hostname": {
           "description": "The friendly string identifier of the creator of the NotebookProxy resource.",
           "type": "string"
+        },
+        "region": {
+          "description": "The region of the NotebookProxy resource.",
+          "type": "string"
+        },
+        "secondaryAppId": {
+          "description": "The alternate application ID used for auth token request in the data plane",
+          "type": "string"
+        },
+        "publicDns": {
+          "description": "The public DNS name",
+          "type": "string"
         }
       }
     },
@@ -632,17 +641,70 @@
           "readOnly": true,
           "type": "string",
           "description": "The type of the resource. Ex- Microsoft.Storage/storageAccounts or Microsoft.Notebooks/notebookProxies."
+        },
+        "systemData": {
+          "$ref": "#/definitions/NotebookResourceSystemData"
         }
       },
       "x-ms-azure-resource": true
     },
+    "NotebookResourceSystemData": {
+      "type": "object",
+      "description": "System data for notebook resource",
+      "properties": {
+        "createdBy": {
+          "type": "string"
+        },
+        "createdByType": {
+          "$ref": "#/definitions/IdentityType"
+        },
+        "createdAt": {
+          "format": "date-time",
+          "type": "string"
+        },
+        "lastModifiedBy": {
+          "type": "string"
+        },
+        "lastModifiedByType": {
+          "$ref": "#/definitions/IdentityType"
+        },
+        "lastModifiedAt": {
+          "format": "date-time",
+          "type": "string"
+        }
+      }
+    },
+    "IdentityType": {
+      "enum": [
+        "User",
+        "Application",
+        "ManagedIdentity",
+        "Key"
+      ],
+      "type": "string"
+    },
     "CloudError": {
       "type": "object",
       "description": "Wrapper for error response to follow ARM guidelines.",
       "properties": {
         "error": {
           "description": "The error response.",
           "$ref": "#/definitions/ErrorResponse"
+        },
+        "code": {
+          "type": "string",
+          "description": "[DEPRECATED] Error code."
+        },
+        "message": {
+          "type": "string",
+          "description": "[DEPRECATED] Error message."
+        },
+        "details": {
+          "type": "array",
+          "description": "[DEPRECATED] An array of error detail objects.",
+          "items": {
+            "$ref": "#/definitions/ErrorDetail"
+          }
         }
       }
     },
@@ -697,8 +759,12 @@
           "description": "Operation name: {provider}/{resource}/{operation}",
           "type": "string"
         },
+        "isDataAction": {
+          "description": "Indicates whether the operation applies to data-plane. True is for data-plane operations and false is for ARM/control-plane operations.",
+          "type": "boolean"
+        },
         "display": {
-          "description": "Display name of operation",
+          "description": "Display properties of the operation",
           "properties": {
             "provider": {
               "description": "The resource provider name: Microsoft.Notebooks",