[Hub Generated] Review request for Microsoft.KeyVault to add version …

…preview/2021-06-01-preview (#21671) * Fix s360 alerts for properties being returned in GET but not exising in PUT requests * Prettier fix * Fix model validation error for long running operation response missing location header * removed default value for array as it breaks the arm template schema creation * removed default value for array for managed hsm virtual network rule as it breaks the arm template schema creation
Azure · Dec 22, 2022 · e0aca4c · e0aca4c
1 parent d93f638
commit e0aca4c
Show file tree

Hide file tree

Showing 17 changed files with 154 additions and 29 deletions.
diff --git a/...nager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/DeletedManagedHsm_Purge.json b/...nager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/DeletedManagedHsm_Purge.json
@@ -6,6 +6,10 @@
     "api-version": "2021-04-01-preview"
   },
   "responses": {
-    "202": {}
+    "202": {
+      "headers": {
+        "Location": "https://some.endpoint.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/hsm-group/providers/Microsoft.KeyVault/managedHSMs/hsm1?api-version=2022-07-01&kv-operation=abJjb2RkIjoiAGVsZXRlTWFuYWdlZEhzbUFzeW5jYm9"
+      }
+    }
   }
 }
diff --git a/...ger/Microsoft.KeyVault/preview/2021-04-01-preview/examples/ManagedHsm_CreateOrUpdate.json b/...ger/Microsoft.KeyVault/preview/2021-04-01-preview/examples/ManagedHsm_CreateOrUpdate.json
@@ -27,6 +27,9 @@
   },
   "responses": {
     "202": {
+      "headers": {
+        "Location": "https://some.endpoint.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/hsm-group/providers/Microsoft.KeyVault/managedHSMs/hsm1?api-version=2022-07-01&kv-operation=abJjb2RkIjoiAGVsZXRlTWFuYWdlZEhzbUFzeW5jYm9"
+      },
       "body": {
         "properties": {
           "tenantId": "00000000-0000-0000-0000-000000000000",

diff --git a/...rce-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/ManagedHsm_Delete.json b/...rce-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/ManagedHsm_Delete.json
@@ -7,7 +7,11 @@
   },
   "responses": {
     "200": {},
-    "202": {},
+    "202": {
+      "headers": {
+        "Location": "https://some.endpoint.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/hsm-group/providers/Microsoft.KeyVault/managedHSMs/hsm1?api-version=2022-07-01&kv-operation=abJjb2RkIjoiAGVsZXRlTWFuYWdlZEhzbUFzeW5jYm9"
+      }
+    },
     "204": {}
   }
 }
diff --git a/...n/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/managedHsm.json b/...n/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/managedHsm.json
@@ -190,7 +190,13 @@
             "description": "Request successful. Resource does not exist."
           },
           "202": {
-            "description": "Accepted and the operation will complete asynchronously."
+            "description": "Accepted and the operation will complete asynchronously.",
+            "headers": {
+              "Location": {
+                "description": "The URI to poll for completion status.",
+                "type": "string"
+              }
+            }
           },
           "200": {
             "description": "Delete successful."
@@ -524,7 +530,13 @@
         ],
         "responses": {
           "202": {
-            "description": "Accepted and the operation will complete asynchronously."
+            "description": "Accepted and the operation will complete asynchronously.",
+            "headers": {
+              "Location": {
+                "description": "The URI to poll for completion status.",
+                "type": "string"
+              }
+            }
           },
           "default": {
             "description": "The error response describing why the operation failed.",
@@ -873,7 +885,11 @@
                 "description": "Create a new managed HSM pool. This is the default option."
               }
             ]
-          }
+          },
+          "x-ms-mutability": [
+            "create",
+            "update"
+          ]
         },
         "statusMessage": {
           "readOnly": true,
@@ -1177,7 +1193,8 @@
           "x-ms-enum": {
             "name": "NetworkRuleBypassOptions",
             "modelAsString": true
-          }
+          },
+          "default": "AzureServices"
         },
         "defaultAction": {
           "type": "string",
@@ -1189,7 +1206,8 @@
           "x-ms-enum": {
             "name": "NetworkRuleAction",
             "modelAsString": true
-          }
+          },
+          "default": "Allow"
         },
         "ipRules": {
           "type": "array",

diff --git a/...nager/Microsoft.KeyVault/preview/2021-06-01-preview/examples/DeletedManagedHsm_Purge.json b/...nager/Microsoft.KeyVault/preview/2021-06-01-preview/examples/DeletedManagedHsm_Purge.json
@@ -6,6 +6,10 @@
     "api-version": "2021-06-01-preview"
   },
   "responses": {
-    "202": {}
+    "202": {
+      "headers": {
+        "Location": "https://some.endpoint.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/hsm-group/providers/Microsoft.KeyVault/managedHSMs/hsm1?api-version=2022-07-01&kv-operation=abJjb2RkIjoiAGVsZXRlTWFuYWdlZEhzbUFzeW5jYm9"
+      }
+    }
   }
 }
diff --git a/...ger/Microsoft.KeyVault/preview/2021-06-01-preview/examples/ManagedHsm_CreateOrUpdate.json b/...ger/Microsoft.KeyVault/preview/2021-06-01-preview/examples/ManagedHsm_CreateOrUpdate.json
@@ -27,6 +27,9 @@
   },
   "responses": {
     "202": {
+      "headers": {
+        "Location": "https://some.endpoint.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/hsm-group/providers/Microsoft.KeyVault/managedHSMs/hsm1?api-version=2022-07-01&kv-operation=abJjb2RkIjoiAGVsZXRlTWFuYWdlZEhzbUFzeW5jYm9"
+      },
       "body": {
         "properties": {
           "tenantId": "00000000-0000-0000-0000-000000000000",

diff --git a/...rce-manager/Microsoft.KeyVault/preview/2021-06-01-preview/examples/ManagedHsm_Delete.json b/...rce-manager/Microsoft.KeyVault/preview/2021-06-01-preview/examples/ManagedHsm_Delete.json
@@ -7,7 +7,11 @@
   },
   "responses": {
     "200": {},
-    "202": {},
+    "202": {
+      "headers": {
+        "Location": "https://some.endpoint.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/hsm-group/providers/Microsoft.KeyVault/managedHSMs/hsm1?api-version=2022-07-01&kv-operation=abJjb2RkIjoiAGVsZXRlTWFuYWdlZEhzbUFzeW5jYm9"
+      }
+    },
     "204": {}
   }
 }
diff --git a/...n/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-06-01-preview/managedHsm.json b/...n/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-06-01-preview/managedHsm.json
@@ -190,7 +190,13 @@
             "description": "Request successful. Resource does not exist."
           },
           "202": {
-            "description": "Accepted and the operation will complete asynchronously."
+            "description": "Accepted and the operation will complete asynchronously.",
+            "headers": {
+              "Location": {
+                "description": "The URI to poll for completion status.",
+                "type": "string"
+              }
+            }
           },
           "200": {
             "description": "Delete successful."
@@ -524,7 +530,13 @@
         ],
         "responses": {
           "202": {
-            "description": "Accepted and the operation will complete asynchronously."
+            "description": "Accepted and the operation will complete asynchronously.",
+            "headers": {
+              "Location": {
+                "description": "The URI to poll for completion status.",
+                "type": "string"
+              }
+            }
           },
           "default": {
             "description": "The error response describing why the operation failed.",
@@ -873,7 +885,11 @@
                 "description": "Create a new managed HSM pool. This is the default option."
               }
             ]
-          }
+          },
+          "x-ms-mutability": [
+            "create",
+            "update"
+          ]
         },
         "statusMessage": {
           "readOnly": true,
@@ -1177,7 +1193,8 @@
           "x-ms-enum": {
             "name": "NetworkRuleBypassOptions",
             "modelAsString": true
-          }
+          },
+          "default": "AzureServices"
         },
         "defaultAction": {
           "type": "string",
@@ -1189,7 +1206,8 @@
           "x-ms-enum": {
             "name": "NetworkRuleAction",
             "modelAsString": true
-          }
+          },
+          "default": "Allow"
         },
         "ipRules": {
           "type": "array",

diff --git a/...nager/Microsoft.KeyVault/preview/2021-11-01-preview/examples/DeletedManagedHsm_Purge.json b/...nager/Microsoft.KeyVault/preview/2021-11-01-preview/examples/DeletedManagedHsm_Purge.json
@@ -6,6 +6,10 @@
     "api-version": "2021-11-01-preview"
   },
   "responses": {
-    "202": {}
+    "202": {
+      "headers": {
+        "Location": "https://some.endpoint.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/hsm-group/providers/Microsoft.KeyVault/managedHSMs/hsm1?api-version=2022-07-01&kv-operation=abJjb2RkIjoiAGVsZXRlTWFuYWdlZEhzbUFzeW5jYm9"
+      }
+    }
   }
 }
diff --git a/...ger/Microsoft.KeyVault/preview/2021-11-01-preview/examples/ManagedHsm_CreateOrUpdate.json b/...ger/Microsoft.KeyVault/preview/2021-11-01-preview/examples/ManagedHsm_CreateOrUpdate.json
@@ -27,6 +27,9 @@
   },
   "responses": {
     "202": {
+      "headers": {
+        "Location": "https://some.endpoint.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/hsm-group/providers/Microsoft.KeyVault/managedHSMs/hsm1?api-version=2022-07-01&kv-operation=abJjb2RkIjoiAGVsZXRlTWFuYWdlZEhzbUFzeW5jYm9"
+      },
       "body": {
         "properties": {
           "tenantId": "00000000-0000-0000-0000-000000000000",

diff --git a/...rce-manager/Microsoft.KeyVault/preview/2021-11-01-preview/examples/ManagedHsm_Delete.json b/...rce-manager/Microsoft.KeyVault/preview/2021-11-01-preview/examples/ManagedHsm_Delete.json
@@ -7,7 +7,11 @@
   },
   "responses": {
     "200": {},
-    "202": {},
+    "202": {
+      "headers": {
+        "Location": "https://some.endpoint.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/hsm-group/providers/Microsoft.KeyVault/managedHSMs/hsm1?api-version=2022-07-01&kv-operation=abJjb2RkIjoiAGVsZXRlTWFuYWdlZEhzbUFzeW5jYm9"
+      }
+    },
     "204": {}
   }
 }
diff --git a/...n/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-11-01-preview/managedHsm.json b/...n/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-11-01-preview/managedHsm.json
@@ -190,7 +190,13 @@
             "description": "Request successful. Resource does not exist."
           },
           "202": {
-            "description": "Accepted and the operation will complete asynchronously."
+            "description": "Accepted and the operation will complete asynchronously.",
+            "headers": {
+              "Location": {
+                "description": "The URI to poll for completion status.",
+                "type": "string"
+              }
+            }
           },
           "200": {
             "description": "Delete successful."
@@ -524,7 +530,13 @@
         ],
         "responses": {
           "202": {
-            "description": "Accepted and the operation will complete asynchronously."
+            "description": "Accepted and the operation will complete asynchronously.",
+            "headers": {
+              "Location": {
+                "description": "The URI to poll for completion status.",
+                "type": "string"
+              }
+            }
           },
           "default": {
             "description": "The error response describing why the operation failed.",
@@ -873,7 +885,11 @@
                 "description": "Create a new managed HSM pool. This is the default option."
               }
             ]
-          }
+          },
+          "x-ms-mutability": [
+            "create",
+            "update"
+          ]
         },
         "statusMessage": {
           "readOnly": true,
@@ -1177,7 +1193,8 @@
           "x-ms-enum": {
             "name": "NetworkRuleBypassOptions",
             "modelAsString": true
-          }
+          },
+          "default": "AzureServices"
         },
         "defaultAction": {
           "type": "string",
@@ -1189,7 +1206,8 @@
           "x-ms-enum": {
             "name": "NetworkRuleAction",
             "modelAsString": true
-          }
+          },
+          "default": "Allow"
         },
         "ipRules": {
           "type": "array",

diff --git a/...source-manager/Microsoft.KeyVault/stable/2021-10-01/examples/DeletedManagedHsm_Purge.json b/...source-manager/Microsoft.KeyVault/stable/2021-10-01/examples/DeletedManagedHsm_Purge.json
@@ -6,6 +6,10 @@
     "api-version": "2021-10-01"
   },
   "responses": {
-    "202": {}
+    "202": {
+      "headers": {
+        "Location": "https://some.endpoint.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/hsm-group/providers/Microsoft.KeyVault/managedHSMs/hsm1?api-version=2022-07-01&kv-operation=abJjb2RkIjoiAGVsZXRlTWFuYWdlZEhzbUFzeW5jYm9"
+      }
+    }
   }
 }
diff --git a/...urce-manager/Microsoft.KeyVault/stable/2021-10-01/examples/ManagedHsm_CreateOrUpdate.json b/...urce-manager/Microsoft.KeyVault/stable/2021-10-01/examples/ManagedHsm_CreateOrUpdate.json
@@ -27,6 +27,9 @@
   },
   "responses": {
     "202": {
+      "headers": {
+        "Location": "https://some.endpoint.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/hsm-group/providers/Microsoft.KeyVault/managedHSMs/hsm1?api-version=2022-07-01&kv-operation=abJjb2RkIjoiAGVsZXRlTWFuYWdlZEhzbUFzeW5jYm9"
+      },
       "body": {
         "properties": {
           "tenantId": "00000000-0000-0000-0000-000000000000",

diff --git a/...ult/resource-manager/Microsoft.KeyVault/stable/2021-10-01/examples/ManagedHsm_Delete.json b/...ult/resource-manager/Microsoft.KeyVault/stable/2021-10-01/examples/ManagedHsm_Delete.json
@@ -7,7 +7,11 @@
   },
   "responses": {
     "200": {},
-    "202": {},
+    "202": {
+      "headers": {
+        "Location": "https://some.endpoint.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/hsm-group/providers/Microsoft.KeyVault/managedHSMs/hsm1?api-version=2022-07-01&kv-operation=abJjb2RkIjoiAGVsZXRlTWFuYWdlZEhzbUFzeW5jYm9"
+      }
+    },
     "204": {}
   }
 }
diff --git a/specification/keyvault/resource-manager/Microsoft.KeyVault/stable/2021-10-01/managedHsm.json b/specification/keyvault/resource-manager/Microsoft.KeyVault/stable/2021-10-01/managedHsm.json
@@ -190,7 +190,13 @@
             "description": "Request successful. Resource does not exist."
           },
           "202": {
-            "description": "Accepted and the operation will complete asynchronously."
+            "description": "Accepted and the operation will complete asynchronously.",
+            "headers": {
+              "Location": {
+                "description": "The URI to poll for completion status.",
+                "type": "string"
+              }
+            }
           },
           "200": {
             "description": "Delete successful."
@@ -524,7 +530,13 @@
         ],
         "responses": {
           "202": {
-            "description": "Accepted and the operation will complete asynchronously."
+            "description": "Accepted and the operation will complete asynchronously.",
+            "headers": {
+              "Location": {
+                "description": "The URI to poll for completion status.",
+                "type": "string"
+              }
+            }
           },
           "default": {
             "description": "The error response describing why the operation failed.",
@@ -874,7 +886,11 @@
                 "description": "Create a new managed HSM pool. This is the default option."
               }
             ]
-          }
+          },
+          "x-ms-mutability": [
+            "create",
+            "update"
+          ]
         },
         "statusMessage": {
           "readOnly": true,
@@ -1188,7 +1204,8 @@
           "x-ms-enum": {
             "name": "NetworkRuleBypassOptions",
             "modelAsString": true
-          }
+          },
+          "default": "AzureServices"
         },
         "defaultAction": {
           "type": "string",
@@ -1200,7 +1217,8 @@
           "x-ms-enum": {
             "name": "NetworkRuleAction",
             "modelAsString": true
-          }
+          },
+          "default": "Allow"
         },
         "ipRules": {
           "type": "array",