Merge branch master

.azure-pipelines/SDKAutomation.yml

@@ -20,7 +20,6 @@ jobs:
 
   variables:
       NODE_OPTIONS: '--max-old-space-size=8192'
-      BLOB_STORAGE_PREFIX: sdkautomation-pipeline
       SPEC_REPO: $(Build.Repository.Name)
       PR_NUMBER: $(System.PullRequest.PullRequestNumber)
       BUILD_ID: $(Build.BuildId)
@@ -42,6 +41,7 @@ jobs:
         SDK_REPO_NAME: azure-sdk-for-go
       Trenton:
         SDK_REPO_NAME: azure-sdk-for-trenton
+      ${{ if eq(variables['ENABLE_RESOURCE_MANAGER_SCHEMAS'], 'true') }}:
       Schema:
         SDK_REPO_NAME: azure-resource-manager-schemas
   steps:
@@ -64,13 +64,16 @@ jobs:
     displayName: Pull SDK Automation Image
   - script: |
       docker run \
+        -e BLOB_PROXY_PREFIX \
+        -e BLOB_STORAGE_PREFIX \
+        -e BLOB_STORAGE_IS_PUBLIC \
+        -e BLOB_DOWNLOAD_COMMAND \
         -e BLOB_STORAGE_NAME \
         -e BLOB_STORAGE_KEY \
         -e GITHUB_COMMENT_AUTHOR_NAME \
         -e GITHUBAPP_ID \
         -e GITHUBAPP_PRIVATE_KEY \
         -e NODE_OPTIONS \
-        -e BLOB_STORAGE_PREFIX \
         -e SPEC_REPO \
         -e PR_NUMBER \
         -e SDK_REPO_NAME \
@@ -80,6 +83,10 @@ jobs:
     env:
       BLOB_STORAGE_NAME: $(blob-storage-name)
       BLOB_STORAGE_KEY: $(blob-storage-key)
+      BLOB_STORAGE_PREFIX: $(blob-storage-prefix)
+      BLOB_PROXY_PREFIX: $(blob-proxy-prefix)
+      BLOB_STORAGE_IS_PUBLIC: $(blob-is-public)
+      BLOB_DOWNLOAD_COMMAND: $(blob-download-command)
       GITHUB_COMMENT_AUTHOR_NAME: $(github-comment-author-name)
       GITHUBAPP_ID: $(githubapp-id)
       GITHUBAPP_PRIVATE_KEY: $(githubapp-private-key)

.github/pull_request_assignment.yml

@@ -14,6 +14,7 @@
       - "specification/network/**"
     reviewers:
       - MyronFanQiu
+      - lirenhe
 
 - rule:
     paths:

cSpell.json

@@ -161,6 +161,12 @@
                 "azpodpolicy"
             ]
         },
+        {
+            "filename": "**/specification/containerservice/resource-manager/Microsoft.ContainerService/stable/2020-09-01/managedClusters.json",
+            "words": [
+                "azpodpolicy"
+            ]
+        },
         {
             "filename": "**/specification/containerregistry/data-plane/Microsoft.ContainerRegistry/preview/2018-08-10/containerregistry.json",
             "words": [

custom-words.txt

@@ -1886,4 +1886,4 @@ networkrulesets
 Setget
 Ruleproperties
 shamir_share
-dllpath
+dllpath

documentation/openapi-authoring-automated-guidelines.md

@@ -140,6 +140,7 @@ We request OpenAPI(Swagger) spec authoring be assigned to engineers who have an
 | [R2007](#r2007) | [LongRunningOperationsWithLongRunningExtension](#r2007) | ARM OpenAPI(swagger) specs |
 | [R2029](#r2029) | [PageableOperation](#r2029) | ARM and Data plane OpenAPI(swagger) specs |
 | [R4006](#r4006) | [DeprecatedXmsCodeGenerationSetting](#r4006) | ARM and Data plane OpenAPI(swagger) specs |
+| [R4024](#r4024) | [PreviewVersionOverOneYear](#r4024) | ARM OpenAPI(swagger) specs |
 
 
 ### RPaaS Violations
@@ -1432,7 +1433,7 @@ Links: [Index](#index) | [Error vs. Warning](#error-vs-warning) | [Automated Rul
 
 **Applies to** : ARM OpenAPI(swagger) specs
 
-**Output Message**: Top level properties should be one of name, type, id, location, properties, tags, plan, sku, etag, managedBy, identity, systemData. Model definition '{0}' has extra properties ['{1}'].
+**Output Message**: Top level properties should be one of name, type, id, location, properties, tags, plan, sku, etag, managedBy, identity, systemData, extendedlocation. Model definition '{0}' has extra properties ['{1}'].
 
 **Description**: Per [ARM guidelines](https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/resource-api-reference.md), top level properties of a resource should be only ones from the allowed set.
 
@@ -1690,7 +1691,7 @@ Links: [Index](#index) | [Error vs. Warning](#error-vs-warning) | [Automated Rul
 **Output Message**: Properties of a PATCH request body must not be {0}. PATCH operation: '{1}' Model Definition: '{2}' Property: '{3}'
 
 **Description**: A request parameter of the Patch Operation must not have a required/default value.
-But it's allowed when all required properties are marked as discriminator, because the discriminator must be required.
+But it's allowed when the only required properties is marked as discriminator, because the discriminator must be required.
 
 **CreatedAt** : N/A
 
@@ -1994,7 +1995,7 @@ Links: [Index](#index) | [Error vs. Warning](#error-vs-warning) | [Automated Rul
 
 ### <a name="r3021" ></a>R3021 PathResourceTypeNameCamelCase
 
-**Category** : ARM Warning
+**Category** : ARM Error
 
 **Applies to** : ARM and Data Plane OpenAPI(swagger) specs
 
@@ -2948,4 +2949,24 @@ The following would be valid:
   }
 ...
 ```
-Links: [Index](#index) | [Error vs. Warning](#error-vs-warning) | [Automated Rules](#automated-rules) | [ARM](#arm-violations): [Errors](#arm-errors) or [Warnings](#arm-warnings) | [SDK](#sdk-violations): [Errors](#sdk-errors) or [Warnings](#sdk-warnings)
+Links: [Index](#index) | [Error vs. Warning](#error-vs-warning) | [Automated Rules](#automated-rules) | [ARM](#arm-violations): [Errors](#arm-errors) or [Warnings](#arm-warnings) | [SDK](#sdk-violations): [Errors](#sdk-errors) or [Warnings](#sdk-warnings)
+
+### <a name="r4024" ></a>R4024 PreviewVersionOverOneYear
+
+**Category** : SDK Warning
+
+**Applies to** : ARM OpenAPI(swagger) specs
+
+**Output Message** : The API version:{api-version} having been in a preview state over one year , please move to GA or retire.
+
+**Description** : Per [Retirement-of-Previews](https://dev.azure.com/msazure/AzureWiki/_wiki/wikis/AzureWiki.wiki/37683/Retirement-of-Previews), service, feature, API, and SKU in preview for over one year need to move to GA or retire.
+
+**CreatedAt**: Sep 8, 2020
+
+**LastModifiedAt**: Sep 8, 2020
+
+**How to fix the violation**: 
+   Consider retiring or moving to GA. 
+
+Links: [Index](#index) | [Error vs. Warning](#error-vs-warning) | [Automated Rules](#automated-rules) | [ARM](#arm-violations): [Errors](#arm-errors) or [Warnings](#arm-warnings) | [SDK](#sdk-violations): [Errors](#sdk-errors) or [Warnings](#sdk-warnings)
+