Merge branch 'main' into feature/cplat-2022-11-01

.github/comment.yml

@@ -16,6 +16,16 @@
         openapiHub: https://portal.azure-devex-tools.com
     onLabeledComments: "Hi @${PRAuthor}, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow [breaking change policy](https://aka.ms/AzBreakingChangesPolicy) to request breaking change review and approval before proceeding swagger PR review. </br>**Action**: To initiate an evaluation of the breaking change, create a new intake using the [template for breaking changes](https://aka.ms/Breakingchangetemplate). Addition details on the process and office hours are on the [Breaking change Wiki](https://dev.azure.com/msazure/AzureWiki/_wiki/wikis/AzureWiki.wiki/37684/Breaking-Changes).</br> If you want to know the production traffic statistic, please see [ARM Traffic statistic](${openapiHub}/api/pr/query-traffic?pr=${owner}/${repo}/${PRNumber}&days=5). </br> If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback. </br> **Note**: To avoid breaking change, you can refer to [Shift Left Solution](https://aka.ms/shiftleft) for detecting breaking change in early phase at your service code repository."
 
+- rule:
+    type: label
+    label: SuppressionReviewRequired
+    onLabeledComments: "Hi @${PRAuthor}, one or multiple validation error/warning suppression(s) is detected in your PR. Please follow the [Swagger-Suppression-Process](https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/85/Swagger-Suppression-Process) to get approval."
+
+- rule:
+    type: label
+    label: "CI-MissingBaseCommit"
+    onLabeledComments: "Hi, @${PRAuthor}, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the [wiki](https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/208/OpenAPI-Hub-Adding-new-API-version). Or you could onboard [API spec pipeline](https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/606/Enable-API-Spec-Pipeline)"
+
 - rule:
     type: label
     repoAllowList:
@@ -31,6 +41,21 @@
     label: NewApiVersionRequired
     onLabeledComments: "<b>NewApiVersionRequired reason:</b></br> </br><b>A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support. </b> </br></br> EXAMPLE: if a customer calls a service in the public cloud using <b>api-version=2020-07-27</b>, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.  "
 
+- rule:
+    type: label
+    label: CI-NewRPNamespaceWithoutRPaaS
+    onLabeledComments: "Hi @${PRAuthor} This PR was flagged for introducing a new RP namespace that is not being onboarded with [RPaaS](https://armwiki.azurewebsites.net/rpaas/overview.html). Merging this PR to the main branch will be blocked as RPaaS is required for new RPs. To resolve this and allow the PR to be merged into the main branch, please [use RPaaS to onboard the new RP](https://armwiki.azurewebsites.net/rpaas/gettingstarted.html)."
+
+- rule:
+    type: label
+    label: CI-RpaaSRPNotInPrivateRepo
+    onLabeledComments: "Hi @${PRAuthor} This PR was flagged for attempting to introduce a new RP namespace to the main branch without first merging the new RP to the RPSaaSMaster branch. Please add the new RP in a merge to RPSaaSMaster before continuing the merge to main."
+
+- rule:
+    type: label
+    label: ArcReview
+    onLabeledComments: "Hi @${PRAuthor} and @arcboard, one or more change(s) have been detected in your Arc enabled VM's or Arc enabled Server's RPs. Please review the changes and ensure that no gaps have been introduced with respect to the ARM API modeling consistency across Azure Arc and Azure Compute. For further details, see guidelines at [Consistency in ARM Modeling](https://msazure.visualstudio.com/One/_wiki/wikis/One.wiki/377428/Consistency-in-ARM-Modeling?anchor=general-design-guidance). To approve the change(s), set the label to ArcSignedOff. If you have any questions, please mail to [email protected]."
+
 - rule:
     type: label
     label: CI-FixRequiredOnFailure

.github/fabricbot.json

@@ -3123,6 +3123,12 @@
               "label": "no-recent-activity"
             }
           },
+          {
+            "name": "noLabel",
+            "parameters": {
+              "label": "customer-reported"
+            }
+          },
           {
             "name": "isPr",
             "parameters": {}
@@ -3225,6 +3231,12 @@
             "parameters": {
               "days": 14
             }
+          },
+          {
+            "name": "noLabel",
+            "parameters": {
+              "label": "customer-reported"
+            }
           }
         ],
         "taskName": "Close stale PR (no update for 30 days)",
@@ -4163,6 +4175,33 @@
               ""
             ]
           },
+          {
+            "label": "Load Test Service",
+            "pathFilter": [
+              "specification/loadtestservice/"
+            ],
+            "exclude": [
+              ""
+            ]
+          },
+          {
+            "label": "Maps",
+            "pathFilter": [
+              "specification/maps/"
+            ],
+            "exclude": [
+              ""
+            ]
+          },
+          {
+            "label": "Purview",
+            "pathFilter": [
+              "specification/purview/"
+            ],
+            "exclude": [
+              ""
+            ]
+          },
           {
             "label": "TimeseriesInsights",
             "pathFilter": [
@@ -4198,6 +4237,15 @@
             "exclude": [
               ""
             ]
+          },
+          {
+            "label": "ArcReview",
+            "pathFilter": [
+              "specification/hybridcompute/resource-manager/",
+              "specification/connectedvmware/resource-manager/",
+              "specification/azurestackhci/resource-manager/",
+              "specification/scvmm/resource-manager/"
+            ]
           }
         ],
         "taskName": "Auto PR based on folder paths "
@@ -4874,4 +4922,4 @@
       ]
     }
   ]
-}
+}

.github/pull_request_assignment.yml

@@ -5,15 +5,28 @@
       - "specification/cognitiveservices/data-plane/TranslatorText/**"
     reviewers:
       - kristapratico
-      - maririos
+
+- rule:
+    # Cognitive Services - Language pillar data-plane PR
+    paths:
+      - "specification/cognitiveservices/data-plane/Language/**"
+    reviewers:
+      - kristapratico
+      - heaths
+
+- rule:
+    # Key Vault data-plane PR
+    paths:
+      - "specification/keyvault/data-plane/**"
+    reviewers:
+      - heaths
 
 - rule:
     paths:
       - "specification/confidentialledger/data-plane/**"
     reviewers:
       - christothes 
 
-
 - rule:
     # eventgrid data-plane PR
     paths:
@@ -74,10 +87,18 @@
 
 
 - rule:
-    paths: "specification/@(providerhub|sql|appplatform|deviceupdate|servicelinker|imagebuilder|throttling|secretmanagementtestsvc)/**"
+    paths: "specification/@(providerhub|sql|appplatform|deviceupdate|servicelinker|imagebuilder|throttling|secretmanagementtestsvc|containerservice)/**"
+    reviewers:
+      - raych1
+      - xiaoxuqi-ms
+
+- rule:
+    paths: "specification/voiceservices/**"
     reviewers:
       - raych1
       - xiaoxuqi-ms
+    branches:
+      - RPSaaSDev
 
 - rule:
     paths: "specification/sql/**"
@@ -229,6 +250,5 @@
       - dw511214992
       - honghr
       - tianxchen-ms
-      - tadelesh
       - xiaoxuqi-ms
       - live1206

.github/sla.yml

@@ -28,6 +28,22 @@
         - ${AUTHOR}
         - ${ASSIGNEE}
 
+
+- scheduleTask:
+    action: sendEmail
+    scope: pull_request
+    name: "send email to Arc review board"
+    trigger:
+      - label
+    args:
+      booleanFilterExpression: "ArcReview"
+      message: "<p>Hi, Arc review board,</p><p>Please review the PR ${URL} . You receive the email because the PR is labeled with ArcReview. <br> One or more change(s) have been detected in your Arc enabled VM or Arc enabled Server RPs. Please review the changes and ensure that no gaps have been introduced with respect to the ARM API modeling consistency across Azure Arc and Azure Compute. For further details, see guidelines at Consistency in ARM Modeling. To approve the change(s), add the label ArcSignedOff.</p>"
+      subject: "Action Required ArcReview: Please review PR ${URL}"
+      to: [email protected]
+      cc:
+        - ${AUTHOR}
+        - ${ASSIGNEE}
+
 - scheduleTask:
     action: sendEmail
     scope: pull_request