Adding flag to support non-dynamic destination types while exporting …

…to LogAnalytics. Adding new metric units. Fixing some documentation issues. (#6454)

* [Monitor] Make all attributes of EventData class readonly (#2254)

* [Monitor] Fixing issue with metricnamespace specification as client level argument #2565

* [Monitor] Fixing incorrect specification of top parameter for Metrics API (#2655)

* Add two missing "by subscription" operations.

* Remove "examples" nodes as requested since they are not used anymore. Adding documentation to reduce number of warnings in validation.

* Add the serviceBusRuleId back into the DiagnosticSetting resource spec.

* Fix some issues with the examples

* [Monitor] Fix issue #3585: revert previous commit since it is a breaking change

* Add unit "BitsPerSecond" to the metrics specs.

* Fixing workspace Id documentation

* Add the Log Analytics destination type flag to the Diagnostic Settings objects

* Fix a typo in a description

specification/monitor/resource-manager/Microsoft.Insights/preview/2017-05-01-preview/diagnosticsSettings_API.json

@@ -297,18 +297,22 @@
           "items": {
             "$ref": "#/definitions/MetricSettings"
           },
-          "description": "the list of metric settings."
+          "description": "The list of metric settings."
         },
         "logs": {
           "type": "array",
           "items": {
             "$ref": "#/definitions/LogSettings"
           },
-          "description": "the list of logs settings."
+          "description": "The list of logs settings."
         },
         "workspaceId": {
           "type": "string",
-          "description": "The workspace ID (resource ID of a Log Analytics workspace) for a Log Analytics workspace to which you would like to send Diagnostic Logs. Example: /subscriptions/4b9e8510-67ab-4e9a-95a9-e2f1e570ea9c/resourceGroups/insights-integration/providers/Microsoft.OperationalInsights/workspaces/viruela2"
+          "description": "The full ARM resource ID of the Log Analytics workspace to which you would like to send Diagnostic Logs. Example: /subscriptions/4b9e8510-67ab-4e9a-95a9-e2f1e570ea9c/resourceGroups/insights-integration/providers/Microsoft.OperationalInsights/workspaces/viruela2"
+        },
+        "logAnalyticsDestinationType": {
+          "type": "string",
+          "description": "A string indicating whether the export to Log Analytics should use the default destination type, i.e. AzureDiagnostics, or use a destination type constructed as follows: <normalized service identity>_<normalized category name>. Possible values are: Dedicated and null (null is default.)"
         }
       },
       "description": "The diagnostic settings."

specification/monitor/resource-manager/Microsoft.Insights/preview/2017-05-01-preview/examples/createOrUpdateDiagnosticSetting.json

@@ -28,7 +28,8 @@
               "days":0
             }
           }
-        ]
+        ],
+        "logAnalyticsDestinationType":"Dedicated"
       }
     }
   },
@@ -63,7 +64,8 @@
                 "days":0
               }
             }
-          ]
+          ],
+          "logAnalyticsDestinationType":"Dedicated"
         }
       }
     }

specification/monitor/resource-manager/Microsoft.Insights/stable/2018-01-01/metricDefinitions_API.json

@@ -119,7 +119,11 @@
         "Percent",
         "MilliSeconds",
         "ByteSeconds",
-        "Unspecified"
+        "Unspecified",
+        "Cores",
+        "MilliCores",
+        "NanoCores",
+        "BitsPerSecond"
       ],
       "x-ms-enum": {
         "name": "Unit",

specification/monitor/resource-manager/Microsoft.Insights/stable/2018-01-01/metrics_API.json

@@ -131,7 +131,11 @@
         "Percent",
         "MilliSeconds",
         "ByteSeconds",
-        "Unspecified"
+        "Unspecified",
+        "Cores",
+        "MilliCores",
+        "NanoCores",
+        "BitsPerSecond"
       ],
       "x-ms-enum": {
         "name": "Unit",