Skip to content

Commit

Permalink
[Hub Generated] Review request for Microsoft.KeyVault to add version …
Browse files Browse the repository at this point in the history 
…stable/2023-02-01 (#23428)

* Update description for managed HSM properties in resource manager for following properties: enableSoftDelete, softDeleteRetentionDays, enablePurgeProtection and publicNetworkAccess

* Fix model validation failures for LRO_Response_Header rule in managed HSM resource manager version 2020-04-01-preview

* Fix model validation failures for LRO_Response_Header rule in managed HSM resource manager version 2020-04-01-preview for delete operation

* Revert change of location header to delete in managed HSM resource manager

* Fix S360 issue with additional property being returned for managed HSM RP public network access. Added default value.

* Fix S360 alert for enum mismatch in Managed HSM resource manager for SKU property
  • Loading branch information
@neeerajaakula
neeerajaakula authored Apr 11, 2023
1 parent 1f22d4d commit 33f06ff
Show file tree
Hide file tree
Showing 10 changed files with 68 additions and 43 deletions.
3 changes: 3 additions & 0 deletions ...rce-manager/Microsoft.KeyVault/preview/2020-04-01-preview/examples/ManagedHsm_Update.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,9 @@
}
},
"202": {
"headers": {
"Location": "https://some.endpoint.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/hsm-group/providers/Microsoft.KeyVault/managedHSMs/hsm1?api-version=2022-07-01&kv-operation=abJjb2RkIjoiAGVsZXRlTWFuYWdlZEhzbUFzeW5jYm9"
},
"body": {
"properties": {
"tenantId": "00000000-0000-0000-0000-000000000000",
Expand Down
12 changes: 9 additions & 3 deletions ...n/keyvault/resource-manager/Microsoft.KeyVault/preview/2020-04-01-preview/managedHsm.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,12 @@
"responses": {
"202": {
"description": "Accepted and the operation will complete asynchronously.",
"headers": {
"Location": {
"description": "The URI to poll for completion status.",
"type": "string"
}
},
"schema": {
"$ref": "#/definitions/ManagedHsm"
}
Expand Down Expand Up @@ -406,18 +412,18 @@
"enableSoftDelete": {
"type": "boolean",
"default": true,
"description": "Property to specify whether the 'soft delete' functionality is enabled for this managed HSM pool. If it's not set to any value(true or false) when creating new managed HSM pool, it will be set to true by default. Once set to true, it cannot be reverted to false."
"description": "Property to specify whether the 'soft delete' functionality is enabled for this managed HSM pool. Soft delete is enabled by default for all managed HSMs and is immutable."
},
"softDeleteRetentionInDays": {
"type": "integer",
"format": "int32",
"default": 90,
"description": "softDelete data retention days. It accepts >=7 and <=90."
"description": "Soft deleted data retention days. When you delete an HSM or a key, it will remain recoverable for the configured retention period or for a default period of 90 days. It accepts values between 7 and 90."
},
"enablePurgeProtection": {
"type": "boolean",
"default": true,
"description": "Property specifying whether protection against purge is enabled for this managed HSM pool. Setting this property to true activates protection against purge for this managed HSM pool and its content - only the Managed HSM service may initiate a hard, irrecoverable deletion. The setting is effective only if soft delete is also enabled. Enabling this functionality is irreversible."
"description": "Property specifying whether protection against purge is enabled for this managed HSM pool. Setting this property to true activates protection against purge for this managed HSM pool and its content - only the Managed HSM service may initiate a hard, irrecoverable deletion. Enabling this functionality is irreversible."
},
"createMode": {
"type": "string",
Expand Down
12 changes: 7 additions & 5 deletions ...n/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/managedHsm.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -816,7 +816,8 @@
"description": "SKU of the managed HSM Pool",
"enum": [
"Standard_B1",
"Custom_B32"
"Custom_B32",
"Custom_B6"
],
"x-ms-enum": {
"name": "ManagedHsmSkuName",
Expand Down Expand Up @@ -852,18 +853,18 @@
"enableSoftDelete": {
"type": "boolean",
"default": true,
"description": "Property to specify whether the 'soft delete' functionality is enabled for this managed HSM pool. If it's not set to any value(true or false) when creating new managed HSM pool, it will be set to true by default. Once set to true, it cannot be reverted to false."
"description": "Property to specify whether the 'soft delete' functionality is enabled for this managed HSM pool. Soft delete is enabled by default for all managed HSMs and is immutable."
},
"softDeleteRetentionInDays": {
"type": "integer",
"format": "int32",
"default": 90,
"description": "softDelete data retention days. It accepts >=7 and <=90."
"description": "Soft deleted data retention days. When you delete an HSM or a key, it will remain recoverable for the configured retention period or for a default period of 90 days. It accepts values between 7 and 90."
},
"enablePurgeProtection": {
"type": "boolean",
"default": true,
"description": "Property specifying whether protection against purge is enabled for this managed HSM pool. Setting this property to true activates protection against purge for this managed HSM pool and its content - only the Managed HSM service may initiate a hard, irrecoverable deletion. The setting is effective only if soft delete is also enabled. Enabling this functionality is irreversible."
"description": "Property specifying whether protection against purge is enabled for this managed HSM pool. Setting this property to true activates protection against purge for this managed HSM pool and its content - only the Managed HSM service may initiate a hard, irrecoverable deletion. Enabling this functionality is irreversible."
},
"createMode": {
"type": "string",
Expand Down Expand Up @@ -962,11 +963,12 @@
"description": "List of private endpoint connections associated with the managed hsm pool."
},
"publicNetworkAccess": {
"description": "Control permission for data plane traffic coming from public networks while private endpoint is enabled.",
"description": "Control permission to the managed HSM from public networks.",
"enum": [
"Enabled",
"Disabled"
],
"default": "Enabled",
"type": "string",
"x-ms-enum": {
"name": "PublicNetworkAccess",
Expand Down
12 changes: 7 additions & 5 deletions ...n/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-06-01-preview/managedHsm.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -816,7 +816,8 @@
"description": "SKU of the managed HSM Pool",
"enum": [
"Standard_B1",
"Custom_B32"
"Custom_B32",
"Custom_B6"
],
"x-ms-enum": {
"name": "ManagedHsmSkuName",
Expand Down Expand Up @@ -852,18 +853,18 @@
"enableSoftDelete": {
"type": "boolean",
"default": true,
"description": "Property to specify whether the 'soft delete' functionality is enabled for this managed HSM pool. If it's not set to any value(true or false) when creating new managed HSM pool, it will be set to true by default. Once set to true, it cannot be reverted to false."
"description": "Property to specify whether the 'soft delete' functionality is enabled for this managed HSM pool. Soft delete is enabled by default for all managed HSMs and is immutable."
},
"softDeleteRetentionInDays": {
"type": "integer",
"format": "int32",
"default": 90,
"description": "softDelete data retention days. It accepts >=7 and <=90."
"description": "Soft deleted data retention days. When you delete an HSM or a key, it will remain recoverable for the configured retention period or for a default period of 90 days. It accepts values between 7 and 90."
},
"enablePurgeProtection": {
"type": "boolean",
"default": true,
"description": "Property specifying whether protection against purge is enabled for this managed HSM pool. Setting this property to true activates protection against purge for this managed HSM pool and its content - only the Managed HSM service may initiate a hard, irrecoverable deletion. The setting is effective only if soft delete is also enabled. Enabling this functionality is irreversible."
"description": "Property specifying whether protection against purge is enabled for this managed HSM pool. Setting this property to true activates protection against purge for this managed HSM pool and its content - only the Managed HSM service may initiate a hard, irrecoverable deletion. Enabling this functionality is irreversible."
},
"createMode": {
"type": "string",
Expand Down Expand Up @@ -962,11 +963,12 @@
"description": "List of private endpoint connections associated with the managed hsm pool."
},
"publicNetworkAccess": {
"description": "Control permission for data plane traffic coming from public networks while private endpoint is enabled.",
"description": "Control permission to the managed HSM from public networks.",
"enum": [
"Enabled",
"Disabled"
],
"default": "Enabled",
"type": "string",
"x-ms-enum": {
"name": "PublicNetworkAccess",
Expand Down
12 changes: 7 additions & 5 deletions ...n/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-11-01-preview/managedHsm.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -816,7 +816,8 @@
"description": "SKU of the managed HSM Pool",
"enum": [
"Standard_B1",
"Custom_B32"
"Custom_B32",
"Custom_B6"
],
"x-ms-enum": {
"name": "ManagedHsmSkuName",
Expand Down Expand Up @@ -852,18 +853,18 @@
"enableSoftDelete": {
"type": "boolean",
"default": true,
"description": "Property to specify whether the 'soft delete' functionality is enabled for this managed HSM pool. If it's not set to any value(true or false) when creating new managed HSM pool, it will be set to true by default. Once set to true, it cannot be reverted to false."
"description": "Property to specify whether the 'soft delete' functionality is enabled for this managed HSM pool. Soft delete is enabled by default for all managed HSMs and is immutable."
},
"softDeleteRetentionInDays": {
"type": "integer",
"format": "int32",
"default": 90,
"description": "softDelete data retention days. It accepts >=7 and <=90."
"description": "Soft deleted data retention days. When you delete an HSM or a key, it will remain recoverable for the configured retention period or for a default period of 90 days. It accepts values between 7 and 90."
},
"enablePurgeProtection": {
"type": "boolean",
"default": true,
"description": "Property specifying whether protection against purge is enabled for this managed HSM pool. Setting this property to true activates protection against purge for this managed HSM pool and its content - only the Managed HSM service may initiate a hard, irrecoverable deletion. The setting is effective only if soft delete is also enabled. Enabling this functionality is irreversible."
"description": "Property specifying whether protection against purge is enabled for this managed HSM pool. Setting this property to true activates protection against purge for this managed HSM pool and its content - only the Managed HSM service may initiate a hard, irrecoverable deletion. Enabling this functionality is irreversible."
},
"createMode": {
"type": "string",
Expand Down Expand Up @@ -962,11 +963,12 @@
"description": "List of private endpoint connections associated with the managed hsm pool."
},
"publicNetworkAccess": {
"description": "Control permission for data plane traffic coming from public networks while private endpoint is enabled.",
"description": "Control permission to the managed HSM from public networks.",
"enum": [
"Enabled",
"Disabled"
],
"default": "Enabled",
"type": "string",
"x-ms-enum": {
"name": "PublicNetworkAccess",
Expand Down
12 changes: 7 additions & 5 deletions ...n/keyvault/resource-manager/Microsoft.KeyVault/preview/2022-02-01-preview/managedHsm.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -862,7 +862,8 @@
"description": "SKU of the managed HSM Pool",
"enum": [
"Standard_B1",
"Custom_B32"
"Custom_B32",
"Custom_B6"
],
"x-ms-enum": {
"name": "ManagedHsmSkuName",
Expand Down Expand Up @@ -899,18 +900,18 @@
"enableSoftDelete": {
"type": "boolean",
"default": true,
"description": "Property to specify whether the 'soft delete' functionality is enabled for this managed HSM pool. If it's not set to any value(true or false) when creating new managed HSM pool, it will be set to true by default. Once set to true, it cannot be reverted to false."
"description": "Property to specify whether the 'soft delete' functionality is enabled for this managed HSM pool. Soft delete is enabled by default for all managed HSMs and is immutable."
},
"softDeleteRetentionInDays": {
"type": "integer",
"format": "int32",
"default": 90,
"description": "softDelete data retention days. It accepts >=7 and <=90."
"description": "Soft deleted data retention days. When you delete an HSM or a key, it will remain recoverable for the configured retention period or for a default period of 90 days. It accepts values between 7 and 90."
},
"enablePurgeProtection": {
"type": "boolean",
"default": true,
"description": "Property specifying whether protection against purge is enabled for this managed HSM pool. Setting this property to true activates protection against purge for this managed HSM pool and its content - only the Managed HSM service may initiate a hard, irrecoverable deletion. The setting is effective only if soft delete is also enabled. Enabling this functionality is irreversible."
"description": "Property specifying whether protection against purge is enabled for this managed HSM pool. Setting this property to true activates protection against purge for this managed HSM pool and its content - only the Managed HSM service may initiate a hard, irrecoverable deletion. Enabling this functionality is irreversible."
},
"createMode": {
"type": "string",
Expand Down Expand Up @@ -1009,11 +1010,12 @@
"description": "List of private endpoint connections associated with the managed hsm pool."
},
"publicNetworkAccess": {
"description": "Control permission for data plane traffic coming from public networks while private endpoint is enabled.",
"description": "Control permission to the managed HSM from public networks.",
"enum": [
"Enabled",
"Disabled"
],
"default": "Enabled",
"type": "string",
"x-ms-enum": {
"name": "PublicNetworkAccess",
Expand Down
12 changes: 7 additions & 5 deletions specification/keyvault/resource-manager/Microsoft.KeyVault/stable/2021-10-01/managedHsm.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -816,7 +816,8 @@
"description": "SKU of the managed HSM Pool",
"enum": [
"Standard_B1",
"Custom_B32"
"Custom_B32",
"Custom_B6"
],
"x-ms-enum": {
"name": "ManagedHsmSkuName",
Expand Down Expand Up @@ -853,18 +854,18 @@
"enableSoftDelete": {
"type": "boolean",
"default": true,
"description": "Property to specify whether the 'soft delete' functionality is enabled for this managed HSM pool. If it's not set to any value(true or false) when creating new managed HSM pool, it will be set to true by default. Once set to true, it cannot be reverted to false."
"description": "Property to specify whether the 'soft delete' functionality is enabled for this managed HSM pool. Soft delete is enabled by default for all managed HSMs and is immutable."
},
"softDeleteRetentionInDays": {
"type": "integer",
"format": "int32",
"default": 90,
"description": "softDelete data retention days. It accepts >=7 and <=90."
"description": "Soft deleted data retention days. When you delete an HSM or a key, it will remain recoverable for the configured retention period or for a default period of 90 days. It accepts values between 7 and 90."
},
"enablePurgeProtection": {
"type": "boolean",
"default": true,
"description": "Property specifying whether protection against purge is enabled for this managed HSM pool. Setting this property to true activates protection against purge for this managed HSM pool and its content - only the Managed HSM service may initiate a hard, irrecoverable deletion. The setting is effective only if soft delete is also enabled. Enabling this functionality is irreversible."
"description": "Property specifying whether protection against purge is enabled for this managed HSM pool. Setting this property to true activates protection against purge for this managed HSM pool and its content - only the Managed HSM service may initiate a hard, irrecoverable deletion. Enabling this functionality is irreversible."
},
"createMode": {
"type": "string",
Expand Down Expand Up @@ -963,11 +964,12 @@
"description": "List of private endpoint connections associated with the managed hsm pool."
},
"publicNetworkAccess": {
"description": "Control permission for data plane traffic coming from public networks while private endpoint is enabled.",
"description": "Control permission to the managed HSM from public networks.",
"enum": [
"Enabled",
"Disabled"
],
"default": "Enabled",
"type": "string",
"x-ms-enum": {
"name": "PublicNetworkAccess",
Expand Down
12 changes: 7 additions & 5 deletions specification/keyvault/resource-manager/Microsoft.KeyVault/stable/2022-07-01/managedHsm.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -862,7 +862,8 @@
"description": "SKU of the managed HSM Pool",
"enum": [
"Standard_B1",
"Custom_B32"
"Custom_B32",
"Custom_B6"
],
"x-ms-enum": {
"name": "ManagedHsmSkuName",
Expand Down Expand Up @@ -899,18 +900,18 @@
"enableSoftDelete": {
"type": "boolean",
"default": true,
"description": "Property to specify whether the 'soft delete' functionality is enabled for this managed HSM pool. If it's not set to any value(true or false) when creating new managed HSM pool, it will be set to true by default. Once set to true, it cannot be reverted to false."
"description": "Property to specify whether the 'soft delete' functionality is enabled for this managed HSM pool. Soft delete is enabled by default for all managed HSMs and is immutable."
},
"softDeleteRetentionInDays": {
"type": "integer",
"format": "int32",
"default": 90,
"description": "softDelete data retention days. It accepts >=7 and <=90."
"description": "Soft deleted data retention days. When you delete an HSM or a key, it will remain recoverable for the configured retention period or for a default period of 90 days. It accepts values between 7 and 90."
},
"enablePurgeProtection": {
"type": "boolean",
"default": true,
"description": "Property specifying whether protection against purge is enabled for this managed HSM pool. Setting this property to true activates protection against purge for this managed HSM pool and its content - only the Managed HSM service may initiate a hard, irrecoverable deletion. The setting is effective only if soft delete is also enabled. Enabling this functionality is irreversible."
"description": "Property specifying whether protection against purge is enabled for this managed HSM pool. Setting this property to true activates protection against purge for this managed HSM pool and its content - only the Managed HSM service may initiate a hard, irrecoverable deletion. Enabling this functionality is irreversible."
},
"createMode": {
"type": "string",
Expand Down Expand Up @@ -1009,11 +1010,12 @@
"description": "List of private endpoint connections associated with the managed hsm pool."
},
"publicNetworkAccess": {
"description": "Control permission for data plane traffic coming from public networks while private endpoint is enabled.",
"description": "Control permission to the managed HSM from public networks.",
"enum": [
"Enabled",
"Disabled"
],
"default": "Enabled",
"type": "string",
"x-ms-enum": {
"name": "PublicNetworkAccess",
Expand Down
Loading

0 comments on commit 33f06ff

Please sign in to comment.