Skip to content

Commit

Permalink
Use "5Qi" as the schema to define Default QoS Flow 5G QoS Indicator v…
Browse files Browse the repository at this point in the history
…alue. (#9817)

On SIM policy we use the 'Default QoS Flow 5G QoS Indicator value', we were incorrectly using the '5QiPriorityLevel' schema (which is an interger between 1 and 127 as per https://github.com/Azure/azure-rest-api-specs-pr/blob/RPSaaSMaster/specification/mobilenetwork/resource-manager/Microsoft.MobileNetwork/stable/2022-11-01/ts29571.json#L117. We should have used 5Qi - an integer between 0 and 255. We made a mistake when we first p ut this in and have no spotted it.

Even though changing the allowed values for a property is a breaking change, we think this is acceptable because:
1) This is our first stable API, there is no pre-existing stable API we need to be back-compatible with
2) 2022-04-01-preview to 2022-11-01 already contains breaking changes that we have discussed in https://eng.ms/docs/strategic-missions-and-technologies/strategic-missions-and-technologies-organization/azure-for-operators/packet-core/private-mobile-network/azure-private-5g-core/cross-team/releases/2022-11-01-arm-api/back-compatibility
3) We have one customer who may need to use values 128-255 -> if that customer does PUTs with the 2022-11-01 API then a GET with the 2022-04-01, it will fail, while this is sad, we think this is an acceptable risk.
  • Loading branch information
andrew-lee-1089 authored and Andrew Lee committed Dec 5, 2022
1 parent 5741e1a commit 21a212f
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,7 @@
},
"5qi": {
"description": "Default QoS Flow 5G QoS Indicator value. The 5QI identifies a specific QoS forwarding treatment to be provided to a flow. This must not be a standardized 5QI value corresponding to a GBR (guaranteed bit rate) QoS Flow. The illegal GBR 5QI values are: 1, 2, 3, 4, 65, 66, 67, 71, 72, 73, 74, 75, 76, 82, 83, 84, and 85. See 3GPP TS23.501 section 5.7.2.1 for a full description of the 5QI parameter, and table 5.7.4-1 for the definition of which are the GBR 5QI values.",
"$ref": "./ts29571.json#/definitions/5QiPriorityLevel",
"$ref": "./ts29571.json#/definitions/5Qi",
"default": 9
},
"allocationAndRetentionPriorityLevel": {
Expand Down

0 comments on commit 21a212f

Please sign in to comment.