Skip to content

Commit

Permalink
Initial network error fixes and suppressions
Browse files Browse the repository at this point in the history
  • Loading branch information
EvgenyAgafonchikov committed May 10, 2018
1 parent b3f5a7a commit 202886c
Show file tree
Hide file tree
Showing 16 changed files with 79 additions and 60 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,10 @@
"https"
],
"consumes": [
"application/json",
"text/json"
"application/json"
],
"produces": [
"application/json",
"text/json"
"application/json"
],
"security": [
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,10 @@
"https"
],
"consumes": [
"application/json",
"text/json"
"application/json"
],
"produces": [
"application/json",
"text/json"
"application/json"
],
"security": [
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,10 @@
"https"
],
"consumes": [
"application/json",
"text/json"
"application/json"
],
"produces": [
"application/json",
"text/json"
"application/json"
],
"security": [
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,10 @@
"https"
],
"consumes": [
"application/json",
"text/json"
"application/json"
],
"produces": [
"application/json",
"text/json"
"application/json"
],
"security": [
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,10 @@
"https"
],
"consumes": [
"application/json",
"text/json"
"application/json"
],
"produces": [
"application/json",
"text/json"
"application/json"
],
"security": [
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,10 @@
"https"
],
"consumes": [
"application/json",
"text/json"
"application/json"
],
"produces": [
"application/json",
"text/json"
"application/json"
],
"security": [
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,10 @@
"https"
],
"consumes": [
"application/json",
"text/json"
"application/json"
],
"produces": [
"application/json",
"text/json"
"application/json"
],
"security": [
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,10 @@
"https"
],
"consumes": [
"application/json",
"text/json"
"application/json"
],
"produces": [
"application/json",
"text/json"
"application/json"
],
"security": [
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,10 @@
"https"
],
"consumes": [
"application/json",
"text/json"
"application/json"
],
"produces": [
"application/json",
"text/json"
"application/json"
],
"security": [
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,10 @@
"https"
],
"consumes": [
"application/json",
"text/json"
"application/json"
],
"produces": [
"application/json",
"text/json"
"application/json"
],
"security": [
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,10 @@
"https"
],
"consumes": [
"application/json",
"text/json"
"application/json"
],
"produces": [
"application/json",
"text/json"
"application/json"
],
"security": [
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,10 @@
"https"
],
"consumes": [
"application/json",
"text/json"
"application/json"
],
"produces": [
"application/json",
"text/json"
"application/json"
],
"security": [
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,10 @@
"https"
],
"consumes": [
"application/json",
"text/json"
"application/json"
],
"produces": [
"application/json",
"text/json"
"application/json"
],
"security": [
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,10 @@
"https"
],
"consumes": [
"application/json",
"text/json"
"application/json"
],
"produces": [
"application/json",
"text/json"
"application/json"
],
"security": [
{
Expand Down Expand Up @@ -395,6 +393,13 @@
"required": true,
"type": "string",
"description": "The subscription credentials which uniquely identify the Microsoft Azure subscription. The subscription ID forms part of the URI for every service call."
},
"ApiVersionParameter": {
"name": "api-version",
"in": "query",
"required": true,
"type": "string",
"description": "Client API version."
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,10 @@
"https"
],
"consumes": [
"application/json",
"text/json"
"application/json"
],
"produces": [
"application/json",
"text/json"
"application/json"
],
"security": [
{
Expand Down Expand Up @@ -256,6 +254,13 @@
"required": true,
"type": "string",
"description": "The subscription credentials which uniquely identify the Microsoft Azure subscription. The subscription ID forms part of the URI for every service call."
},
"ApiVersionParameter": {
"name": "api-version",
"in": "query",
"required": true,
"type": "string",
"description": "Client API version."
}
}
}
35 changes: 35 additions & 0 deletions specification/network/resource-manager/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -410,6 +410,41 @@ input-file:
- Microsoft.Network/preview/2015-05-01-preview/network.json
```

## Suppression
``` yaml
directive:
- suppress: RequiredPropertiesMissingInResourceModel
reason: name, id and type properties are inherited from the upper level
- suppress: TrackedResourceListByImmediateParent
reason: Another list APIs naming approach is used over the specs
- suppress: EnumInsteadOfBoolean
reason: Booleans are used by networking APIs
- suppress: GetInOperationName
where: $.paths["/subscriptions/{subscriptionId}/providers/Microsoft.Network/locations/{location}/CheckDnsNameAvailability"].get.operationId
reason: Customized verb is used for API
- suppress: GetInOperationName
where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualNetworks/{virtualNetworkName}/CheckIPAddressAvailability"].get.operationId
reason: Customized verb is used for API
- suppress: PutInOperationName
where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/connections/{virtualNetworkGatewayConnectionName}/sharedkey"].put.operationId
reason: Customized verb is used for API
- suppress: PostOperationIdContainsUrlVerb
from: networkWatcher.json
reason: Customized verbs are used for API
- suppress: PostOperationIdContainsUrlVerb
from: expressRouteCircuit.json
reason: Customized verbs are used for API
- suppress: PostOperationIdContainsUrlVerb
from: expressRouteCrossConnection.json
reason: Customized verbs are used for API
- suppress: OperationIdNounVerb
from: vmssPublicIpAddress.json
reason: VMSS specs have custom naming
- suppress: OperationIdNounVerb
from: vmssNetworkInterface.json
reason: VMSS specs have custom naming
```

---
# Code Generation

Expand Down

0 comments on commit 202886c

Please sign in to comment.