[ReleasePR eventhub] Adding ApplicationGroup to EventHub Namespace #2358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding ApplicationGroup to EventHub Namespace (#17430) * Copying latest version from stable * ApplicationGroup added * Fix validations * Fix validations * Validations fix continued * Validations fix continued * Fix contd. * Fix validations contd. * Fix contd. * Fix validations contd. * Fix contd. * Fix validations * Fix contd. * Fix validations contd. * Validations fix continued * PR comments addressed * Minor description change * Reset previous 2 commits * PR comments addressed * Added x-ms-identifier in array for satisfying newly introduced pipeline. * Changing name field * Contract changes * PublicNetworkAccess Enum value addition for NSP * Nsp public APIs * NSP Lint fix * Lint Update * Nsp Lint Update * Nsp Lint Update * Moving NSP to correct API Version * Move NSP examples to correct API Version * Move NSP examples to correct API Version * Moving New update of PublicNetworkAccess to correct API Version * Nsp Examples fix * Nsp Examples fix * Nsp Examples fix * Nsp Examples fix * Nsp Examples fix * Spell Fix * Nsp AccessRules update * Swagger changes for TLS Picker * Removing error response from the v1 definition * Adding error response from the v1 definition * NSP State enum update * changed to use ErrorResponse from v2 * NSP Lint Fixes * NSP Lint Fixes * NSP Example update * Changing data model definition * Update examples * Fix style * Fix style contd. * Test ApplicationGroupPolicy * Test ApplicationGroupPolicy * Test ApplicationGroupPolicy * Test ApplicationGroupPolicy * Update Policy type * Test ApplicationGroupPolicy * Fix Pipeline checks * Test ApplicationGroupPolicy * Test ApplicationGroupPolicy * PR comments addressed * Fixing checks * Addressed comments * TLS Picker updates - Review feedback * NSP update * NSP update * NSP update * NSP update * Address PR comments * Fix checks * Revert SASKeyName change * Added required param * Making model validation fix * updated readme.md files * corrected API version in python * Update readme.md * Update readme.python.md * corrected example * adding publicNetworkAccess to network * added SecuredByPerimeter to PublicNetworkAccess enum * Addition of AccessMode Property in NetworkSecurityPerimeterConfiguration * added supportsScaling to clusters * Update specification/eventhub/resource-manager/readme.python.md implementing suggestion Co-authored-by: Jiefeng Chen <[email protected]> * Update specification/eventhub/resource-manager/readme.python.md suggestion committed Co-authored-by: Jiefeng Chen <[email protected]> * spell check fix * api tag fix in readme.go.md Co-authored-by: Sayan Ghosh <[email protected]> Co-authored-by: davadhani <[email protected]> Co-authored-by: charvakpatel <[email protected]> Co-authored-by: Manoj Prasad <[email protected]> Co-authored-by: Ajit Navasare (MINDTREE LIMITED) <[email protected]> Co-authored-by: Jiefeng Chen <[email protected]>
ghost
added
the
ghost
approved these changes
May 5, 2022
There was a problem hiding this comment.
This PR has been auto-approved by the @msftbot for the azure-resource-manager-schemas repo.
|
Hello @msftbot[bot]! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 1 minute. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
25 tasks
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create to sync Azure/azure-rest-api-specs#17430
ReCreate this PR