Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tooling documentation for Tools.Common, StaticAnalysis, and CI Filter #9943

Merged
merged 2 commits into from
Sep 19, 2019

Conversation

cormacpayne
Copy link
Member

@cormacpayne cormacpayne commented Aug 30, 2019

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@cormacpayne
Copy link
Member Author

@markcowl @MiYanni @niander would you mind taking a look and reviewing this? Let me know if there's anything I missed for any of these documents.

CC: @erich-wang @isra-fel @dolauli please have a look as well and let me know if you have any questions about the documents.

niander
niander previously approved these changes Sep 5, 2019
@isra-fel
Copy link
Member

@msJinLei @wyunchi-ms please also take a look at this, thanks

MiYanni
MiYanni previously approved these changes Sep 12, 2019
Copy link
Member

@markcowl markcowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor correction, otherwise, this is fantastic documentation

@@ -0,0 +1,81 @@
## CI Filter

### What is the CI Filter?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I didn't even think about this, but this is important to know.

documentation/tooling/ci-filter.md Outdated Show resolved Hide resolved
@cormacpayne cormacpayne dismissed stale reviews from MiYanni and niander via 96210ce September 13, 2019 15:31
@cormacpayne cormacpayne removed their assignment Sep 13, 2019
@erich-wang erich-wang merged commit 378abab into Azure:master Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants