Restructure Analysis Services dataplane cmdlets to use Az module login. #8900

pychuang · 2019-03-29T21:19:40Z

Description

Refactored dataplane cmdlets to inherit from a common Analysis Services cmdlet base.
Added classes to use authentication credentials from the Az module.
Made Add-AzureASAccount a wrapper of Connect-AzAccount to avoid a breaking change. Add-AzureASAccount is deprecated.
Removed the implementation of classes used to save Analysis Services independent credentials. Several classes remain existing to avoid a breaking change.
Updated Add-AzEnvironment and Set-AzEnvironment to accept AzureAnalysisServicesEndpointResourceId to allow test environment log in.

Checklist

I have read the Submitting Changes section of CONTRIBUTING.md
The title of the PR is clear and informative
The appropriate change log has been updated
The PR does not introduce breaking changes
If applicable, the changes made in the PR have proper test coverage
For public API changes to cmdlets:
- the changes have gone through a cmdlet design review (Microsoft internal partners only)
- the cmdlet markdown files were generated using the platyPS module

Remove username/password authentication. Get login credentials from Az module, instead of AddAzureASAccount. This is currently a work in progress.

-pt2 resolving conflicts # Conflicts: # src/AnalysisServices/AnalysisServices.Dataplane/Commands/AddAzureASAccount.cs # src/AnalysisServices/AnalysisServices.Dataplane/Models/ASAzureContext.cs # src/AnalysisServices/AnalysisServices.Dataplane/Models/AsAzureAccount.cs # src/AnalysisServices/AnalysisServices.Dataplane/Models/AsAzureAuthenticationProvider.cs # src/AnalysisServices/AnalysisServices.Dataplane/Models/AsAzureClientSession.cs # src/AnalysisServices/AnalysisServices.Dataplane/Models/AsAzureEndpoints.cs # src/AnalysisServices/AnalysisServices.Dataplane/Models/AsAzureProfile.cs # src/AnalysisServices/AnalysisServices.Test/InMemoryTests/AddAzureASAccountTests.cs # src/ResourceManager/AnalysisServices/Commands.AnalysisServices.Dataplane/Models/AsAzureAccount.cs

Remove unnecessary BeginProcessing() methods in child classes.

…o longer a partial class. Changed organizational #region name to include CallGet and CallPost method overloads. Remove unused code in SendRequestAsync().

Add null check for Instance field.

…it is not used in any other derived classes.

Remove unnecessary BaseUri public set in AsAzureDataplaneClient. Remove unused argument parameterizedBaseUri in method AsAzureDataplaneCmdletBase.CreateAsAzureDataplaneClient().

It is no longer needed, since the cmdlet is now called with the full server name. Move public field DefaultRetryIntervalForPolling below private fields.

…StyleCop guidelines.

# Conflicts: # src/AnalysisServices/AnalysisServices.Dataplane/Commands/AddAzureASAccount.cs

Added aliases to ConnectAzureRmAccount.cs to replace AddAzureASAccount.cs. Fixed documentation to include parameters which were moved to a base class.

…esEndpoint Since the Endpoint Suffix is not used for anything else, it can be ommitted. This will also help simplify the code paths.

…ment cmdlets

src/AnalysisServices/AnalysisServices.Dataplane/Commands/AddAzureASAccount.cs

pychuang · 2019-04-02T20:27:28Z

Need to test the cmdlets with ":rw" in instance name

pychuang · 2019-04-02T20:51:02Z

Need to test the cmdlets with ":rw" in instance name

Tested. Sync works.

markcowl

Just one minor change, otherwise lgtm

src/Accounts/Accounts/Environment/AddAzureRMEnvironment.cs

gapreste added 29 commits December 21, 2018 12:01

Use login credentials from new Az module.

881741d

Remove username/password authentication. Get login credentials from Az module, instead of AddAzureASAccount. This is currently a work in progress.

Merge branch 'master' into gapreste/use-new-az-module-credentials

81ddfd8

Change export log file endpoint.

401ac09

Merge with master pt1

50741a1

Move Instance field to dataplane cmdlet base.

a82b902

Remove unnecessary BeginProcessing() methods in child classes.

Remove unnecessary implementation of IAsAzureHttpClient

d9e25d5

Removed 'partial' keyword and related documentation because this is n…

817691c

…o longer a partial class. Changed organizational #region name to include CallGet and CallPost method overloads. Remove unused code in SendRequestAsync().

Remove unneccessary constructors from cmdlet classes.

5303dd4

Add null check for Instance field.

Move common code in cmdlet classes to base class.

9709ffa

Rewrite IAsAzureHttpClient to be more relevant to new structure.

2b61fbf

Change dataplane client property and field type to interface.

e68bea5

Remove unused TokenCacheItemProvider.

2dbc31b

Rewrite InMemoryTests to fit new code.

b380946

Move common authentication test code into its own method.

d2768ad

Add cmdlet markdown help files generated by platyPS.

7845fc7

Move ClusterResolve() from base class to Sync-AzureASInstance, since …

4df833d

…it is not used in any other derived classes.

Add documentation.

5a1f515

Remove unnecessary BaseUri public set in AsAzureDataplaneClient. Remove unused argument parameterizedBaseUri in method AsAzureDataplaneCmdletBase.CreateAsAzureDataplaneClient().

Undo changes in ASCII art in generated help markdown files.

44e3dfa

Change null context error to throw a more appropriate exception.

8af4d33

Add documentation to dataplane InMemoryTests.

7cfaec1

Update changelog

d90d9af

Remove ClusterResolve method and ClusterResolveResult.

5f48938

It is no longer needed, since the cmdlet is now called with the full server name. Move public field DefaultRetryIntervalForPolling below private fields.

Rearrange fields, properties, constructors and methods, according to …

ffa1491

…StyleCop guidelines.

Merge branch 'master' into gapreste/use-new-az-module-credentials

64acd4b

# Conflicts: # src/AnalysisServices/AnalysisServices.Dataplane/Commands/AddAzureASAccount.cs

Remove breaking change and fix documentation.

ce946c4

Added aliases to ConnectAzureRmAccount.cs to replace AddAzureASAccount.cs. Fixed documentation to include parameters which were moved to a base class.

Update ChangeLog

e518714

Use ResourceId constant instead of Suffix constant for AnalysisServic…

501214b

…esEndpoint Since the Endpoint Suffix is not used for anything else, it can be ommitted. This will also help simplify the code paths.

Add argument AnalysisServicesEndpointResourceId to Add- Set-AzEnviron…

818a6aa

…ment cmdlets

azuresdkci added the needs-review label Mar 29, 2019

Po-Yu Chuang added 2 commits April 1, 2019 15:41

AddAzureASAccount: wrapper

f6e3b0f

AddAzureASAccount: real wrapper

1a697e3

gnair-ms reviewed Apr 2, 2019

View reviewed changes

src/AnalysisServices/AnalysisServices.Dataplane/Commands/AddAzureASAccount.cs Outdated Show resolved Hide resolved

Po-Yu Chuang added 3 commits April 1, 2019 19:26

trying to fix static analysis failures

0e05bcc

AnalysisServices.Dataplane.csproj: remove reference to Accounts

25c4c5c

bring several classes back to pass static analysis

a883b87

cormacpayne assigned markcowl Apr 2, 2019

Po-Yu Chuang and others added 4 commits April 2, 2019 10:42

update help

5e0ca7e

update help of Accounts module

e3aa8c3

simplify sync API return status check

5e99a59

simplify sync response check

8124c34

pychuang closed this Apr 2, 2019

pychuang reopened this Apr 2, 2019

markcowl requested changes Apr 2, 2019

View reviewed changes

src/Accounts/Accounts/Environment/AddAzureRMEnvironment.cs Show resolved Hide resolved

markcowl assigned pychuang and unassigned markcowl Apr 2, 2019

markcowl changed the base branch from master to release-2019-04-09 April 2, 2019 23:28

markcowl added needs-revision and removed needs-review labels Apr 2, 2019

Po-Yu Chuang and others added 2 commits April 2, 2019 16:39

update change logs

3f2fb30

Merge branch 'release-2019-04-09' into gabriel-az-restructure

3363792

markcowl approved these changes Apr 2, 2019

View reviewed changes

pychuang assigned markcowl Apr 2, 2019

markcowl added Waiting for CI and removed needs-revision labels Apr 2, 2019

pychuang removed their assignment Apr 2, 2019

markcowl added the Sprint Candidate label Apr 2, 2019

cormacpayne merged commit 8f5c01e into Azure:release-2019-04-09 Apr 3, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Restructure Analysis Services dataplane cmdlets to use Az module login. #8900

Restructure Analysis Services dataplane cmdlets to use Az module login. #8900

pychuang commented Mar 29, 2019 •

edited

Loading

pychuang commented Apr 2, 2019

pychuang commented Apr 2, 2019

markcowl left a comment

Restructure Analysis Services dataplane cmdlets to use Az module login. #8900

Restructure Analysis Services dataplane cmdlets to use Az module login. #8900

Conversation

pychuang commented Mar 29, 2019 • edited Loading

Description

Checklist

pychuang commented Apr 2, 2019

pychuang commented Apr 2, 2019

markcowl left a comment

Choose a reason for hiding this comment

pychuang commented Mar 29, 2019 •

edited

Loading