Fix for KeyVault issue 5159 and tests #6357

maddieclayton · 2018-06-01T02:30:29Z

Description

I have read the Submitting Changes section of CONTRIBUTING.md
The title of the PR is clear and informative
The appropriate change log has been updated
The PR does not introduce breaking changes
If applicable, the changes made in the PR have proper test coverage
For public API changes to cmdlets:
- the changes have gone through a cmdlet design review
- the cmdlet markdown files were generated using the platyPS module

MiYanni · 2018-06-06T01:29:45Z

@maddieclayton You have merge conflicts that need to be resolved.

schaabs

LGTM

maddieclayton added 5 commits May 29, 2018 15:55

initial changes

6b8bf83

fix

1bc1189

fix test

ca96ad7

more test fixes

223c09f

more tests

cfcb178

azuresdkci added the needs-review label Jun 1, 2018

maddieclayton assigned cormacpayne, RandalliLama and schaabs Jun 1, 2018

maddieclayton added the Merge Conflicts label Jun 6, 2018

cormacpayne added needs-revision and removed needs-review labels Jun 6, 2018

cormacpayne assigned maddieclayton and unassigned RandalliLama, cormacpayne and schaabs Jun 6, 2018

fix tests

18b0f50

maddieclayton added needs-review and removed Merge Conflicts needs-revision labels Jun 7, 2018

maddieclayton assigned RandalliLama and cormacpayne and unassigned maddieclayton Jun 7, 2018

schaabs approved these changes Jun 8, 2018

View reviewed changes

cormacpayne approved these changes Jun 8, 2018

View reviewed changes

cormacpayne removed their assignment Jun 8, 2018

maddieclayton merged commit dc4027b into Azure:preview Jun 8, 2018

maddieclayton deleted the kvcall branch June 8, 2018 20:31