update roledefinition get custom roles to use filter #5664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@darshanhs90 Please let me know when the SDK has been merged and you are ready for us to take a look at this PR. |
|
@darshanhs90 looks like the SDK PR was merged -- was this new SDK version published to NuGet? |
|
@cormacpayne Yes it was published on friday,Will update this PR today |
darshanhs90
changed the title
darshanhs90
added
needs-review
and removed
Do Not Merge 🚫
Merge Conflicts
needs-revision
labels
cormacpayne
suggested changes
Mar 13, 2018
|
|
||
| # Test | ||
| [Microsoft.Azure.Commands.Resources.Models.Authorization.AuthorizationClient]::RoleAssignmentNames.Enqueue("2fec1202-19ad-4c8b-b461-6031a1b5dce6") | ||
| $newAssignment = New-AzureRmRoleAssignment ` |
There was a problem hiding this comment.
@darshanhs90 why is this command being removed from this test?
There was a problem hiding this comment.
@cormacpayne it was a redundant thing added in the test,as you can see earlier in the same test,we are creating a roleassignment, so that would be sufficient to validate the scenario for this test.
There was a problem hiding this comment.
my bad,thought the earlier create was also for a roleassignment, will revert it
cormacpayne
approved these changes
Mar 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
waiting for Azure/azure-sdk-for-net#4102
and #5646
update roledefinition get custom roles to use filter[donot merge]
waiting for sdk-for-net pr to get completed
Description
Checklist
CONTRIBUTING.mdplatyPSmodule