-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NRP PS commandlet changes as per NRP Brooklyn APIs changes #528
Conversation
…in, skipping for now. Will send another PR with recorded tests in some time.
Hi @Nilambari, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
TTYL, AZPRBOT; |
Added recorded tests back. |
# Set/Update VirtualNetworkGatewayConnection | ||
$expected.Location = $location | ||
$expected.VirtualNetworkGateway1.Location = $location | ||
$expected.LocalNetworkGateway2.Location = $location |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix indentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done,
Please include changes to changelog.txt file in your PR. |
Please fix indentation in several files in this PR. too many places to mention them one by one. |
1. Command New-AzureLocalNetworkGateway parameter name change 2. Command Reset-AzureLocalNetworkGateway renamed to Set-AzureLocalNetworkGateway, added new parameter 3. Resource: VirtualNetworkGateway parameter changes 4. Command New-AzureVirtualNetworkGateway parameter changes 5. Removed command Resize-AzureVirtualNetworkGateway 6. Command Reset-AzureVirtualNetworkGatewayConnection renamed to Set-AzureVirtualNetworkGatewayConnection
Not sure about changlog.txt file. sharing overall changes in this PR:-
|
Added PS changes details in changeLog.txt file. Can you Please accept this PR? Thanks a lot! |
NRP PS commandlet changes as per NRP Brooklyn APIs changes
Will send another PR in some time with recorded tests. Can you Please approve this PR as without this merge its blocking for other team members to send their changes' PR. Thanks!