Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NRP PS commandlet changes as per NRP Brooklyn APIs changes #528

Merged
merged 9 commits into from
Jun 21, 2015

Conversation

Nilambari
Copy link
Member

Will send another PR in some time with recorded tests. Can you Please approve this PR as without this merge its blocking for other team members to send their changes' PR. Thanks!

@azurecla
Copy link

Hi @Nilambari, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (nilamd). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@Nilambari
Copy link
Member Author

Added recorded tests back.

# Set/Update VirtualNetworkGatewayConnection
$expected.Location = $location
$expected.VirtualNetworkGateway1.Location = $location
$expected.LocalNetworkGateway2.Location = $location
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix indentation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done,

@hovsepm
Copy link
Contributor

hovsepm commented Jun 20, 2015

Please include changes to changelog.txt file in your PR.

@hovsepm
Copy link
Contributor

hovsepm commented Jun 20, 2015

Please fix indentation in several files in this PR. too many places to mention them one by one.

unknown added 2 commits June 20, 2015 02:04
1. Command New-AzureLocalNetworkGateway parameter name change
2. Command Reset-AzureLocalNetworkGateway renamed to Set-AzureLocalNetworkGateway, added new parameter
3. Resource: VirtualNetworkGateway parameter changes
4. Command New-AzureVirtualNetworkGateway parameter changes
5. Removed command Resize-AzureVirtualNetworkGateway
6. Command Reset-AzureVirtualNetworkGatewayConnection renamed to Set-AzureVirtualNetworkGatewayConnection
@Nilambari
Copy link
Member Author

Not sure about changlog.txt file. sharing overall changes in this PR:-
PS command changes as per NRP Brooklyn APIs changes:-

  1. Command New-AzureLocalNetworkGateway parameter name change
  2. Command Reset-AzureLocalNetworkGateway renamed to Set-AzureLocalNetworkGateway, added new parameter
  3. Resource: VirtualNetworkGateway parameter changes
  4. Command New-AzureVirtualNetworkGateway parameter changes
  5. Removed command Resize-AzureVirtualNetworkGateway
  6. Command Reset-AzureVirtualNetworkGatewayConnection renamed to Set-AzureVirtualNetworkGatewayConnection

@Nilambari
Copy link
Member Author

Added PS changes details in changeLog.txt file. Can you Please accept this PR? Thanks a lot!

hovsepm pushed a commit that referenced this pull request Jun 21, 2015
NRP PS commandlet changes as per NRP Brooklyn APIs changes
@hovsepm hovsepm merged commit 65c1b07 into Azure:dev Jun 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants