Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some test fixes for AzureRT tests. #465

Merged
merged 4 commits into from
Jun 6, 2015
Merged

Some test fixes for AzureRT tests. #465

merged 4 commits into from
Jun 6, 2015

Conversation

hyonholee
Copy link
Contributor

No description provided.

@azurecla
Copy link

azurecla commented Jun 4, 2015

Hi @hyonholee, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (hylee). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@huangpf
Copy link
Contributor

huangpf commented Jun 5, 2015

LGTM.

@@ -72,7 +74,9 @@ public void CreateReservedIPThenPaaSVM()
string reservedIpLabel1 = Utilities.GetUniqueShortName("ResrvdIPLbl", 5);
string reservedIpLabel2 = Utilities.GetUniqueShortName("ResrvdIPLbl", 5);
string dnsName = Utilities.GetUniqueShortName("Dns");
string deploymentName = Utilities.GetUniqueShortName("Depl");
string deploymentName1 = Utilities.GetUniqueShortName("Depl");
string deploymentName2 = Utilities.GetUniqueShortName("Depl");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's better to also have a different prefix, i.e. Dep2, so that it's 100% unique, :-)

ogail added a commit that referenced this pull request Jun 6, 2015
Some test fixes for AzureRT tests.
@ogail ogail merged commit b690811 into Azure:dev Jun 6, 2015
huangpf added a commit to AzureRT/azure-powershell that referenced this pull request Mar 12, 2016
HPF PR: dev <- Azure:dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants