Update CMS Version to 1 for CodeSigningCIPolicySigning #26993
Merged
+67
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️Az.Accounts
|
| Type | Title | Current Coverage | Description |
|---|---|---|---|
| Test Coverage Less Than 50% | 0.00 % | Test coverage for the module cannot be lower than 50%. |
⚠️ - MacOS
| Type | Title | Current Coverage | Description |
|---|---|---|---|
| Test Coverage Less Than 50% | 0.00% | Test coverage for the module cannot be lower than 50%. |
⚠️ PowerShell Core - Windows
| Type | Title | Current Coverage | Description |
|---|---|---|---|
| Test Coverage Less Than 50% | 0.00% | Test coverage for the module cannot be lower than 50%. |
⚠️ Windows PowerShell - Windows
| Type | Title | Current Coverage | Description |
|---|---|---|---|
| Test Coverage Less Than 50% | 0.00% | Test coverage for the module cannot be lower than 50%. |
|
Thank you for your contribution TechyDhaval! We will review the pull request and get back to you soon. |
Jaxelr
reviewed
Jan 10, 2025
TechyDhaval
force-pushed
the
dhjoshi/CMSVersionUpdate
branch
from
7ff9b7d to
a483492
Compare
|
@TechyDhaval LGTM. |
TechyDhaval
commented
Jan 28, 2025
Jaxelr
approved these changes
Jan 28, 2025
|
LGTM |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Hi @TechyDhaval, please update |
|
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
|
here is the testing results. We need to parse ASN.1 to verify the result. We have tried different sizes ci policy file for signing and tested it with Azure VM |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
NoriZC
approved these changes
Feb 6, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Feb 6, 2025
* Update CMS Version to 1 for CodeSigningCIPolicySigning * Set CMSVersion to 1 always * updated release notes --------- Co-authored-by: dhjoshi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.