Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Don't Merge!][SecureString] [Autorest-based][Az.MachineLearningServices] Add a SecureString parameter #26962

Draft
wants to merge 1 commit into
base: generation
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,9 @@ function New-AzMLWorkspaceKubernetesObject {
[Parameter(HelpMessage="ServiceBus connection string.")]
[string]
$ServiceBusConnectionString,
[Parameter(HelpMessage="ServiceBus connection string in SecureString format.")]
[System.Security.SecureString]
$ServiceBusConnectionStringSecure,
[Parameter(HelpMessage="VC name.")]
[string]
$VcName
Expand Down Expand Up @@ -138,7 +141,10 @@ function New-AzMLWorkspaceKubernetesObject {
if ($PSBoundParameters.ContainsKey('RelayConnectionString')) {
$Object.RelayConnectionString = $RelayConnectionString
}
if ($PSBoundParameters.ContainsKey('ServiceBusConnectionString')) {
if ($PSBoundParameters.ContainsKey('ServiceBusConnectionStringSecure')) {
$Object.ServiceBusConnectionStringSecure = $ServiceBusConnectionStringSecure
}
elseif ($PSBoundParameters.ContainsKey('ServiceBusConnectionString')) {
$Object.ServiceBusConnectionString = $ServiceBusConnectionString
}
if ($PSBoundParameters.ContainsKey('VcName')) {
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
namespace Microsoft.Azure.PowerShell.Cmdlets.MachineLearningServices.Models.Api20240401
{
using Microsoft.Azure.PowerShell.Cmdlets.MachineLearningServices.Models;
public partial class Kubernetes
{
public System.Security.SecureString ServiceBusConnectionStringSecure { get => (this.ServiceBusConnectionString.ToSecureString()); set => this.ServiceBusConnectionString = value.ConvertToString(); }
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
using System.Runtime.InteropServices;
using System.Security;
using System;

namespace Microsoft.Azure.PowerShell.Cmdlets.MachineLearningServices.Models
{
public static class Utils
{
public static System.Security.SecureString ToSecureString(this string input)
{
if (string.IsNullOrEmpty(input))
return null;

System.Security.SecureString secureString = new System.Security.SecureString();
foreach (char c in input)
{
secureString.AppendChar(c);
}
secureString.MakeReadOnly();
return secureString;
}

public static string ConvertToString(this SecureString secureString)
{
if (secureString == null)
{
return null;
}

IntPtr unmanagedString = IntPtr.Zero;

try
{
unmanagedString = Marshal.SecureStringToGlobalAllocUnicode(secureString);
return Marshal.PtrToStringUni(unmanagedString);
}
finally
{
if (unmanagedString != IntPtr.Zero)
{
Marshal.ZeroFreeGlobalAllocUnicode(unmanagedString);
}
}
}
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ New-AzMLWorkspaceKubernetesObject [-DefaultInstanceType <String>] [-Description
[-DisableLocalAuth <Boolean>] [-ExtensionInstanceReleaseTrain <String>] [-ExtensionPrincipalId <String>]
[-InstanceLimit <Hashtable>] [-InstanceNodeSelector <Hashtable>] [-InstanceRequest <Hashtable>]
[-Namespace <String>] [-RelayConnectionString <String>] [-ResourceId <String>]
[-ServiceBusConnectionString <String>] [-VcName <String>] [<CommonParameters>]
[-ServiceBusConnectionString <String>] [-ServiceBusConnectionStringSecure <SecureString>] [-VcName <String>]
[<CommonParameters>]
```

## DESCRIPTION
Expand Down Expand Up @@ -214,6 +215,21 @@ Accept pipeline input: False
Accept wildcard characters: False
```

### -ServiceBusConnectionStringSecure
ServiceBus connection string in SecureString format.

```yaml
Type: System.Security.SecureString
Parameter Sets: (All)
Aliases:

Required: False
Position: Named
Default value: None
Accept pipeline input: False
Accept wildcard characters: False
```

### -VcName
VC name.

Expand Down
Loading