Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upcoming breaking changes for secrets detection #24552

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

vidai-msft
Copy link
Contributor

@vidai-msft vidai-msft commented Mar 29, 2024

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

azure-client-tools-bot-prd bot commented Mar 29, 2024

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could use more explaination about how would this impact the customers.

@vidai-msft vidai-msft force-pushed the breakingchange-secretdetection branch from 1ce1b9a to b04bb01 Compare April 1, 2024 13:27
@vidai-msft
Copy link
Contributor Author

Could use more explaination about how would this impact the customers.

Updated.

@isra-fel isra-fel merged commit 216fce6 into Azure:main Apr 1, 2024
12 checks passed
@vidai-msft vidai-msft deleted the breakingchange-secretdetection branch April 24, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants