Make TLS 1.2 as default MinimalTlsVersion #24428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️Az.Accounts
️✔️Az.Compute
️✔️Az.EventHub
️✔️Az.KeyVault
️✔️Az.ManagedServiceIdentity
️✔️Az.Monitor
️✔️Az.Network
️✔️Az.OperationalInsights
️✔️Az.PrivateDns
️✔️Az.Sql
️✔️Az.Storage
|
|
@jha1bhavna can you please write/update a test case to cover the default check and update the doc as well? |
|
@jha1bhavna Please fix the test issue and update the doc accordingly. |
vidai-msft
reviewed
Mar 29, 2024
vidai-msft
requested changes
Mar 29, 2024
vidai-msft
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.Testing:
PS D:\src\Powershell\azure-powershell> $serverCreds = New-Object System.Management.Automation.PSCredential("cloudsa",("bhavnajha123#" | ConvertTo-SecureString -AsPlainText -Force))
PS D:\src\Powershell\azure-powershell>
PS D:\src\Powershell\azure-powershell>
PS D:\src\Powershell\azure-powershell> New-AzSqlServer -ServerName testdefaulttls12 -ResourceGroupName bhavnajha-rg -SqlAdministratorCredentials $serverCreds
cmdlet New-AzSqlServer at command pipeline position 1
Supply values for the following parameters:
(Type !? for Help.)
Location: East US 2
ResourceGroupName : bhavnajha-rg
ServerName : testdefaulttls12
Location : eastus2
SqlAdministratorLogin : cloudsa
SqlAdministratorPassword :
ServerVersion : 12.0
Tags :
Identity :
FullyQualifiedDomainName : testdefaulttls12.database.windows.net
ResourceId : /subscriptions/eb951d38-18d9-46d4-9a0c-f694b148c76a/resourceGroups/bhavnajha-rg/provide
rs/Microsoft.Sql/servers/testdefaulttls12
MinimalTlsVersion : 1.2
PublicNetworkAccess : Enabled
RestrictOutboundNetworkAccess : Disabled
Administrators :
PrimaryUserAssignedIdentityId :
KeyId :
FederatedClientId :
PS D:\src\Powershell\azure-powershell> (Get-AzSqlServer -ServerName testdefaulttls12 -ResourceGroupName bhavnajha-rg).MinimalTlsVersion
1.2