[Pipleline] Generated sdk code verify

.ci-config.json

@@ -7,7 +7,7 @@
         "src/{ModuleName}/{ModuleName}.Sdk/Generated/*"
       ],
       "phases": [
-        "verify-gensdk:module"
+        "generated-sdk:module"
       ]
     },
     {

tools/BuildPackagesTask/Microsoft.Azure.Build.Tasks/CIFilterTask.cs

@@ -70,7 +70,7 @@ public class CIFilterTask : Task
 
         private const string BUILD_PHASE = "build";
         private const string TEST_PHASE = "test";
-        private readonly List<string> ANALYSIS_PHASE_LIST = new List<string>() { "breaking-change", "help-example", "help", "dependency", "signature", "file-change", "ux", "verify-gensdk" };
+        private readonly List<string> ANALYSIS_PHASE_LIST = new List<string>() { "breaking-change", "help-example", "help", "dependency", "signature", "file-change", "ux", "generated-sdk" };
         private readonly List<string> ONLY_AFFECT_MODULE_PHASE_LIST = new List<string>() { "cmdlet-diff" }; // These phases will be triggered only when the module is modified, not when its dependent module is updated.
         private const string ACCOUNT_MODULE_NAME = "Accounts";
 

tools/ExecuteCIStep.ps1

@@ -63,7 +63,7 @@ Param(
     $StaticAnalysisCmdletDiff,
 
     [Switch]
-    $StaticAnalysisVerifyGensdk,
+    $StaticAnalysisGeneratedSdk,
 
     [String]
     $RepoArtifacts='artifacts',
@@ -400,7 +400,7 @@ If ($StaticAnalysis)
     .("$PSScriptRoot/ExecuteCIStep.ps1") -StaticAnalysisHelp @Parameters
     .("$PSScriptRoot/ExecuteCIStep.ps1") -StaticAnalysisUX @Parameters
     .("$PSScriptRoot/ExecuteCIStep.ps1") -StaticAnalysisCmdletDiff @Parameters
-    .("$PSScriptRoot/ExecuteCIStep.ps1") -StaticAnalysisVerifyGensdk @Parameters
+    .("$PSScriptRoot/ExecuteCIStep.ps1") -StaticAnalysisGeneratedSdk @Parameters
     Return
 }
 
@@ -512,17 +512,17 @@ If ($StaticAnalysisCmdletDiff)
     Return
 }
 
-If ($StaticAnalysisVerifyGensdk)
+If ($StaticAnalysisGeneratedSdk)
 {
     If ($PSBoundParameters.ContainsKey("TargetModule"))
     {
-        $VerifyGenSdkModuleList = $TargetModule
+        $GeneratedSdkModuleList = $TargetModule
     }
     Else
     {
-        $VerifyGenSdkModuleList = Join-String -Separator ';' -InputObject $CIPlan.'verify-gensdk'
+        $GeneratedSdkModuleList = Join-String -Separator ';' -InputObject $CIPlan.'generated-sdk'
     }
-    If ("" -Ne $VerifyGenSdkModuleList)
+    If ("" -Ne $GeneratedSdkModuleList)
     {
         Write-Host "Running static analysis to verify generated sdk..."
         $result = .($PSScriptRoot + "/StaticAnalysis/GeneratedSdkAnalyzer/SDKGeneratedCodeVerify.ps1")

tools/PipelineResultTemplate.json

@@ -47,8 +47,8 @@
         "Details": [
         ]
     },
-    "verify-gensdk": {
-        "PhaseName": "Verify Generated Sdk",
+    "generated-sdk": {
+        "PhaseName": "Generated Sdk Check",
         "Order": 9,
         "Details": [
         ]

tools/StaticAnalysis/CollectStaticAnalysisPipelineResult.ps1

@@ -73,8 +73,8 @@ $Steps = @(
         IssuePath = "$StaticAnalysisOutputDirectory/UXMetadataIssues.csv"
     },
     @{
-        PhaseName = "verify-gensdk"
-        IssuePath = "$StaticAnalysisOutputDirectory/VerifyGensdkIssues.csv"
+        PhaseName = "generated-sdk"
+        IssuePath = "$StaticAnalysisOutputDirectory/GeneratedSdkIssues.csv"
     }
 )
 
@@ -151,7 +151,7 @@ ForEach ($Step In $Steps) {
                 ElseIf ($PhaseName -Eq "ux") {
                     $Content = "|Type|Module|ResourceType|SubResourceType|Command|Description|`n|---|---|---|---|---|---|`n"
                 }
-                ElseIf ($PhaseName -Eq "verify-gensdk") {
+                ElseIf ($PhaseName -Eq "generated-sdk") {
                     $Content = "|Type|Module|Sdk|Description|Remediation|`n|---|---|---|---|---|`n"
                 }
                 #EndRegion
@@ -173,7 +173,7 @@ ForEach ($Step In $Steps) {
                     ElseIf ($PhaseName -Eq "ux") {
                         $Content += "|$ErrorTypeEmoji|$($Issue.Module)|$($Issue.ResourceType)|$($Issue.SubResourceType)|$($Issue.Command)|$($Issue.Description)|`n"
                     }
-                    ElseIf ($PhaseName -Eq "verify-gensdk") {
+                    ElseIf ($PhaseName -Eq "generated-sdk") {
                         $Content += "|$ErrorTypeEmoji|$($Issue.Module)|$($Issue.Sdk)|$($Issue.Description)|$($Issue.Remediation)|`n"
                     }
                     #EndRegion

tools/StaticAnalysis/GeneratedSdkAnalyzer/VerifyGenSdkIssue.cs → tools/StaticAnalysis/GeneratedSdkAnalyzer/GeneratedSdkIssue.cs

@@ -18,7 +18,7 @@
 
 namespace StaticAnalysis.GeneratedSdkAnalyzer
 {
-    public class VerifyGenSdkIssue : IReportRecord
+    public class GeneratedSdkIssue : IReportRecord
     {
         /// <summary>
         /// The module containing the generated sdk issue
@@ -46,7 +46,7 @@ public string FormatRecord()
         public bool Match(IReportRecord other)
         {
             var result = false;
-            var record = other as VerifyGenSdkIssue;
+            var record = other as GeneratedSdkIssue;
             if (record != null)
             {
                 result = string.Equals(record.Module, Module, StringComparison.OrdinalIgnoreCase) &&
@@ -64,7 +64,7 @@ public IReportRecord Parse(string line)
             var match = Regex.Match(line, matcher);
             if (!match.Success || match.Groups.Count < 7)
             {
-                throw new InvalidOperationException(string.Format("Could not parse '{0}' as VerifyGenSdkIssue record", line));
+                throw new InvalidOperationException(string.Format("Could not parse '{0}' as GeneratedSdkIssue record", line));
             }
 
             Module = match.Groups[1].Value;

tools/StaticAnalysis/GeneratedSdkAnalyzer/SDKGeneratedCodeVerify.ps1

@@ -15,7 +15,7 @@
 
 $ArtifactsFolder = "$PSScriptRoot/../../../artifacts"
 $FilesChangedPaths = "$ArtifactsFolder/FilesChanged.txt"
-$ExceptionFilePath = "$ArtifactsFolder/StaticAnalysisResults/VerifyGenSdkIssues.csv"
+$ExceptionFilePath = "$ArtifactsFolder/StaticAnalysisResults/GeneratedSdkIssues.csv"
 
 Class GeneratedSdkIssue {
     [String]$Module
@@ -52,7 +52,8 @@ try{
     autorest --reset
     foreach ($_ in $ChangedSdks) {
         # Extract Module Name
-        $ModuleName = ($_ -split "\/|\\")[1]
+        $ModuleName = "Az." + ($_ -split "\/|\\")[1]
+
         # Direct to the Sdk directory
         Write-Host "Directing to " "$PSScriptRoot/../../../$_"
         cd "$PSScriptRoot/../../../$_"

tools/StaticAnalysis/IssueChecker/IssueChecker.cs

@@ -44,7 +44,7 @@ public class IssueChecker : IStaticAnalyzer
             ("SignatureIssues.csv", typeof(SignatureIssue).FullName),
             ("ExampleIssues.csv", typeof(ExampleIssue).FullName),
             ("UXMetadataIssues.csv", typeof(UXMetadataIssue).FullName),
-            ("VerifyGenSdkIssues.csv", typeof(VerifyGenSdkIssue).FullName)
+            ("GeneratedSdkIssues.csv", typeof(GeneratedSdkIssue).FullName)
         };
         public AnalysisLogger Logger { get; set; }
 

tools/StaticAnalysis/ReportRecordFactory.cs

@@ -69,9 +69,9 @@ public static IReportRecord Create(string type)
             {
                 return new UXMetadataIssue();
             }
-            if (type.Equals(typeof(VerifyGenSdkIssue).FullName))
+            if (type.Equals(typeof(GeneratedSdkIssue).FullName))
             {
-                return new VerifyGenSdkIssue();
+                return new GeneratedSdkIssue();
             }
 
             return null;