Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataBricks] Fix issue Update-AzDatabricksWorkspace doesn't work as expected while … #21726

Merged
merged 2 commits into from
May 10, 2023

Conversation

lijinpei2008
Copy link
Contributor

@lijinpei2008 lijinpei2008 commented May 8, 2023

…enabling encryption

Description

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented May 8, 2023

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
⚠️Az.Databricks
️✔️Build
️✔️PowerShell Core - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
⚠️Signature Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ Get-AzDatabricksAccessConnector Get-AzDatabricksAccessConnector Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzDatabricksAccessConnector Get-AzDatabricksAccessConnector changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzDatabricksOutboundNetworkDependenciesEndpoint Get-AzDatabricksOutboundNetworkDependenciesEndpoint Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzDatabricksOutboundNetworkDependenciesEndpoint Get-AzDatabricksOutboundNetworkDependenciesEndpoint changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzDatabricksVNetPeering Get-AzDatabricksVNetPeering Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzDatabricksVNetPeering Get-AzDatabricksVNetPeering changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzDatabricksWorkspace Get-AzDatabricksWorkspace Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzDatabricksWorkspace Get-AzDatabricksWorkspace changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️Help Example Check
⚠️PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ 2 2 Mismatched_Parameter_Value_Type Remove-AzDatabricksWorkspace -InputObject $dbr is not an expected parameter value type. -InputObject Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Databricks.Models.IDatabricksIdentity. Now the type is Microsoft.Azure.PowerShell.Cmdlets.Databricks.Models.Api20230201.IWorkspace.(Command).
⚠️ 1 2 Mismatched_Parameter_Value_Type Update-AzDatabricksWorkspace -InputObject $dbr is not an expected parameter value type. -InputObject Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Databricks.Models.IDatabricksIdentity. Now the type is Microsoft.Azure.PowerShell.Cmdlets.Databricks.Models.Api20230201.IWorkspace.(Command).
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
⚠️File Change Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.Databricks. Add a changelog record under Upcoming Release section with past tense.
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
⚠️Test
⚠️ - MacOS
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 0.00% Test coverage for the module cannot be lower than 50%.
️✔️PowerShell Core - Linux
️✔️PowerShell Core - Windows

@msJinLei msJinLei changed the title [DataBricks] Fixissue Update-AzDatabricksWorkspace doesn't work as expected while … [DataBricks] Fix issue Update-AzDatabricksWorkspace doesn't work as expected while … May 10, 2023
@msJinLei msJinLei merged commit 96843e8 into generation May 10, 2023
@lijinpei2008 lijinpei2008 deleted the fixissue/databricks branch May 10, 2023 10:37
qinzhouxu pushed a commit to qinzhouxu/azure-powershell that referenced this pull request Jun 12, 2023
…xpected while … (Azure#21726)

* fixissue Update-AzDatabricksWorkspace doesn't work as expected while enabling encryption

* generate UX folder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update-AzDatabricksWorkspace doesn't work as expected while enabling encryption.
2 participants