Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Az.ConnectedKubernetes] support proxy environments and fix issues (from generation) #20955

Merged
merged 18 commits into from
Feb 17, 2023

Conversation

yinghsugn
Copy link
Contributor

@yinghsugn yinghsugn commented Feb 17, 2023

Description

  • Added optional configs (-HttpProxy, -HttpsProxy, -NoProxy, -ProxyCert) for cmdlet New-AzConnectedKubernetes.
  • Added optional configs (-ContainerLogPath, -DisableAutoUpgrade, -NoWait, -OnboardingTimeout) for cmdlet New-AzConnectedKubernetes.
  • Fixed invalid URI issue with display name of location for cmdlet New-AzConnectedKubernetes.
  • Fixed response can't be parsed issue with UseBasicParsing for cmdlet New-AzConnectedKubernetes.

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

Nickcandy and others added 11 commits February 17, 2023 12:55
* Fix/connectedk8s ps5 (Azure#20603)

* Create RSAHelper.ps1

* Update New-AzConnectedKubernetes.ps1

* Add try-catch and update function parameters

* Update New-AzConnectedKubernetes.ps1

* [Az.ConnectedKubernetes] Update ChangeLog  (Azure#20649)

* Update RSAHelper.ps1 (coding style)

* Update ChangeLog.md

* upgrade Az.ConnectedKubernetes from 0.7.0 to 0.7.1

---------

Co-authored-by: Ann Lu <[email protected]>
Squashed commit:

[37a75ce] Add optional settings

[f90cd1a] Add optional settings
…ashed commits)

Squashed commits:

[49e9e01] Install azure-arc helm release in azure-arc-release namespace (+1 squashed commits)

Squashed commits:

[9662ecf] Install azure-arc helm release in azure-arc-release namespace
Squashed commits:

[28ff1d7] Add Proxy settings (+4 squashed commit)

Squashed commit:

[cdfe615] Update warning messages

[5d46ec2] Check credential

[db0351e] Update parameter description

[79bf2b1] Modify parameter type
…hed commits)

Squashed commits:

[c893de7] Fix Invalid URI issue when passing diaplsy name of location (+1 squashed commits)

Squashed commits:

[bc81f1915fb] Fix Invalid URI issue when passing diaplsy name of location
@@ -227,7 +227,7 @@ COMPLEX PARAMETER PROPERTIES
To create the parameters described below, construct a hash table containing the appropriate properties. For information on hash tables, run Get-Help about_Hash_Tables.


`PROPERTY <IListClusterUserCredentialProperties>`: .
PROPERTY <IListClusterUserCredentialProperties>: .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this deleting is caused your autorest version. please run autorest --reset then re-run autorest, ./build-module.ps1 to upgrade autorest

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
After "autorest --reset, autoreset, ./build-module.ps1" commands, the formats are recovered.

tools/AzPreview/AzPreview.psd1 Outdated Show resolved Hide resolved
BethanyZhou
BethanyZhou previously approved these changes Feb 17, 2023
Copy link
Contributor

@BethanyZhou BethanyZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Nickcandy
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Contributor

@BethanyZhou BethanyZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BethanyZhou BethanyZhou merged commit e00d493 into Azure:generation Feb 17, 2023
@yinghsugn yinghsugn deleted the lua/fix/connectedk8s2 branch February 21, 2023 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants