Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set-AzVMSqlServerExtension changes of default extension version and autoupgrademinorversion #20506

Merged
merged 1 commit into from
Dec 26, 2022

Conversation

yareyes
Copy link
Member

@yareyes yareyes commented Dec 22, 2022

Description

Please note that these commands are really old and nobody has modified them since 2018. There are two minimal changes made into this PR -> NOTHING is customer facing so the md files have not been modified.

  1. We're changing the default extension version of SqlIaaSExtension from 1.2 to 2.0, since 1.2 is really old and super outdated.
  2. We're adding parameter AutoUpgradeMinorVersion to true if the extension has never been installed on the machine, but we're respecting the value set if the customer has manually disable it.
  3. We've refreshed the test to make sure there is a latest recording available.

The autoupgrademinorversion is being set to true, because extension constantly gets updates and this is preventing customer to get latest extension that has bug fixes.
NOTE -> This didn't seem to be the case before, it was a default to upgrade the extension version to true, but seems like Compute has changed the default to false if the parameter is not passed, so setting it default true.

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@msJinLei
Copy link
Contributor

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@msJinLei msJinLei merged commit 48c591e into Azure:main Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants