Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate App from generation to main #20502

Merged
merged 3 commits into from
Dec 26, 2022
Merged

Migrate App from generation to main #20502

merged 3 commits into from
Dec 26, 2022

Conversation

azure-powershell-bot
Copy link
Collaborator

Description

Migrate App from generation to main

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@LucasYao93 LucasYao93 linked an issue Dec 22, 2022 that may be closed by this pull request
@LucasYao93 LucasYao93 added this to the January 2023 (2023-01-10) milestone Dec 22, 2022
Add empty line between upcoming release and the latest released version.
@msJinLei msJinLei merged commit 8109c12 into main Dec 26, 2022
@lijinpei2008 lijinpei2008 deleted the codegen/App branch January 30, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Doc]: New-AzContainerAppScaleRuleObject documentation
3 participants