Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update New-AzADAppCredential.md #20149

Closed
wants to merge 0 commits into from
Closed

Update New-AzADAppCredential.md #20149

wants to merge 0 commits into from

Conversation

robinmalik
Copy link
Contributor

Fixes "unable to get certificate thumbprint" issue in the portal, by providing the the thumbprint to the -CustomKeyIdentifier parameter.

Description

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@ghost ghost added the customer-reported label Nov 16, 2022
@ghost
Copy link

ghost commented Nov 16, 2022

Thank you for your contribution robinmalik! We will review the pull request and get back to you soon.

@Nickcandy
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 2 pipeline(s).

Nickcandy
Nickcandy previously approved these changes Nov 23, 2022
@Nickcandy
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 2 pipeline(s).

@BethanyZhou
Copy link
Contributor

Hi @robinmalik , your PR is targeting to a deprecated branch. If you want to update our online docs, please change your target to main branch.

@BethanyZhou BethanyZhou added the needs-author-feedback More information is needed from author to address the issue. label Nov 25, 2022
@robinmalik robinmalik changed the base branch from Azs-tzl to main November 29, 2022 08:29
@robinmalik robinmalik dismissed Nickcandy’s stale review November 29, 2022 08:29

The base branch was changed.

@robinmalik robinmalik closed this Nov 29, 2022
@robinmalik
Copy link
Contributor Author

Hi @robinmalik , your PR is targeting to a deprecated branch. If you want to update our online docs, please change your target to main branch.

Thanks @BethanyZhou, given the number of commits and difficulties synchronising my fork I'll just redo this change.

@robinmalik robinmalik deleted the patch-1 branch November 29, 2022 08:33
@robinmalik robinmalik restored the patch-1 branch November 29, 2022 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported needs-author-feedback More information is needed from author to address the issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants