Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Connect-AzConnectedMachine] Fixes error with return value processing #19542

Merged
merged 2 commits into from
Sep 22, 2022

Conversation

nyanhp
Copy link
Contributor

@nyanhp nyanhp commented Sep 21, 2022

Description

Fixes #19541 by using $_ instead of the entire result collection in Connect-AzConnectedMachine

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@ghost ghost added the customer-reported label Sep 21, 2022
@ghost
Copy link

ghost commented Sep 21, 2022

Thank you for your contribution nyanhp! We will review the pull request and get back to you soon.

@wyunchi-ms
Copy link
Contributor

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@wyunchi-ms wyunchi-ms assigned vidai-msft and unassigned vidai-msft Sep 22, 2022
Copy link
Contributor

@vidai-msft vidai-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@vidai-msft vidai-msft merged commit 03d499e into Azure:main Sep 22, 2022
wyunchi-ms added a commit that referenced this pull request Sep 22, 2022
@wyunchi-ms
Copy link
Contributor

Thanks for the contribution! @nyanhp . But due to our team's process. This change should be merged into generation branch first. I create a PR based on your PR.

wyunchi-ms added a commit that referenced this pull request Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ConnectedMachine] Connect-AzConnectedMachine throws if multiple sessions are used
3 participants