-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EventHubs]: Migrating to Autorest Powershell #19458
Merged
wyunchi-ms
merged 34 commits into
Azure:generation
from
damodaravadhani:EventHubAutoGenerated
Sep 28, 2022
Merged
[EventHubs]: Migrating to Autorest Powershell #19458
wyunchi-ms
merged 34 commits into
Azure:generation
from
damodaravadhani:EventHubAutoGenerated
Sep 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyunchi-ms
reviewed
Sep 13, 2022
wyunchi-ms
reviewed
Sep 19, 2022
src/EventHub/EventHub.Autorest/examples/Approve-AzEventHubPrivateEndpointConnection.md
Show resolved
Hide resolved
src/EventHub/EventHub.Autorest/examples/Approve-AzEventHubPrivateEndpointConnection.md
Outdated
Show resolved
Hide resolved
src/EventHub/EventHub.Autorest/examples/Deny-AzEventHubPrivateEndpointConnection.md
Show resolved
Hide resolved
src/EventHub/EventHub.Autorest/examples/Deny-AzEventHubPrivateEndpointConnection.md
Show resolved
Hide resolved
…dhani/azure-powershell into EventHubAutoGenerated
Hello @wyunchi-ms , I have pushed all fixes discussed in Monday office hours, however a couple cmdlets still fail during Playback saying "Invalid Context" or "ResourceGroup not found" which I was not able to fix. Apart from this, there is nothing left from my side to push. Please feel free to add "-skip" tag to tests that might block you from merging because all pass when run live. Thank you ! |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
…dhani/azure-powershell into EventHubAutoGenerated
…dhani/azure-powershell into EventHubAutoGenerated
wyunchi-ms
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
CONTRIBUTING.md
and reviewed the following information:generation
branch.ChangeLog.md
file(s) appropriatelyChangeLog.md
file can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
## Upcoming Release
header in the past tense. Add changelog in description section if PR goes intogeneration
branch.ChangeLog.md
if no new release is required, such as fixing test case only.