Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MSGraph] add new parameter set to new-azaduser, fix issues with get-azaduser #19308

Merged
merged 5 commits into from
Aug 29, 2022

Conversation

VeryEarly
Copy link
Contributor

@VeryEarly VeryEarly commented Aug 24, 2022

Description

#19265
#18205
#16874

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@VeryEarly VeryEarly self-assigned this Aug 24, 2022
@VeryEarly VeryEarly added this to the September 2022 (2022-09-06) milestone Aug 24, 2022
@VeryEarly VeryEarly changed the title [MSGraph] add new parameter set to new-azaduser [MSGraph] add new parameter set to new-azaduser, fix issues with get-azaduser Aug 26, 2022
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we have two parameter sets for New-AzADUser, we should consider making one of them the default parameter set.

@VeryEarly VeryEarly merged commit c9f81cf into Azure:generation Aug 29, 2022
@VeryEarly VeryEarly deleted the msgraph/issue-fix branch August 29, 2022 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment