-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added -EdgeZone and -ResourceType parameter to New-AzSnapshotUpdateCo… #19284
Conversation
…nfig and Get-AzComputeResourceSku
Mandatory = false, | ||
ValueFromPipelineByPropertyName = true, | ||
HelpMessage = "Sets and Gets Resource Type")] | ||
public string ResourceType { get; set; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ResourceType
is added but never used. And the document also not updated about it.
Ping @pselugar |
Sorry for the delay, was in talk with the PR design team, removed unused ResourceType . |
@pselugar Please resolve the conflicts first |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
…nfig and Get-AzComputeResourceSku
Description
-EdgeZone
parameter toNew-AzSnapshotUpdateConfig
andGet-AzComputeResourceSku
cmdletLink to Powershell Design PR: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/776
Work Item: https://msazure.visualstudio.com/One/_workitems/edit/9433546
Checklist
CONTRIBUTING.md
and reviewed the following information:generation
branch.ChangeLog.md
file(s) appropriatelyChangeLog.md
file can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
## Upcoming Release
header in the past tense. Add changelog in description section if PR goes intogeneration
branch.ChangeLog.md
if no new release is required, such as fixing test case only.