Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added -EdgeZone and -ResourceType parameter to New-AzSnapshotUpdateCo… #19284

Merged
merged 9 commits into from
Oct 17, 2022

Conversation

pselugar
Copy link
Contributor

@pselugar pselugar commented Aug 22, 2022

…nfig and Get-AzComputeResourceSku

Description

  • Added -EdgeZone parameter to New-AzSnapshotUpdateConfig and Get-AzComputeResourceSku cmdlet

Link to Powershell Design PR: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/776
Work Item: https://msazure.visualstudio.com/One/_workitems/edit/9433546

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@pselugar pselugar assigned wyunchi-ms and unassigned wyunchi-ms Aug 26, 2022
@pselugar pselugar marked this pull request as ready for review September 9, 2022 05:53
src/Compute/Compute/ChangeLog.md Show resolved Hide resolved
Mandatory = false,
ValueFromPipelineByPropertyName = true,
HelpMessage = "Sets and Gets Resource Type")]
public string ResourceType { get; set; }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ResourceType is added but never used. And the document also not updated about it.

@wyunchi-ms
Copy link
Contributor

Ping @pselugar

@pselugar
Copy link
Contributor Author

Ping @pselugar

Sorry for the delay, was in talk with the PR design team, removed unused ResourceType .

@vidai-msft
Copy link
Contributor

@pselugar Please resolve the conflicts first

Copy link
Contributor

@vidai-msft vidai-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@vidai-msft vidai-msft merged commit f296d27 into Azure:main Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants