Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network Security Perimeter Resources #19164

Merged
merged 41 commits into from
Aug 22, 2022
Merged

Conversation

kaushal087
Copy link

@kaushal087 kaushal087 commented Aug 5, 2022

Description

https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1229

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from the scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT change version of module in pull request

@isra-fel isra-fel self-assigned this Aug 8, 2022
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The NetworkSecurityPerimeter.Autorest/ folder should be lifted up for one level aka src/Network/NetworkSecurityPerimeter.Autorest/

@kaushal087
Copy link
Author

kaushal087 commented Aug 11, 2022

@isra-fel

  • The NetworkSecurityPerimeter.Autorest/ folder should be lifted up for one level aka src/Network/NetworkSecurityPerimeter.Autorest/. So I believe NetworkSecurityPerimeter should also be there.

NetworkSecurityPerimeter's related services are currently inside src/Network/Network/
Please refer to this and advise.
https://github.com/Azure/azure-powershell/tree/main/src/Network/Network

@isra-fel
Copy link
Member

Please do lift it up.
Folder structure on generation branch is different from main branch by design.

@kaushal087
Copy link
Author

Please do lift it up. Folder structure on generation branch is different from main branch by design.

@isra-fel I have moved the files one directory up as per your review comments.

@isra-fel
Copy link
Member

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@kaushal087
Copy link
Author

/azp run

@azure-pipelines
Copy link
Contributor

Commenter does not have sufficient privileges for PR 19164 in repo Azure/azure-powershell

@isra-fel isra-fel merged commit 7cebf5d into Azure:generation Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants