-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Network Security Perimeter Resources #19164
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The
NetworkSecurityPerimeter.Autorest/
folder should be lifted up for one level akasrc/Network/NetworkSecurityPerimeter.Autorest/
src/Network/Network/NetworkSecurityPerimeter.Autorest/README.md
Outdated
Show resolved
Hide resolved
src/Network/Network/NetworkSecurityPerimeter.Autorest/README.md
Outdated
Show resolved
Hide resolved
src/Network/Network/NetworkSecurityPerimeter.Autorest/README.md
Outdated
Show resolved
Hide resolved
...work/NetworkSecurityPerimeter.Autorest/examples/Get-AzNetworkSecurityPerimeterAssociation.md
Outdated
Show resolved
Hide resolved
...rk/NetworkSecurityPerimeter.Autorest/examples/Remove-AzNetworkSecurityPerimeterAccessRule.md
Outdated
Show resolved
Hide resolved
...work/NetworkSecurityPerimeter.Autorest/examples/Get-AzNetworkSecurityPerimeterAssociation.md
Outdated
Show resolved
Hide resolved
...twork/NetworkSecurityPerimeter.Autorest/examples/New-AzNetworkSecurityPerimeterAccessRule.md
Outdated
Show resolved
Hide resolved
...rk/NetworkSecurityPerimeter.Autorest/examples/Remove-AzNetworkSecurityPerimeterAccessRule.md
Outdated
Show resolved
Hide resolved
...twork/NetworkSecurityPerimeter.Autorest/examples/Remove-AzNetworkSecurityPerimeterProfile.md
Outdated
Show resolved
Hide resolved
NetworkSecurityPerimeter's related services are currently inside src/Network/Network/ |
Please do lift it up. |
@isra-fel I have moved the files one directory up as per your review comments. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Commenter does not have sufficient privileges for PR 19164 in repo Azure/azure-powershell |
Description
https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1229
Checklist
CONTRIBUTING.md
and reviewed the following information:generation
branch.ChangeLog.md
file(s) appropriatelyChangeLog.md
file can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
## Upcoming Release
header in the past tense. Add changelog in description section if PR goes intogeneration
branch.ChangeLog.md
if no new release is required, such as fixing test case only.