-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Grafana] Create Az.Dashboard module and use apiverison = 2022-08-01 #18986
Conversation
src/Dashboard/docs/New-AzGrafana.md
Outdated
New-AzGrafana -Name <String> -ResourceGroupName <String> [-SubscriptionId <String>] [-ApiKey <ApiKey>] | ||
[-AutoGeneratedDomainNameLabelScope <AutoGeneratedDomainNameLabelScope>] | ||
[-DeterministicOutboundIP <DeterministicOutboundIP>] [-IdentityType <ManagedServiceIdentityType>] | ||
[-IdentityUserAssignedIdentity <Hashtable>] [-Location <String>] [-PublicNetworkAccess <PublicNetworkAccess>] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update Location as required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Swagger Link : https://github.com/Azure/azure-rest-api-specs/blob/main/specification/dashboard/resource-manager/Microsoft.Dashboard/stable/2022-08-01/grafana.json#L719
The swagger format was not "required":true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember you said it's required in your manual test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but in fact, in the example I provided, all of the parameters used are required.
I am now ready to mark these parameters "Mandatory" under the Custom folder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't find it's mandatory in the syntax of New-AzGrafana.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update some parameters and mark them as required
I'm moving current PR to main branch. Please raise a PR to main branch after this pipeline finished https://dev.azure.com/azure-sdk/public/_build/results?buildId=1733989&view=results |
Description
cmdlet: New/Get/Update/Remove-AzGrafana
Swagger: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/dashboard/resource-manager/Microsoft.Dashboard/stable/2022-08-01/grafana.json
Design: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1236
Checklist
CONTRIBUTING.md
and reviewed the following information:generation
branch.ChangeLog.md
file(s) appropriatelyChangeLog.md
file can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
## Upcoming Release
header in the past tense. Add changelog in description section if PR goes intogeneration
branch.ChangeLog.md
if no new release is required, such as fixing test case only.