Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Grafana] Create Az.Dashboard module and use apiverison = 2022-08-01 #18986

Merged
merged 3 commits into from
Jul 26, 2022

Conversation

lijinpei2008
Copy link
Contributor

Description

cmdlet: New/Get/Update/Remove-AzGrafana

Swagger: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/dashboard/resource-manager/Microsoft.Dashboard/stable/2022-08-01/grafana.json

Design: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1236

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from the scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT change version of module in pull request

@lijinpei2008 lijinpei2008 changed the title [Grafana] Create Microsoft.Grafana module and use apiverison = 2022-08-01 [Grafana] Create Az.Dashboard module and use apiverison = 2022-08-01 Jul 21, 2022
New-AzGrafana -Name <String> -ResourceGroupName <String> [-SubscriptionId <String>] [-ApiKey <ApiKey>]
[-AutoGeneratedDomainNameLabelScope <AutoGeneratedDomainNameLabelScope>]
[-DeterministicOutboundIP <DeterministicOutboundIP>] [-IdentityType <ManagedServiceIdentityType>]
[-IdentityUserAssignedIdentity <Hashtable>] [-Location <String>] [-PublicNetworkAccess <PublicNetworkAccess>]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update Location as required.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember you said it's required in your manual test?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but in fact, in the example I provided, all of the parameters used are required.
I am now ready to mark these parameters "Mandatory" under the Custom folder

Copy link
Contributor

@BethanyZhou BethanyZhou Jul 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find it's mandatory in the syntax of New-AzGrafana.md

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update some parameters and mark them as required

@BethanyZhou BethanyZhou merged commit 3a9b7ac into generation Jul 26, 2022
@BethanyZhou BethanyZhou deleted the feature/grafana-2022-08-01 branch July 26, 2022 04:27
@BethanyZhou
Copy link
Contributor

I'm moving current PR to main branch. Please raise a PR to main branch after this pipeline finished https://dev.azure.com/azure-sdk/public/_build/results?buildId=1733989&view=results

@lijinpei2008 lijinpei2008 mentioned this pull request Jul 26, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants