[KeyVault] Supported importing pem certificate by Import-AzKeyVaultCertificate #18644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BethanyZhou
commented
Jun 27, 2022
isra-fel
reviewed
Jun 28, 2022
| @@ -169,6 +199,11 @@ public override void ExecuteCmdlet() | |||
| } | |||
| } | |||
|
|
|||
| private bool IsPemFile(string filePath) | |||
| { | |||
| return ".pem".Equals(Path.GetExtension(FilePath), StringComparison.OrdinalIgnoreCase); | |||
There was a problem hiding this comment.
filePath is the method parameter, FilePath is a property.
Suggested change
| return ".pem".Equals(Path.GetExtension(FilePath), StringComparison.OrdinalIgnoreCase); | |
| return ".pem".Equals(Path.GetExtension(filePath), StringComparison.OrdinalIgnoreCase); |
isra-fel
reviewed
Jun 28, 2022
| return new PSKeyVaultCertificate(certClient.ImportCertificate(options)); | ||
| } | ||
|
|
||
| public PSKeyVaultCertificate MergeCertifcate(string vaultName, string certName, byte[] certificate, IDictionary<string, string> tags) |
There was a problem hiding this comment.
Suggested change
| public PSKeyVaultCertificate MergeCertifcate(string vaultName, string certName, byte[] certificate, IDictionary<string, string> tags) | |
| public PSKeyVaultCertificate MergeCertificate(string vaultName, string certName, byte[] certificate, IDictionary<string, string> tags) |
isra-fel
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supported importing pem certificate by
Import-AzKeyVaultCertificate[#18494]Description
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added