Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove WebsitesController #18469

Merged
merged 3 commits into from
Jun 14, 2022
Merged

Remove WebsitesController #18469

merged 3 commits into from
Jun 14, 2022

Conversation

ziyuezh576
Copy link
Contributor

@ziyuezh576 ziyuezh576 commented Jun 10, 2022

Description

Comparing with WebsitesController.cs, added these configuration of creating a WebsitesTestRunner instance to WebsitesTestRunner.cs.

                .WithNewRmModules(helper => new[]
                {
                    helper.GetRMModulePath("AzureRM.Network.psd1"),
                    helper.GetRMModulePath("AzureRM.KeyVault.psd1")
                })
                .WithNewRecordMatcherArguments (
                    userAgentsToIgnore: new Dictionary<string, string>
                    {
                        {"Microsoft.Azure.Management.ResourceManager.ResourceManagementClient", "2017-05-10"},
                        {"Microsoft.Azure.Management.Internal.Resources.ResourceManagementClient", "2016-09-01"}
                    },
                    resourceProviders: new Dictionary<string, string>
                    {
                        {"Microsoft.Websites", null},
                        {"Microsoft.Network", null},
                        {"Microsoft.KeyVault", null},
                        {"Microsoft.Storage", null}
                    }
                )

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@ziyuezh576 ziyuezh576 added the Test Infra Test framework label Jun 10, 2022
helper.RMProfileModule,
helper.GetRMModulePath("AzureRM.Websites.psd1"),
helper.GetRMModulePath("AzureRM.Network.psd1"),
helper.GetRMModulePath("AzureRM.KeyVault.psd1"),

helper.GetRMModulePath("AzureRM.KeyVault.psd1")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename above 3 AzureRM to Az.

helper.RMProfileModule,
helper.GetRMModulePath("AzureRM.Websites.psd1"),
helper.GetRMModulePath("AzureRM.Network.psd1"),
helper.GetRMModulePath("AzureRM.KeyVault.psd1"),

helper.GetRMModulePath("AzureRM.KeyVault.psd1")
})
.WithRecordMatcher(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default record matcher assignment can be removed.

@vidai-msft vidai-msft merged commit 567d576 into Azure:main Jun 14, 2022
VeryEarly added a commit that referenced this pull request Jun 17, 2022
…rsion 2022-04-01-preview (#18476)

* Fix Az.ContainerRegistry Xml Comments (#18388)

* Fix Az.CosmosDB XML Comments (#18401)

* Fix Az.CosmosDB XML Comments

* Fix Az.CosmosDB XML Comments

* Update PSClientEncryptionPolicy.cs

Co-authored-by: Ziyue Zheng <[email protected]>

* Fix Az.DataBoxEdge XML Comments (#18402)

* Fix Az.Automation XML Comments (#18407)

* Fix Az.Automation XML Comments

* Fix Az.Automation XML Comments

* Update SourceControlSyncJobStream.cs

Co-authored-by: Ziyue Zheng <[email protected]>

* Fix Az.DataLakeAnalytics XML Comments (#18403)

* Fix Az.Compute XML Comments (#18408)

* Fix Az.Compute XML Comments

* Fix Az.Compute.Helpers XML Comments

* Fix Az.DataLakeStore XML Comments (#18421)

* Fix Az.DataLakeStore XML Comments

* Fix Az.DataLakeStore XML Comments

Co-authored-by: Ziyue Zheng <[email protected]>

* Fix Az.DataMigration XML Comments (#18422)

* Fix Az.EventHub XML Comments (#18429)

* Fix Az.EventHub XML Comments

* Update PSNetworkRuleSetAttributes.cs

Co-authored-by: Ziyue Zheng <[email protected]>

* Fix Az.HDInsight XML Comments (#18432)

* Fix Az.IotHub XML Comments (#18433)

* Fix Az.IotHub XML Comments

* Fix Az.IotHub XML Comments

Co-authored-by: Ziyue Zheng <[email protected]>

* [CosmosDB] Fixes issue with Update-AzCosmosDBSqlContainer command on containers with  Client Encryption Policy (#18480)

* Support client encryption policy during container creation

* Update SqlOperationsTests.ps1

* Update New-AzCosmosDBSqlContainer.md

* Update PSClientEncryptionPolicy.cs

* Update NewAzCosmosDBSqlContainer.cs

* Update ChangeLog.md

* Updated package.

* Update CosmosDB.Test.csproj

* Updated example, session records.

* updated session records.

* Fixes update container command on containers with client encryption policy.

* Update ChangeLog.md

* Update ChangeLog.md

* Bug fix for the Restore-AzSqlDatabase cmdlet (#18475)

* Pass Tags field in the Database model constructor

* Update change log

* Remove WebsitesController (#18469)

* Remove WebsitesController

* Update WebsitesTestRunner.cs

* Update WebsitesTestRunner.cs

* Fixed issue when mimicing long running operation for test in Playback mode. (#18490)

* [Az.DataProtection] OOB for Az.DataProtection (#18477)

* Move DataProtection to main

* Update Changelog.md

* bump version for Az.Dataprotection

* update version in AzPreview.psd1

Co-authored-by: azure-powershell-bot <[email protected]>

* Enable ARM to the Private Link connection Cmdlets (#18358)

* enable Private link support

* both set to true

* Add testcase

* Add recording

Co-authored-by: Vishakha Narvekar <[email protected]>

* Initial changes for network manager resources

* add network manager models

* added all network maneger files

* update signature issues and project files containing network reference

* remove version bump, will be generated

* add all helps docs for network manager commands

* Update Remove-AzNetworkManagerGroup.md

* Update Remove-AzNetworkManagerGroup.md

* Update Remove-AzNetworkManagerSecurityAdminConfiguration.md

* Update Remove-AzNetworkManagerSecurityAdminRule.md

* Update Remove-AzNetworkManagerSecurityAdminRuleCollection.md

* fix help

* reset help to retriggle validation

* reset test

* fix test

Co-authored-by: v-yuzhichen <[email protected]>
Co-authored-by: Ziyue Zheng <[email protected]>
Co-authored-by: Santosh Kulkarni <[email protected]>
Co-authored-by: Ishan Rajesh Madan <[email protected]>
Co-authored-by: Vincent Dai <[email protected]>
Co-authored-by: Yabo Hu <[email protected]>
Co-authored-by: azure-powershell-bot <[email protected]>
Co-authored-by: Vishakha-Git <[email protected]>
Co-authored-by: Vishakha Narvekar <[email protected]>
Co-authored-by: Jared Gorthy <[email protected]>
Co-authored-by: yanfa317 <[email protected]>
Co-authored-by: Fan Yang (AZURE) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Test Infra Test framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants