Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{CosmosDB} | Getting location from the Resource Group Name #18449

Merged
merged 4 commits into from
Jun 17, 2022
Merged

{CosmosDB} | Getting location from the Resource Group Name #18449

merged 4 commits into from
Jun 17, 2022

Conversation

RakeshMohanMSFT
Copy link
Contributor

Fixes #17978.
Though we say location parameter is optional we still expect it to be provided https://docs.microsoft.com/en-us/powershell/module/az.cosmosdb/new-azcosmosdbaccount?view=azps-8.0.0. This change will fix that issue.

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

Fixes #17978.
Though we say location parameter is optional we still expect it to be provided https://docs.microsoft.com/en-us/powershell/module/az.cosmosdb/new-azcosmosdbaccount?view=azps-8.0.0. This change will fix that issue.
@VeryEarly
Copy link
Collaborator

@VeryEarly VeryEarly self-assigned this Jun 9, 2022
@VeryEarly
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly
Copy link
Collaborator

please update https://github.com/RakeshMohanMSFT/azure-powershell/blob/patch-1/src/CosmosDB/CosmosDB/ChangeLog.md

Though we say location parameter is optional we still expect it to be provided https://docs.microsoft.com/en-us/powershell/module/az.cosmosdb/new-azcosmosdbaccount?view=azps-8.0.0. This change will fix that issue.
@RakeshMohanMSFT
Copy link
Contributor Author

@VeryEarly
Copy link
Collaborator

/azp run - azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

No pipelines are associated with this pull request.

@VeryEarly
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly VeryEarly merged commit d40078c into Azure:main Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CosmosDB] If Location is an optional parameter, why is it required
2 participants