Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Az.Monitor XML Comments #18438

Merged
merged 6 commits into from
Jun 17, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public class PSDynamicMetricCriteria : DynamicMetricCriteria, IPSMultiMetricCrit
/// <summary>
/// Initiliazes a PS object for dynamic metric criteria
/// </summary>
/// <param name="metricCriteria">The original dynamic metric criteria object</param>
/// <param name="dynamicMetricCriteria">The original dynamic metric criteria object</param>
public PSDynamicMetricCriteria(DynamicMetricCriteria dynamicMetricCriteria):
base(name: dynamicMetricCriteria.Name,
metricName: dynamicMetricCriteria.MetricName,
Expand Down
6 changes: 3 additions & 3 deletions src/Monitor/Monitor/OutputClasses/PSMetricDimension.cs
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ public class PSMetricDimension
/// <summary>
/// Initializes a new instance of the MetricDimension class.
/// </summary>
/// <param name="dimension">Name of the dimension.</param>
/// <param name="includeValues">List dimension includeValues.</param>
/// <param name="excludeValues">List of dimension excludeValues.</param>
/// <param name="dimensionName">Name of the dimension.</param>
/// <param name="valuesToInclude">List dimension includeValues.</param>
/// <param name="valuesToExclude">List of dimension excludeValues.</param>

public PSMetricDimension(string dimensionName, string[] valuesToInclude, string[] valuesToExclude)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,13 @@ namespace Microsoft.Azure.Commands.Insights.OutputClasses
///
[JsonTransformation]
public class PSPrivateEndpointConnection
{
{
/// <summary>
/// Initializes a new instance of the PrivateEndpointConnection class.
/// </summary>
/// <param name="id"></param>
/// <param name="name"></param>
/// <param name="type"></param>
/// <param name="privateEndpoint">Private endpoint which the connection
/// belongs to.</param>
/// <param name="privateLinkServiceConnectionState">Connection state of
Expand Down
4 changes: 2 additions & 2 deletions src/Monitor/Monitor/OutputClasses/PSVoiceReceiver.cs
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@ namespace Microsoft.Azure.Commands.Insights.OutputClasses
/// </summary>
public class PSVoiceReceiver : PSActionGroupReceiverBase
{
// <summary>Gets or sets the country code.</summary>
/// <summary>Gets or sets the country code.</summary>
public string CountryCode { get; set; }

/// <summary>Gets or sets the phone number.</summar>
/// <summary>Gets or sets the phone number.</summary>
public string PhoneNumber { get; set; }

/// <summary>Initializes a new instance of the PSVoiceReceiver class</summary>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ public class AutoscaleNotification : Monitor.Models.AutoscaleNotification
/// <summary>
/// Initializes a new instance of the AutoscaleNotification class.
/// </summary>
/// <param name="autoscaleNotification">The autoscale notification</param>
public AutoscaleNotification()
: base()
{
Expand Down
2 changes: 1 addition & 1 deletion src/Monitor/Monitor/TransitionalClasses/MetricSettings.cs
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public class MetricSettings : Monitor.Models.MetricSettings
/// <summary>
/// Initializes a new instance of the MetricSettings class.
/// </summary>
/// <param name="logSettings">The metric settings</param>
/// <param name="metricSettings">The metric settings</param>
public MetricSettings(Monitor.Models.MetricSettings metricSettings)
: base()
{
Expand Down