Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export and Import Configs #18371

Merged
merged 1 commit into from
Jun 17, 2022
Merged

Conversation

isra-fel
Copy link
Member

@isra-fel isra-fel commented Jun 1, 2022

Description

This PR implemented exporting and importing of configurations.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:

@isra-fel isra-fel force-pushed the config-export-import branch from 3ae17a1 to 65885b6 Compare June 14, 2022 01:05
@@ -168,7 +168,7 @@ By default it is CurrentUser.
Type: Microsoft.Azure.PowerShell.Common.Config.ConfigScope
Parameter Sets: (All)
Aliases:
Accepted values: CurrentUser, Process, Default
Accepted values: CurrentUser, Process
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is expected as we do not allow clearing "Default" configs

@VeryEarly
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@isra-fel
Copy link
Member Author

This one test case is constantly failing.

[xUnit.net 00:08:41.52]     Commands.Network.Test.ScenarioTests.PrivateLinkServiceTests.TestResourceManagerPrivateEndpoint [FAIL]
    X Commands.Network.Test.ScenarioTests.PrivateLinkServiceTests.TestResourceManagerPrivateEndpoint [1s 71ms]
EXEC : error Message:  [D:\a\1\s\build.proj]
     System.Management.Automation.ActionPreferenceStopException : The running command stopped because the preference variable "ErrorActionPreference" or common parameter is set to Stop: 
     Unable to find a matching HTTP request for URL 'GET /subscriptions/08b18a9d-315d-4e7b-9bcc-abcf418031e7/resourceGroups/testPS/providers/Microsoft.Authorization/resourceManagementPrivateLinks/RMPL?'. Calling method Item().

Have you noticed this in other PRs? @VeryEarly

@VeryEarly
Copy link
Collaborator

This one test case is constantly failing.

[xUnit.net 00:08:41.52]     Commands.Network.Test.ScenarioTests.PrivateLinkServiceTests.TestResourceManagerPrivateEndpoint [FAIL]
    X Commands.Network.Test.ScenarioTests.PrivateLinkServiceTests.TestResourceManagerPrivateEndpoint [1s 71ms]
EXEC : error Message:  [D:\a\1\s\build.proj]
     System.Management.Automation.ActionPreferenceStopException : The running command stopped because the preference variable "ErrorActionPreference" or common parameter is set to Stop: 
     Unable to find a matching HTTP request for URL 'GET /subscriptions/08b18a9d-315d-4e7b-9bcc-abcf418031e7/resourceGroups/testPS/providers/Microsoft.Authorization/resourceManagementPrivateLinks/RMPL?'. Calling method Item().

Have you noticed this in other PRs? @VeryEarly

haven't see this one before, but I did see similar issue where recorded request cannot be found even if there are no related test changes

@VeryEarly
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly VeryEarly merged commit 6acd4bf into Azure:main Jun 17, 2022
@isra-fel isra-fel deleted the config-export-import branch June 20, 2022 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants